Tags:
create new tag
, view all tags

Feature Proposal: Customizable Top Bar Sizing

Motivation

It is relatively easy for a user to add a logo to the top bar except when the logo must be larger than the prescribed size. If for some reason, the logo must be larger, that becomes a complicated problem. It is not always reasonable to tell the user to resize their logo to fit the TWiki size.

Description and Documentation

To achieve a convenient change, currently we must change TWiki.WebTopBar or override the topbar template, either out of reach for the casual user.

I propose to introduce a variable such as WEBLOGOSIZE which determines the height of the topbar in pixels. This variable would be set by default to the default height, and otherwise raise the height as desired.

Examples

Impact

Implementation

All this takes (on TWiki 4.3.1) is to insert into the WebTopBar the following

height=%WEBLOGOSIZE%

-- Contributors: ThomasWeigert - 2010-09-11

Discussion

I support this. Rather than associating this with logo size, it might be better to associate it with the height of the top bar, e.g. by introducing a TOPBARHEIGHT preferences setting. The PatternSkin defines a css style #patternTopBar in viewtopbar.pattern.tmpl with value height:64px;. The TopMenuSkin overloads it. It can easily be defined as height:%TOPBARHEIGHT%px;.

-- PeterThoeny - 2010-09-14

Yes, that would be fine as well. All we need is some easy way of increasing that size...

-- ThomasWeigert - 2010-09-15

If you want please go ahead and put your name and date as committed developer to make the one week review period clock start ticking.

-- PeterThoeny - 2010-09-15

Peter's suggestion above is very good. The current scheme is awkward: it allows WebTopBar to be customized, but it does not allow the height of this bar to be customized, limiting the usefulness of the customization. "You can do anything you want as long as it fits into 64px."

-- ThomasWeigert - 2010-09-26

No concerns have been raised, this is now a proposal that is AcceptedBy7DayFeedbackPeriod.

Please create a bug tracking item and list it in the form below.

This is a small and safe enough feature that can go into the next TWiki-5.0 patch release.

-- PeterThoeny - 2010-10-02

This has not been implemented in HelsinkiRelease, so I change it to IstanbulRelease.

-- PeterThoeny - 2011-03-26

Since implementation of TWikibug:Item6659, "Customizable web-specific top bar" that went into 5.0.2 patch release, it is now possible to customize the top bar size. Does that fit your needs Thomas?

-- PeterThoeny - 2011-05-16

Judging from the description in the bug report it should be good. Thanks.

-- ThomasWeigert - 2011-05-16

I am setting this to "closed proposal".

-- PeterThoeny - 2011-08-23

Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2011-08-23 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.