Tags:
create new tag
, view all tags

Feature Proposals » Customize TopMenuSkin action buttons

Summary

Current State: Developer: Reason: Date: Concerns By: Bug Tracking: Proposed For:
MergedToCore YaojunFei AcceptedByReleaseMeeting 2014-08-19   TWikibug:Item7546 KampalaRelease

Edit Form

TopicSummary:
CurrentState:
CommittedDeveloper:
ReasonForDecision:
DateOfCommitment:   Format: YYYY-MM-DD
ConcernRaisedBy:
BugTracking:
OutstandingIssues:
RelatedTopics:
InterestedParties:
ProposedFor:
TWikiContributors:
 

Motivation

TopMenuSkin can provide more flexibility on customizing top bar buttons. Then we can make our new skin compatible with TopMenuSkin.

Description and Documentation

We create a new skin to override action buttons on top right corner, but this skin can't be compatible with TopMenuSkin because it hard coded the top bar buttons in "data/TWiki/TopMenuSkinTopBar.txt", which leaves other skin users no option to customize it. This enhancement includes two changes

  1. Change "data/TWiki/TopMenuSkinTopBar.txt" to allow customize top bar buttons.
    • The action buttons on top right corner is defined by the template c
  2. Change "templates/view.topmenu.tmpl" to allow override the CSS definition of the top bar buttons area.
    • Setup the default action buttons for
      %TMPL:P{"topbarbuttons"}%
    • Separate the topbardimensions definition into three small parts "twtopbar", "twtopbarbuttons" and "twtopbarpattern" to make css override is more flexible.

Examples

Impact

Implementation

-- Contributors: Yaojun Fei - 2014-08-19

Discussion

Looks good.

-- Peter Thoeny - 2014-08-19

Feature is accepted by KampalaReleaseMeeting2014x08x21

-- Peter Thoeny - 2014-08-21

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2014-09-04 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.