Tags:
create new tag
, view all tags
Further to this thread, on 25 Feb 2001, PeterThoeny said in an email to MartinCleaver:

FYI, John Talintyre is working on attachments under revision control and other attachment manipulation at the TWiki::Store backend. We still need to figure out the UI changes, this should be discussed in AttachmentsUnderRevisionControl


We have implemented a "delete/undelete" function for attachments which has the following
basic charcteristics:

  • the function "attach" extends the filename with the revision number
    (e.g. perl.gif -> perl-r23.gif)
  • a function "delete" removes the attachment entry in the topics attachment table
    • a new topic revision is generated for the topic
    • the attached file remains in the folder
    • the topic content is not modified otherwise
  • there is an "undelete" option in the action column of predecessor revisions
    (only for those files which are not part of the file attachment list of the latest

revision)

    • a new topic revision is generated
    • the undeleted/restored attachment is reinserted into the attachment table;
      the attached file keeps the "old" revision extension
      (i.e "perl-r26.gif")

We would like to discuss the concept.

-- WolfgangSteinke and KamiloStankiewicz - 21 Jul 2000


The DeleteAttachment topic is not only about deleting attachments, but also about

version control. I like the idea of version controlling the attachments, this is a feature

that has been requested sometimes. Thank you for sharing your ideas. Do you intend to share

the Perl code as well?

Very good idea to remove the file from the table when deleting the attachment, but to leave

the actual file untouched.

The main TWiki core should be extended with this feature. Some issues need to be addressed:

  1. File name of latest attachment version should be the original file name. The reason is

to be able to download a file (i.e. Word document), make some changes, and then upload it

again. The user should not need to rename a file (e.g. remove the trailing -r1.23 ) when

going through the download/edit/upload cycle.

  1. Undelete should use a "oops" dialog, not a form inside the topic. This is to be

consistent with the rest of TWiki, and to avoid confusion. (As an example, look at the

"Compare Revision" dialog, defined by the oopsrev.tmpl template)

I am not sure how to solve issue 1. May be we could use the original file name for the first

revision, and then, when the file is updated, to rename the original file by appending a

revision number. Another possibility would be to use RCS in binary mode, that means there

would be a repository file besides the actual file.

-- PeterThoeny - 22 Jul 2000

I agree with PeterThoeny that the file name left as the original would be best. I

think it was cleaver the way you took advantage of the current versioning to find the

name(s) of the attachments. But my users and myself would prefer a versioning number that

started as 1.1 and incremented monotonically. With the current scheme they would be

confused.

I think this is a good start and I will try to come up with some constructive sugestions

later on this week.

-- HaroldGottschalk - 22 Jul 2000


Thank you for your sugesstions regarding the file revision info and the update procedure! We

have modified our concept as follows:

  • the function "attach" extends the filename with a revision number
    • the syntax is e.g. perllogo.gif -> perllogo--r0001.gif
    • a new attachment starts with the revision number 0001; when the new file to be

attached (e.g. text.txt) is an deleted attachment of a former revision (e.g. text--r0017.txt

deleted in ExampleTopic r1.115) the new attachment will get the revision number --r0018

instead of --r0001

    • the attachment table shows the file name (perllogo.gif) and in a separate column

(title "--r") the file revision number (0001)

  • the function "update"
    • increments the revision number of an existing attachment
    • repaces the attachment list entry with a new one
  • a function "delete" removes the attachment entry in the topics attachment table
    • a new topic revision is generated for the topic
    • the attached file remains in the folder
    • the topic content is not modified otherwise
  • there is an "undelete" option in the action column of predecessor revisions
    (only for those files which are not part of the attachment list of the latest revision)
    • a new topic revision is generated
    • the undeleted/restored attachment is reinserted into the attachment table
    • an Ooops dialog is started - it requests a new comment; a standard comment is

offered which explains the file history

As soon as we've tidied up the Perl code we will contact PeterThoeny to discuss the

integration procedure (to provide the diff files seems not to be a suitable way because

there other modifications which are not relevant for the community).

-- WolfgangSteinke and KamiloStankiewicz - 28 Jul 2000


Here is an example for an attach - update session:

A test page ...

del10.gif

Select the file to be attached (perllogo.gif) and upload it ...

del11.gif

The file is uploaded; a new revision (--r0001) is generated;
the revision number is shown in a file revision column;
a "delete" function is offered in

the action column (by selecting the "delete" function the file is removed from the table)

...

del12.gif

By selecting the "update" function the origin file name is offered ...

del13.gif

An upload is performed; a new topic revision is generated;
the revision number is incremented (--r0002);
the topic content is not modified;

del14.gif


This picture shows the Ooops dialog of the "undelete" function. It requests a new comment...

del15.gif

-- WolfgangSteinke and KamiloStankiewicz - 28 Jul 2000

Topic attachments
I Attachment History Action Size Date Who Comment
GIFgif del01.gif   manage 8.6 K 2000-07-21 - 08:44 WolfgangSteinke Picture01
GIFgif del02.gif   manage 8.3 K 2000-07-21 - 08:45 WolfgangSteinke Picture02
GIFgif del03.gif   manage 14.3 K 2000-07-21 - 08:46 WolfgangSteinke Picture03
GIFgif del04.gif   manage 12.1 K 2000-07-21 - 08:46 WolfgangSteinke Picture04
GIFgif del05.gif   manage 14.3 K 2000-07-21 - 08:47 WolfgangSteinke Picture05
GIFgif del06.gif   manage 16.3 K 2000-07-21 - 08:47 WolfgangSteinke Picture06
GIFgif del07.gif   manage 14.6 K 2000-07-21 - 08:47 WolfgangSteinke Picture07
GIFgif del08.gif   manage 14.5 K 2000-07-21 - 08:48 WolfgangSteinke Picture08
GIFgif del09.gif   manage 15.6 K 2000-07-21 - 08:48 WolfgangSteinke Picture09
GIFgif del10.gif   manage 8.3 K 2000-07-28 - 14:42 WolfgangSteinke Picture10
GIFgif del11.gif   manage 11.3 K 2000-07-28 - 14:42 WolfgangSteinke Picture11
GIFgif del12.gif   manage 14.2 K 2000-07-28 - 14:43 WolfgangSteinke Picture12
GIFgif del13.gif   manage 13.9 K 2000-07-28 - 14:43 WolfgangSteinke Picture13
GIFgif del14.gif   manage 14.3 K 2000-07-28 - 14:44 WolfgangSteinke Picture14
GIFgif del15.gif   manage 7.9 K 2000-07-28 - 14:44 WolfgangSteinke Picture15
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2001-09-29 - MikeMannix
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.