create new tag
, view all tags

Bug: Edit variable prevents reuse

Enter description here

The Edit variable is used in view.tmpl to abstract away from the difference between editing a local wiki and a mirror site, I think. I am not sure whether this mechanism is really working as the preference variables MIRRORSITENAME, MIRRORVIEWURL are not discussed in the manual in the preference section.

However, it has the effect that one cannot simply write a new template that replaces the action on the edit button, as the Edit hides this. Well, one can replace the edit button in the view template, for example, but when going into an earlier revision, this edit button will not be struck out by the code in bin/view.

I think it would be better to explicitly define the edit button in view.tmpl.

Test case


TWiki version: Athens
TWiki plugins: n/a
Server OS: n/a
Web server: n/a
Perl version: n/a
Client OS: n/a
Web Browser: n/a

-- ThomasWeigert - 29 Jun 2002

Follow up

This came up in discussions about the fix for RefreshEditPage - I implemented a %EDITURL% variable in TWikiAlphaRelease for this reason, but ColasNahaboo had some ideas for improvements to this. This is important for skins that don't use the default Edit link.

I realise that my RefreshEditPage fixes probably won't work for sites using the mirror features, but since these are not documented anywhere, as you point out, I have a slight excuse smile

-- RichardDonkin - 30 Jun 2002

Fix record

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2002-06-30 - RichardDonkin
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.