Tags:
create new tag
, view all tags

Bug: Undocumented command to fix a topic alters time stamp and user.

The undocumented feature to fix a topic without increasing the revision or changing the user does change the user and also sets the time stamp. The correct spec (as it was with 01 Dec 200 release) is not to change the timestamp nor user name.

Test case

  • User A creates a topic.
  • User B (an admin) fixes the topic with the undocumented repRev command
  • Revision shows now current time stamp and user name instead of the original ones.
  • Diff shows the correct information. This is an indication that the meta data gets updated incorrectly.

Environment

TWiki version: 01 Sep 2001
TWiki plugins: N/A
Server OS: N/A
Web server: N/A
Perl version: N/A
Client OS: N/A
Web Browser: N/A

-- PeterThoeny - 25 Sep 2001

I can understand the delRev command so leave username and time stamp as it was, but given the admin can alter the revision when using repRev this is not so clear cut. However, I assume that the admin should be only making minor tweaks (to fix things) and so most of the changes will still be by the original author and hence the nead to leave information as it was.

-- JohnTalintyre - 28 Sep 2001

The same command is effectively used when a user updates a topic within a short period (default one hour). However, I think the timestamp for the change should be the last change.

-- JohnTalintyre - 30 Sep 2001

The old spec for updating the same topic by the same user within one hour was that the recorded time stamp (not file timestamp) was not changed with each save operation, it remained the time of the first topic save. It is up to debate if this is good or not. It was this way to prevent unnecessary e-mail notifications (i.e. a users changes a topic 10 minutes before a notification and then after 20 minutes again, e.g. there is now an entry for the new notification interval too).

Fixing a topic by an admin should definitely not change the user name nor recorded time stamp (but should change the file timestamp).

John, do you have time to make this change for the AthensRelease?

-- PeterThoeny - 25 Nov 2001

Fix record

Reverted to old spec, user and date does not change. File timestamp still changes, so that sync programs stll work. In TWikiAlphaRelease and TWiki.org.

-- PeterThoeny - 30 Nov 2001

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2005-02-15 - SamHasler
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.