create new tag
, view all tags
I just discovered that if you have a form field with the same name as one of the parameters to one of the scripts that gets passed forms (save, preview etc) then there is a conflict.

Testcase: create a form with a field called "text". Try and use it hehe!

-- CrawfordCurrie - 24 Jun 2005

This was an early design decision. The likelihood the someone names a field name text (instead of Text) is small.

A fix would introduce incompatibilities with existing text, thus I consider this bug report as a "not to be fixed" issue.

-- PeterThoeny - 25 Jun 2005

Well, the bug was found by a user who did exactly that; named a field text; so it has happened at least once.

I assume when you say "introduce incompatibilities" you mean that existing topics that include form fields for delivery to TWiki scripts will be broken.

Of course there is another way to fix this, and that is to document the field names that are not permitted in forms. I made a start at capturing all the parameters used on scripts in http://develop.twiki.org/~develop/cgi-bin/view/TWiki/TWikiScripts

-- CrawfordCurrie - 26 Jun 2005

OK, I changed it back to use the simple name, but added an exception that fires if an illegal name is used for a form field. Of course this will only fire when the form definition object is created, which means if you edit a form definition and save it, it won't fire until you actually try to use that definition in a context where the form object is created, such as an edit. But since use of an illegal field name is a relatively rare case, that should be OK.

-- CrawfordCurrie - 26 Jun 2005

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2005-06-26 - CrawfordCurrie
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.