Tags:
create new tag
, view all tags

Feature Proposal: Forms Should Evaluate the Size Field

Motivation

See Support/SID-00620 for the starting point.

To avoid redundant information, its desirable that its possible, to use a INCLUDE at the size field of a form.

Description and Documentation

If you use a INCLUDE at the values field of a form, it works. That should also be possible, if using a INCLUDE at a size field.

Probably a small and useful change.

EDIT:

To make the change go to Tlib/TWiki/Form.pm, search for $size ||= ''; then copy the lines after $vals ||= '';

$vals = $this->{session}->handleCommonTags(
    $vals, $this->{web}, $this->{topic}, $meta);
$vals =~ s/<\/?(nop|noautolink)\/?>//go;
$vals =~ s/^\s+//g;
$vals =~ s/\s+$//g;

behind $size ||= ''; an change $val to $size. That's it.

Examples

Impact

WhatDoesItAffect: Rendering

Implementation

-- Contributors: HorstEsser - 2009-11-12

Discussion

I consider this a no-brainer, e.g. you could check this in before the 14 day period is over. I think this should go into SVN trunk, as well as TWikiRelease04x03 branch so that we have this available in the next 4.3.x patch release.

Sopan, what is your take?

-- PeterThoeny - 2009-11-17

Corresponding bug tracker item: Item6365

-- HorstEsser - 2009-11-22

I've checked in the changes to the trunk.

To get sure that the changes work on the developer system, I need CHANGE permission for http://develop.twiki.org/~twiki4/cgi-bin/view/Sandbox/WebPreferences . Please provided me the required access.

-- HorstEsser - 2009-11-22

Don't use the Sandbox web on develop.twiki.org, it will be overwritten with auto-updates. Use the LiterTray web instead. Let us know in case you don't have access.

-- PeterThoeny - 2009-11-22

Sopan, do you want this small enhancement also in the 4.3 branch? Horst, if so, check it in also in the branch.

-- PeterThoeny - 2009-11-23

Peter - the small enhancements should go in the branch.

-- SopanShewale - 2009-11-23

I've checked in the change on the branch and have set the corresponding bug tracker item Item6365 to "waiting for release".

Consequentially I've changed the ProposedFor field to GeorgetownRelease.

-- HorstEsser - 2009-11-29

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2009-12-03 - HorstEsser
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.