Tags:
create new tag
, view all tags

Bug: RelativeTopicPathAlwaysAppendsWeb

%RELATIVETOPICPATH% always adds the local web to the variable, even when you give the explicit web name.

Because of this bug, USERLAYOUTTOPIC and USERSTYLETOPIC do not work across webs.

Test case

Setting USERLAYOUTTOPIC: point it to a topic in Sandbox

Testing RELATIVETOPICPATH: ../Sandbox.BlueStyle (should return

../Sandbox.BlueStyle
)
Testing USERSTYLETOPIC: BlueStyle (should return BlueStyle)
Testing USERSTYLEURL (should get generated from USERSTYLETOPIC): (should return
../Sandbox.BlueStyle?skin=text&contenttype=text/css
)

Environment

TWiki version: TWikiAlphaRelease
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS:  
Web server:  
Perl version:  
Client OS:  
Web Browser:  

-- ArthurClemens - 03 Aug 2004

Follow up

Is this fix needed? Can we defer that to after Cairo?

-- PeterThoeny - 08 Aug 2004

If left unfixed for Cairo, UsingTopicToDefineCSS will be an undocumented feature in PatternSkin. It should be removed from TWikiPreferences too then.

-- ArthurClemens - 08 Aug 2004

OK, lets defer this to Dakar.

-- PeterThoeny - 08 Aug 2004

In the interest of KISS, any chance of retiring this feature?

-- PeterThoeny - 05 Sep 2004

I would very much have this feature. It allows greater flexibility than using attachments: you can edit the style online like any other topic.

-- ArthurClemens - 06 Sep 2004

Fix record

Seeing the style of this page, looks like it works now. Automatically?

If USERLAYOUTURL and USERSTYLEURL are set in TWikiPreferences, these will override the topic as style settings.

It also works now fine in the TWiki web: PatternSkinExampleTopicIncludingBlueStyle.

I am marking this bug as solved.

-- ArthurClemens - 06 Sep 2004

There is still something CODE_SMELLy, when I add ?skin=pattern to this topic I get:

<style type="text/css" media="all">
        /* Default TWiki layout */
        @import url("http://TWiki.org/p/pub/TWiki/PatternSkin/layout.css");
        /* Default TWiki style */
        @import url("http://TWiki.org/p/pub/TWiki/PatternSkin/style.css");
        /* Custom overriding layout per web or per topic */
        @import url("../Codev/%USERLAYOUTTOPIC%?skin=text&amp;contenttype=text/css");
        /* Custom overriding style per web or per topic */
        @import url("../Sandbox.BlueStyle?skin=text&amp;contenttype=text/css");
        .twikiToc li {
                list-style-image:url(http://TWiki.org/p/pub/TWiki/PatternSkin/i_arrow_down.gif);
        }               
        .twikiWebIndicator {
                background-color:#F9D1C9;
        }
</style>

Notice the ../Codev/ URL and the not resolved %USERLAYOUTTOPIC% variable. Why do we need relative URL? Why would not an absolute URL path like %SCRIPTURLPATH%/Web/Topic work?

BTW, because of this bug Google was blocked by BlackListPlugin from spidering TWiki.org, caused by the two extra page accesses when not authenticated. (I added the Google IP address range to the WHITELIST)

-- PeterThoeny - 06 Sep 2004

And now I have to authenticate to view the page. Hmm...

I would love to see a solution that works and that does not give an unresolved url. In the meantime I've removed the settings in TWikiPreferences.

In UsingTopicToDefineCSS a number of solutions have been discussed. In the end this seemed the best. Looks like we have to look at it again. Please (all) offer your support if you want this feature!

-- ArthurClemens - 06 Sep 2004

This was assigned to DakarRelease but until there is a better idea of what the problem is and how to solve it, assigning it to a release is a bit premature.

-- CrawfordCurrie - 14 Feb 2005

This bug has been resolved. Issues that have been raised since 06 Sep 2004 are solved with enhancements to UsingTopicToDefineCSS. I am closing this issue.

Note: the third test case above returns a false result because "Using topics to define styles" in TWikiPreferences has been disabled. On my test TWiki I get valid results.

-- ArthurClemens - 30 Apr 2005

Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2005-04-30 - ArthurClemens
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.