Feedback on LDAPPasswordChangerPlugin

-- LuisCamposDeCarvalho - 24 May 2004

I'm getting an error with the latest beta of TWiki (20040507?) and perl 5.8.2 under mod_perl with apache2.0.49:

Undefined subroutine &TWiki::Plugins::LDAPPasswordChangerPlugin::genDialog called at /usr/lib/twiki/TWiki/Plugins/LDAPPasswordChangerPlugin.pm line 97.

Solution: UndefinedSubroutineinLDAPPasswordChangerPlugin

-- AdamTheo - 24 May 2004

Luis:

• I changed the form on the Plugin topic to the PackageForm, please fill in the details.
• I made some changes to the text. Please use an InterwikiPlugin name for your name since your user home topic most likely will not exist on a a system where your Plugin gets installed.

-- PeterThoeny - 25 May 2004

Thank you for help, PeterThoeny. I've just filled in the details.

Mr. AdamTheo, I've just uploaded a new copy, with forward declarations for the subs. Please test it and tell me what you think about this plugin. Thank you very much for the interest and for sending a message.

-- LuisCamposDeCarvalho - 25 May 2004

Luis, better to use always the same name for the zip file, do not include the release version in the name. TWiki's attachments are under version control; automated tools expect <topicname>.zip file names.

Quickly glancing over the code, you are using undocumented calls. For portability better to use only FuncDotPm calls:

• Replace &TWiki::Prefs::getPreferencesValue with TWiki::Func::getPreferencesValue
• Replace $TWiki::userName with TWiki::Func::wikiToUserName( TWiki::Func::getWikiName( ) )

Small detail. TWiki typically uses %VARIABLE% names with percent signs and $variables within %VARIABLE% or settings. See for example FormattedSearch and InterSiteLinkRules. If you want to make it consistent you could change %s to $name in the LDAP_FILTER.

Your Plugin assumes that the user is authenticated. Possibly document that. Also, you could display the user name in a form field so that users can change their login name if needed.

-- PeterThoeny - 25 May 2004

OK, lets try again: about the attached files with release name, please remove them. They're no more up-to-date. (I have not enought permissions to (re)move them, is this ok?)

About the portability issues, I guess they're all resolved. I rewrote some pieces and now everything is under the Documented Official TWiki Interface. Thank you for the tip.

About the small detail: I don't understand what you mean, sorry. I'm not a native english speaker. What I've done was to force the replacement of %VARIABLES% when I pick up the LDAP_FILTER preference value, so you can now write

* Set LDAP_FILTER = (&(objectClass=posixAccount)(uid=%USERNAME%))

and everything will work fine.

Finally, but not least important, I documented the fact that this plugin assumes you're authenticated and that it makes no sense to make it available for a Guest user.

I have one last question: I would like to read about the usability and about new suggestions for this plugin. Is there any place I should post and ask about this or this wiki is the right place?

Thank you very much for the time spent and for the tips. I love this WikiWikiWeb, congratulations for your excellent work.

-- LuisCamposDeCarvalho - 27 May 2004

I removed the extra attachment. I also added you to the TWikiCommunityGroup so that you can move/remove content (please review that topic).

The LDAP_FILTER setting with %USERNAME% should work. (In the previous version you had (uid=%s). My feedback was to use somthing else then %s, like for example (uid=$name).)

This topic here is the right place to ask for feedback.

-- PeterThoeny - 28 May 2004

checked .zip file into CVSplugins:LDAPPasswordChangerPlugin

-- WillNorris - 24 Nov 2004

(See TakeOutBlocksFunctionFatalError for more info). I'm getting the same sort of error with the SVN updates with this plugin as I am with SectionalEditPlugin. I don't exactly know what happened, but it seems to have to do with handleCommonTags (in TWiki.pm) and expandCommonVariables (in Func.pm). I'm still following the trail.

-- EricCote - 25 Aug 2006