create new tag
, view all tags

Archive of RevCommentPluginDev

Thanks Christoph for contributing this Plugin. With this and other changes, TWiki resembles more MediaWiki. I guess something people wish to have.

Small detail, may be I misinterpret this, but from the REVCOMMENT parameter list it does not look like the bullet lists can be terminated to be XHTML compliant.

This functionality might be better provided in the core code? There are some related topics in the Codev web.

-- PeterThoeny - 11 May 2005

Thanks for the hint about the non-XHTML compliant parameter list. This has now been fixed.

-- JChristophFuchs - 11 May 2005

I concur that such functionality ought to be in the core.

-- MartinCleaver - 16 May 2005

checked .zip into CVS

-- WillNorris - 19 Jul 2005

I'm using a Beta build of Dakar: Thu, 22 Sep 2005 build 6515. The release notes state that the plugin works, but not as advertised. I cannot get it to work at all.

I am getting the following error on the Admin page: RevCommentPlugin: (disabled)

I'm getting the following error on my InstalledPlugins page: TWiki::Plugins::RevCommentPlugin::initPlugin did not return true (0)

It appears as enabled in the Configuration page.

Thanks for any help!

-- RobertPudlik - 19 Oct 2005

RevCommentPlugin has not been updated for Dakar. I am working on this, but due to lack of time please do not expect any final version before Christmas.

-- JChristophFuchs - 25 Nov 2005

i updated RevCommentPlugin for Dakar (see Bugs:1243). i still have to modify the templates, though.

-- WillNorris - 26 Dec 2005

Where are the updated src for the Dakar?

-- AnanSiharath - 27 Feb 2006

in SVN

-- WillNorris - 27 Feb 2006

The Plugin topic should be updated with the latest version and zip file.

What was the issue that it did not work on Dakar? Please consider upgrading this Plugin so that it runs on Cairo and Dakar codebase as described in HandlingCairoDakarPluginDifferences.

-- PeterThoeny - 27 Feb 2006

Thanks WillNorris. I got the src and it works.

The plugin topic needs to be updated with the latest source code.

But here is the error message I got:

During save of Main an error was found by the version control system. Please notify your TWiki administrator.

=Can't locate object method "read" via package "TWiki::Meta" at /www/twiki2/lib/TWiki/Plugins/RevCommentPlugin.pm line 288. TWiki::Plugins::RevCommentPlugin::beforeSaveHandler('%META:TOPICINFO{author="AnanSiharath" date="1141079069" forma...','WebHome','Main','TWiki::Meta=HASH(0xa852e9c)') called at /www/twiki2/lib/TWiki/Plugin.pm line 225 TWiki::Plugin::invoke('TWiki::Plugin=HASH(0xa79ef88)','beforeSaveHandler','%META:TOPICINFO{author="AnanSiharath" date="1141079069" forma...','WebHome','Main','TWiki::Meta=HASH(0xa852e9c)') called at /www/twiki2/lib/TWiki/Plugins.pm line 303 TWiki::Plugins::_dispatch('TWiki::Plugins=HASH(0xa574f9c)','beforeSaveHandler','%META:TOPICINFO{author="AnanSiharath" date="1141079069" forma...','WebHome','Main','TWiki::Meta=HASH(0xa852e9c)') called at /www/twiki2/lib/TWiki/Plugins.pm line 617 TWiki::Plugins::beforeSaveHandler('TWiki::Plugins=HASH(0xa574f9c)','%META:TOPICINFO{author="AnanSiharath" date="1141079069" forma...','WebHome','Main','TWiki::Meta=HASH(0xa852e9c)') called at /www/twiki2/lib/TWiki/Store.pm line 762 TWiki::Store::saveTopic('TWiki::Store=HASH(0xa57508c)','TWiki::User=HASH(0xa7faa28)','Main','WebHome','---+!! Welcome to the Main web \x{a}Congratulations, yo...','TWiki::Meta=HASH(0xa852e9c)','HASH(0xa885884)') called at /www/twiki2/lib/TWiki/UI/Save.pm line 427 TWiki::UI::Save::__ANON__() called at /www/twiki2/lib/CPAN/lib///Error.pm line 387 eval {...} called at /www/twiki2/lib/CPAN/lib///Error.pm line 379 Error::subs::try('CODE(0xa8858c0)','HASH(0xa885908)') called at /www/twiki2/lib/TWiki/UI/Save.pm line 435 TWiki::UI::Save::save('TWiki=HASH(0x9f31d20)') called at /www/twiki2/lib/TWiki/UI.pm line 97 TWiki::UI::__ANON__() called at /www/twiki2/lib/CPAN/lib///Error.pm line 387 eval {...} called at /www/twiki2/lib/CPAN/lib///Error.pm line 379 Error::subs::try('CODE(0xa83b224)','HASH(0xa852b54)') called at /www/twiki2/lib/TWiki/UI.pm line 146 TWiki::UI::run('CODE(0xa53da18)') called =

-- AnanSiharath - 27 Feb 2006

Hey WillNorris,

I tried out the updated src. There is a bug - I am not sure if it's because you have not change the template yet or not. But everytime an attachment is added to the page the page will lose the text. The page text either get overwritten with blank or deleted.

This plugin is very important for us since we want to be able to leave comments about what has been changed. It would be really great if you get this to work with darkar release and hopefully soon.

Thanks in advance

-- AnanSiharath - 07 Mar 2006

Updated this plugin in TWiki4 branch (actually, not much work to do, as this plugin is now integrated into both Classic and Pattern skins as shipped, except for WebChanges).

Feel free to use for input to next release!

-- SteffenPoulsen - 10 Apr 2006

This plugin does not work well with TWikiDrawPlugin. If enabled, when a drawing is saved, entire topic text is removed and an empty topic is saved.

I wonder if this has to do with beforeSaveHandler logic in RevCommentPlugin?

-- SteffenPoulsen - 12 Apr 2006

I am sorry to announce that I am no longer able to do any work on this plugin. For more information please read JChristophFuchsStopsWorkOnTWikiPlugins.

-- JChristophFuchs - 13 Apr 2006

Thanks for your effort, JC, appreciated!

-- SteffenPoulsen - 14 Apr 2006

Topic revision: r1 - 2006-04-14 - SteffenPoulsen
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.