Question

Background: I receive the following error messages in my Apache error.log:

[Wed Mar 01 11:13:27 2006] [error] [client 192.168.0.238] [Wed Mar  1 16:13:25 2006] c:\\twiki\\bin\\save: Useless use of a constant in void context at c:/twiki/lib/TWiki/Plugins/ActionTrackerPlugin/ActionTrackerConfig.pm line 37.\n
[Wed Mar 01 11:13:27 2006] [error] [client 192.168.0.238] [Wed Mar  1 16:13:25 2006] c:\\twiki\\bin\\save: Use of uninitialized value in string eq at c:/twiki/lib/TWiki/Plugins/ActionTrackerPlugin/ActionTrackerConfig.pm line 37.\n
[Wed Mar 01 11:13:31 2006] [error] [client 192.168.0.238] [Wed Mar  1 16:13:30 2006] c:\\twiki\\bin\\view: Useless use of a constant in void context at c:/twiki/lib/TWiki/Plugins/ActionTrackerPlugin/ActionTrackerConfig.pm line 37.\n
[Wed Mar 01 11:13:31 2006] [error] [client 192.168.0.238] [Wed Mar  1 16:13:30 2006] c:\\twiki\\bin\\view: Use of uninitialized value in string eq at c:/twiki/lib/TWiki/Plugins/ActionTrackerPlugin/ActionTrackerConfig.pm line 37.\n

The relevant text from my ActionTrackerConfig.pm file is:

  # Command quote ' for unix, \" for Windows. Copy from TWiki.cfg
  $cmdQuote         =
    $TWiki::cmdQuote ||
      "'";
      "\"" if( $OS eq "WINDOWS" ); 

• Line 37 (which appears in the error message) is: "\"" if( $OS eq "WINDOWS" );
• I can force the error to occur by editing a topic in my TWiki site and then saving the changes. If I immediately open the error.log located under my Apache installation, the error messages are listed for the date and time corresponding to the edit/save I made.
• The error appears even when I edit a "plain topic" - that is, one that doesn't have the ActionTracker? inserted in it.

Questions: I have searched the entire TWiki.org site for information on this error and haven't found anything that really applies.

• First: How do I resolve this issue?
  • Can I comment out or delete line 37 only?
    • What are the consequences of doing this?
    • I've tried both and verified the error no longer appears; however, might there be undesireable side effects or issues as a result?
• Second: What is the $cmdQuote command/value used for?

Environment

-- JasonVensel - 01 Mar 2006

Answer

The line 37, as it stands here, has no effect and can safely be deleted. Looks like if at some point in time ActionTracker's own calculation of $cmdQuote has been replaced by using TWiki's config setting, but the final line of the old code has been left over inadvertedly.

-- HaraldJoerg - 02 Mar 2006

Excellent! Thanks for the prompt response, Harald. I'm marking this answered.

-- JasonVensel - 02 Mar 2006