In a effort to rationalize the handling of variants in the "view" skin:
differences when edit and attach links are active, raw/normal view,
use of a
oopscreate template to create topics, I have modified the
bin/view
script to:
- replace the CSS declaration in view template, from:
.invisibleInNormal {display:none}
to:
.invisibleInRaw {display:none}
So that links "Raw view" and "Normal view" can be make visible or invisible depending on their CSS class
- when trying to view a non-existing topic, if the current skin has a
oopscreate template, use it, otherwise fallback to the previous code. The oopstemplate using CSS classes passed as HTTP parameters in the URL to make visible or not the warning "This topic name is not a Wiki Word"...
For the TWiki developers: this is just a suggestion in a possible refactoring view with more templates/CSS usage.
But the main reason of my creating this topic is to attach a ready-to-use patch for users of the
KoalaSkin (I make
KoalaSkin use a standard TWiki install, plus patches, all of these patches being published here)
--
ColasNahaboo - 17 Dec 2002
NOTE: The Koala Skin install instructions say that this patch is still required but it no longer applies cleanly. The first hunk does but the second fails:
patching file bin/view
Hunk #1 succeeded at 158 with fuzz 2 (offset 14 lines).
Hunk #2 FAILED at 236.
1 out of 2 hunks FAILED -- saving rejects to file bin/view.rej
--
AdamShand - 26 Feb 2003
Oops, sorry, I overlooked it. Here is the fixed version for the Beijing release:
--
ColasNahaboo - 28 Feb 2003
Perfect, it applied cleanly. Thanks.
--
AdamShand - 03 Mar 2003
Looks harmless and useful enough. However, the TWiki::UI refactoring is going to make this annoying to merge into CVS, so I'm going to mark it as
PatchAdjustmentRequired for now.
--
WalterMundt - 20 Apr 2004
Patch (v3) updated for Cairo
--
ColasNahaboo - 30 Dec 2004
Hey Colas, does this work on
DevelopBranch too?
--
MartinCleaver - 30 Dec 2004