Implemented: INCLUDE Attachment With https Protocol

Existing functionality:

1. TWiki does already optimize the INCLUDE of an attached file: The file gets included on the file level, bypassing an http request in case TWiki detects that the URL is in the namespace of file attachments.
2. TWiki does not yet support the INCLUDE of a URL with https protocol.

That is, an INCLUDE of an attachment does not work if TWiki itself is installed under https. This small enhancement fixes that, it allows the inclusion of .txt and .html attachments under https by reading attached file directly, also if TWiki runs under hhtps.

Index: TWiki.pm
===================================================================
--- TWiki.pm    (revision 3186)
+++ TWiki.pm    (working copy)
@@ -2035,7 +2035,7 @@
     my $rev     = $params{"rev"}      || "";
     my $warn    = $params{"warn"}     || "";

-    if( $incfile =~ /^http\:/ ) {
+    if( $incfile =~ /^https?\:/ ) {
         # include web page
         return handleIncludeUrl( $incfile, $pattern, $theWeb, $theTopic );
     }

Change is in SVN's MainBranch.

A possible enhancement is IncludeUrlWithHttpsProtocol.

Contributors:
-- PeterThoeny - 09 Nov 2004

Discussions

Which release did this go in?

-- SamHasler - 15 Feb 2005