Bug: develop changes breaks on TestCases web

http://develop.twiki.org/~develop/cgi-bin/changes/TestCases/ breaks with error message

Undefined subroutine CGI::del
 at /home/virtual/site2/fst/home/develop/twikisvn/lib/TWiki/Render.pm line 1538
   TWiki::UI::__ANON__('Undefined subroutine CGI::del^J at /home/virtual/site2/fst/home/d...') called at /usr/lib/perl5/5.6.1/Carp.pm line 119
   Carp::croak('Undefined subroutine CGI::del^J') called at /usr/lib/perl5/5.6.1/CGI.pm line 639
   CGI::_compile called at /usr/lib/perl5/5.6.1/CGI.pm line 604
   CGI::AUTOLOAD(undef) called at /home/virtual/site2/fst/home/develop/twikisvn/lib/TWiki/Render.pm line 1538
   TWiki::Render::summariseChanges('TWiki::Render=HASH(0x86120fc)', undef, 'TestCases', 'TestCaseAutoFormatting', 1, 2, 1) called at /home/virtual/site2/fst/home/develop/twikisvn/lib/TWiki/UI/Changes.pm line 91
   TWiki::UI::Changes::changes('TWiki=HASH(0x80fbbf0)') called at /home/virtual/site2/fst/home/develop/twikisvn/lib/TWiki/UI.pm line 133
   TWiki::UI::run('CODE(0x81f5320)') called
   Error::subs::run_clauses('HASH(0x8650a20)', 'Undefined subroutine CGI::del^J at /home/virtual/site2/fst/home/d...', undef, 'ARRAY(0x81670ec)') called at /home/virtual/site2/fst/home/develop/twikisvn/lib/Error.pm line 394
   Error::subs::try('CODE(0x86504a8)', 'HASH(0x8650a20)') called at /home/virtual/site2/fst/home/develop/twikisvn/lib/TWiki/UI.pm line 190
   TWiki::UI::run('CODE(0x81f5320)') called at changes line 29

Test case

See http://develop.twiki.org/~develop/cgi-bin/changes/TestCases/

Environment

-- MartinCleaver - 17 Apr 2005

Impact and Available Solutions

Follow up

Martin, did you ever try what I asked you to try? use CGI qw( :html4 ) in Render.pm?

-- CrawfordCurrie - 17 Apr 2005

It doesn't happen on my sites, only on ntwiki.

And I can't change ntwiki directly.

-- MartinCleaver - 17 Apr 2005

del^J ???

btw, which version of CPAN:CGI is ntwiki running? (that question's probably for sven)

-- WillNorris - 17 Apr 2005

perl -e 'use CGI; print $CGI::VERSION'

2.752

-- SvenDowideit - 19 Apr 2005

ok, it does appear to be exported by :html4, although i recommend :standard instead, which includes :html2 :html3 :html4 :form :cgi

-- WillNorris - 19 Apr 2005

oh, you already changed it to :html4, so it must be the ^J, but how did a control-j get in there??? Undefined subroutine CGI::del^J

-- WillNorris - 19 Apr 2005

arg, the exports for CGI shouldn't matter anyway, as you're calling it with a full namespace qualifier.

-- WillNorris - 19 Apr 2005

Could this be a line termination problem? I sometimes put the ( on the next line (clutching at straws)

-- CrawfordCurrie - 19 Apr 2005

i don't know, i'm grasping at straws now, too...

here's the code in question:

                if( $tml ) {
                    $block =~ s/^-(.*)$/CGI::del( $1 )/se;
                    $block =~ s/^\+(.*)$/CGI::ins( $1 )/se;
                }

i even did a hexdump -C and it looks fine.

the only thing i see left is $1, but...?

-- WillNorris - 19 Apr 2005

cvs2svn issue? (don't think so, just throwing out more possibilities...)

-- WillNorris - 19 Apr 2005

According to http://search.cpan.org/src/LDS/CGI.pm-3.07/cgi_docs.html HTML4 tags are not fully supported until version 2.79 of CGI.pm.

I will have to work out which tags I added that were HTML4 and revert them to text strings. It looks like at least span is supported in the version on ntwiki.

-- CrawfordCurrie - 19 Apr 2005

Fix record

OK, fixed by adding

use CGI qw( -any )

The problem was the very old version of CGI on develop.twiki.org.

Discussion