Bug: Renaming topic and using square brackets for the new name breaks several things

Originally entered in RenameDoesNotCorrectSpacedTopics

Hello,

Somewhat related to this bug (in Dec2001 build), is this bug:

• make a topic with WikiWord
• put references to this topic in other topics (especially subtopics)
• rename this WikiWord topic
  • type in [[My Spaced Word]] with the brackets
  • keep the boxes checked to replace the use of this topic's word
• this will do bad things:
  • the WikiWord data file will be moved to a file called '[[My Spaced Word]].txt'
  • the other topics' data files will have incorrect parents
    • it will say the parent = "[[My Spaced Word]]" instead of the correct parent="My_Spaced_Word" (or should it be parent="MySpacedWord" ?)
  • this will do odd things when this topic is attempted to be created (since it can't really exist??), for example it created a link to a (nonexistent) topic called '<span%20style='background%20:'
    • NOTE this is a seperate bug, which happens if you try to go here: http://twiki.org/cgi-bin/view/Main/[[Topic]]
    • this bad text generation screws lots of things.

-- TWikiGuest - 12 Apr 2002 jcline(at)ieee.org

Since the above I also noticed that the attachments were moved to the broken directory name also. i.e. they were moved from the old topic directory to a square bracket named directory:

• oldtopic/attach.txt --> [[newtopic]]/attach.txt

I fixed this by renaming the directory manually.

-- TWikiGuest - 16 Apr 2002

Test case

See above

Environment

-- TWikiGuest - 16 Apr 2002 jcline(at)ieee.org

Follow up

The rename script had a FIMXE entry relating to checking that the new topic name was a WikiWord as this was only suggested on the rename page. I will now code to inforce a WikiWord, relaxed to allow alpha-numerics if a checkbox is selected.

Thank you for raising the error, it would be appreciated if you would register and use a non guest login.

-- JohnTalintyre - 16 Apr 2002

I'm part way through a fix with encouragement to use WikiNames, but we still need the option of creating other topics names e.g. all Caps. But, there's not filter for undesirable characters in use for general topic creation either, although $securityFilter in TWiki.cfg suggests it is use for topic creation.

Fix record

Now will reject a non WikiWord for the new topic name unless an overide checkbox is ticked, even then only letters that get through the security filter are allowed.

-- JohnTalintyre - 19 May 2002

Oops, still not completely fixed if non WikiWord option is selected.

-- JohnTalintyre - 20 May 2002

I think I've got it right now

-- JohnTalintyre - 25 May 2002