Feedback on EditContrib

-- ThomasWeigert - 07 Mar 2005

Wow Thomas, you produce extensions at such a high rate it is hard to keep up! Thanks for the contribution!

-- PeterThoeny - 08 Mar 2005

A heads-up... I am in the process of moving more functionality from MultiEditPlugin, ThreadedDiscussionPlugin, and SectionalEditPlugin into this ContribPackage.

-- ThomasWeigert - 12 Mar 2005

Completed above update. Also resolved a problem that arose in SectionalEditPlugin due to inconsistent handling by various browsers of URL parameters passed from forms to scripts.

-- ThomasWeigert - 20 Mar 2005

Your latest version of EditContrib does not provide a means for handling CDATA any differently than PCDATA. I insist on searching for a better solution.

-- MarioFrasca - 21 Mar 2005

Mario, if we move in twiki core to pass the text from the preview page in a different variable than from the edit script, I will make the corresponding adjustment in this plugin also. Otherwise, as I am inheriting the code from preview and save, I am limited to treating these cases alike. The price is small: needlessly scan the text passed in the section that was edited for decoding in TWiki::Render::decodeSpecialChars, but I understand your concern for efficiency. The suggestion you posted in InconsistentTreatmentOfTextEncoding would work.

-- PeterThoeny - 22 Mar 2005

Thomas, I did some text formatting on the contrib topic (and NewContribTemplate); could you incorporate that in your next release? Done, sorry just noticed this comment -- TW 1 May 2005

-- PeterThoeny - 22 Mar 2005

It looks like this plugin (or it's related ones) does some caching that doesn't agree with SpeedyCGI. I've seen the same problem with both SectionalEditPlugin and MultiEditPlugin (but not EditTablerowPlugin). Running under SpeedyCGI, the last version of the page renders as well as the newly-saved version, so you keep getting longer and longer pages on view (where bin/view is running under Speedy). Turning off SpeedyCGI stops this immediately. This is a shame, because Speedy was giving me a serious performance increase (20+%).

-- MarcusLeonard - 01 May 2005

OK, I installed SpeedyCGI and it was an easy fix... the problem was actually not in EditContrib, but the two mentioned plugins. New versions have been uploaded. Leonard, thanks for pointing this out...

-- ThomasWeigert - 01 May 2005

Cripes, Thomas - you're too fast! I was just thinking about when to run some tests and now I see you've done it. You the man. Cheers.

-- MarcusLeonard - 03 May 2005

Thomas: Do you already have a version of EditContribDev that's compatible to DevelopBranch? I would like to try it.

-- FranzJosefSilli - 04 May 2005

Sorry, not yet. I was working on other things on DevelopBranch.... But it will be no different from the one for Cairo....

-- ThomasWeigert - 04 May 2005

We all appreciate your work. Thanks a lot! I will stay patient.

-- FranzJosefSilli - 04 May 2005

Added a work around to the problem of SomeBrowsersLoseInitialNewlineInTextArea. I believe I have caught all the areas were this causes problems. But please provide feedback if I have missed some...

-- ThomasWeigert - 04 Aug 2005

As said on the beta ViewDEVELOP:TWiki/DakarReleaseNotes, this contrib "Needs to be updated, as some functionality has been moved into core." Does somebody plan to do it before Dakar release ? I'd really like to see this happen, since SectionalEditPlugin depends on EditContrib.

-- BenVoui - 05 Oct 2005

Check for a minimalistic "replacement" for SectionalEditPlugin that works in Dakar in the attachments of SectionalEditPluginDev

-- RafaelAlvarez - 05 Oct 2005

I've noticed some issues in TWiki v4 that seem to be attributable to differenes between Cairo and Dakar in EditContrib. Has anybody successfully managed to get it to work with the latest TWiki?

-- SergioRotstein - 24 Feb 2006

To the Plugin maintainer: Please consider upgrading this Plugin so that it runs on Cairo and Dakar codebase. HandlingCairoDakarPluginDifferences has more.

-- PeterThoeny - 27 Feb 2006

On a related note, is there an eta for when this will be Twiki4 Compliant? If it is alreay, apologies, but I couldn't find anything concrete regarding if this was confirmed.

Thanks

-- EricHanson - 12 May 2006

I have been testing the SVN version of EditContrib and have encountered a problem. Specifically the problem occurs when I'm using SectionalEditPlugin. It appears that the Topic Parent is not saved when saving using SectionalEdit. After probing around I think that EditContrib is the problem. It appears that EditContrib is not properly populating variables that are used in the edit process. The variables are originalrev, templatetopic, and newtopic. On a side note I have sessions turned off on my TWiki.

I'm using Dakar release.

-- RyanMarotz - 16 May 2006

Ryan, I cannot imagine how SectionalEditPlugin is working for you given that you have Dakar installed. I am uploading Dakar compatible versions soon, so please consider retesting after that.

-- ThomasWeigert - 12 Jun 2006

Upgraded to Dakar. The cairo version is still available. I am uploading new versions of dependent plugins shortly.

-- ThomasWeigert - 12 Jun 2006

Ryan, I fixed the bug you listed in SVN r10233. Internet access for me was limited at the time, so my apologies in not posting a notice here on the Dev topic (I thought I had).

Thomas, Ryan was using the SVN version, which had been modified for use with Dakar. At some point, we should integrate our changes.

BTW - good to see you are back contributing code.

-- ScottHoge - 13 Jun 2006

Sounds good. I'll take a look at the SVN version. Did you do anything else than port the code? From above it sounds as if there are still some problems.

-- ThomasWeigert - 13 Jun 2006

So, not to be too pedantic, but I noticed that the Plugin page says that this has been tested on 4.0.0, is the attached zip now TWiki4 compliant?

-- EricHanson - 30 Jun 2006

Yes, but not backwards compatible, as there are too many differences.

-- ThomasWeigert - 09 Jul 2006

I just checked the EditContrib in SVN and the latest uploaded version here is newer than on SVN. This means that us that test continuously against a pseudo-install from the TWiki4 branch on SVN do not test with updated versions of this contrib that so many other plugins depend on.

It would be really nice if you would svn commit your changes. It takes those two words to do it.

-- KennethLavrsen - 08 Jul 2006

Ken, ok. Do you have test cases that you run against this plugin? I can include them in the unit test suite...

In SVN 10899.

-- ThomasWeigert - 09 Jul 2006

The developers are the ones running unit tests.

I focus on real life testing. Ie. I run several test servers both at home and at the office with webs with real data and twiki applications that I copy over from my production servers.

One is generally available to the community: http://merlin.lavrsen.dk on which I run a SVN checkout from the TWikiRelease04x00 branch. It gets updated every 30 minutes. Plugins are turned on and off on demans but it requires that they are on SVN.

Thanks for checking in your changes. It is truely nice to see you back on the project Thomas. You have been dearly missed

-- KennethLavrsen - 09 Jul 2006

Added the capability of properly editing included sections. For TWiki 4.1 only, also return properly from edit if editing included topic.

Note that due to changes between TWiki 4.0 and 4.1, the twisties in the edit mode do not work under Twiki 4.0.x. There is no easy way to support the changes in templates that were made....

-- ThomasWeigert - 01 Jan 2007

I am finding that trying to Edit or Comment a topic that utilizes ThreadedDiscussionPlugin generates a error from EditContrib:

Can't call method "enterContext" on an undefined value at /Volumes/Storage/PerlScripts/[ourTwiki]/lib//TWiki/Contrib/EditContrib.pm line 52.

Looking at the code, this error refers to: "$session->enterContext( 'edit' );"

I'm a somewhat novice Twiki admin and not much of a coder, so I could use some help.

-- RonCostin - 25 Jan 2007

The ThreadedDiscussionPlugin does not work with TWiki 4.0 or beyond yet. This is evidenced by the above error.

-- ThomasWeigert - 25 Jan 2007

Uploaded a new version provided by MichaelDaum, which has some code cleanup as described in Bugs:Item3848.

-- ThomasWeigert - 09 Apr 2007

I've run into a problem that shows up when I have MultiEditPlugin enabled but it appears to really have to do with EditContrib so I'm noting it here. If one INCLUDES a topic with view restrictions (Topic A) in a topic that doesn't have view restrictions (Topic B) and then a user (with rights to view B but not A) tries to view Topic B, the page will not render and the following error message is displayed:

Undefined subroutine &TWiki::Contrib::EditContrib::Include41::isTrue called

What should happen (and does if MultiEditPlugin) is not enabled, is that Topic B is displayed, but without the part that's included from Topic A. BTW, neither topic A or B has any section tags in them.

-- LynnwoodBrown - 06 Apr 2007

I found a problem in the svn version of this Contrib if running the svn version of TWiki. Some internal function names, the contract between internal compoments and some other things in the core changed. As this contrib calls directly the core, it stopped working (at least in rev 13708).

I'm attaching a patch for this Contrib that solves the problem. I don't know if it contains more than it should (I basically sync'ed the code in the contrib with the code in the core).

-- RafaelAlvarez - 17 May 2007

There is a bug in the the 10 Apr 2007 version of EditContrib rendering

Undefined subroutine &TWiki::Contrib::EditContrib::Include41::isTrue called

I fixed it by changing

file: \twiki\lib\TWiki\Contrib\EditContrib\Include41.pm

row 93: if( isTrue( $warn )) {

change it to: if( TWiki::isTrue( $warn )) {

I've attached a patch.

-- AndyNilsson - 15 Aug 2007

Andy, thanks for the patch. I just ran into the same problem...

-- CarloSchulz - 24 Oct 2007

Had the same problem. Andy's patch fixed ist. Big thx ...

-- WolfgangBertl - 09 Nov 2007

There's a bug with TWiki4.2. The method _expandAllTags called in lib/TWiki/Contrib/EditContrib/Include40.pm and in lib/TWiki/Contrib/EditContrib/Include41.pm doesn't exist in TWiki4.2. Rename it as expandAllTags.

-- MassimoMancini - 27 Jan 2008

Uploaded Massimos patch

-- CarloSchulz - 12 Feb 2008

There seems to be another problem with 4.2. . When I create a new web, an error is shown, but the web is created. The shown error:

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information. Can't call method "checkAccessPermission" on an undefined value

In the warnings log (warn200802.txt):

Can't call method "checkAccessPermission" on an undefined value at /path/to/TWiki/lib/TWiki/Contrib/EditContrib/Include41.pm line 91.
   TWiki::Contrib::EditContrib::Include41::_INCLUDE('TWiki=HASH(0x81a5a08)', 'TWiki::Attrs=HASH(0x8a30c74)', 'WebHome', 'Help', undef) called at /path/to/TWiki/lib/TWiki.pm line 2660
   TWiki::_expandTagOnTopicRendering('TWiki=HASH(0x81a5a08)', 'INCLUDE', '"TWiki.WebBottomBar"', 'WebHome', 'Help', undef) called at /path/to/TWiki/lib/TWiki.pm line 2581
   TWiki::_processTags('TWiki=HASH(0x81a5a08)', '^J^J<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"...', 'CODE(0x834911c)', 16, 'WebHome', 'Help', undef) called at /path/to/TWiki/lib/TWiki.pm line 2505
   TWiki::expandAllTags('TWiki=HASH(0x81a5a08)', 'SCALAR(0x834f388)', 'WebHome', 'Help', undef) called at /path/to/TWiki/lib/TWiki.pm line 2857
   TWiki::handleCommonTags('TWiki=HASH(0x81a5a08)', '^J^J<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"...', 'Help', 'WebHome') called at /path/to/TWiki/lib/TWiki/UI/Oops.pm line 121
   TWiki::UI::Oops::oops('TWiki=HASH(0x81a5a08)', 'Help', 'WebHome', 'CGI=HASH(0x80fd624)', 0) called at /path/to/TWiki/lib/TWiki/UI/Oops.pm line 55
   TWiki::UI::Oops::oops_cgi('TWiki=HASH(0x81a5a08)') called at /path/to/TWiki/lib/TWiki/UI.pm line 159
   TWiki::UI::__ANON__() called at /path/to/TWiki/lib/CPAN/lib//Error.pm line 379
   eval {...} called at /path/to/TWiki/lib/CPAN/lib//Error.pm line 371
   Error::subs::try('CODE(0x80f6084)', 'HASH(0x89ea1f8)') called at /path/to/TWiki/lib/TWiki/UI.pm line 197
   TWiki::UI::run('CODE(0x8216374)', 'oops', 1) called

-- IngoBlickling - 12 Feb 2008

I'm having exactly the same problem as Ingo Blickling. However, this error only occures when adding a Topic with an non WikiWord as the Topic name (e.g. Test doesn't work, TestTest does) or when I try to attach a file to a topic with an whitespace in the name (e.g. "Mark Spencer.jpg" brings an error, Markspencer.jpg works).

Is there any solution for this problem?

-- AlexanderSeith - 07 Apr 2008

It seems this package and depending plugins aren't maintained upstream anymore.

-- MichaelDaum - 07 Apr 2008

AnilPillai posted a bug report with fix at Support.EditContribProblem on 2009-09-07.

-- PeterThoeny - 2009-09-07