Feedback on EmbedPlugin

-- MartinCleaver - 17 Dec 2004

I did some minor text fixes on the Plugin topic. You can take that back into the next release if you wish.

Also, it would be nice to get the PluginBenchmarks numbers documented.

Out of curiosity, what happened with this Plugin? The topic is new, yet the Plugin version and the bells.mp3 attachment is one year old. Puzzled.

-- PeterThoeny - 17 Dec 2004

This plugin should actually be renamed to something that conveys what it embeds. Something like EmbedMediaPlayerPlugin.

-- ArthurClemens - 18 Dec 2005

Hi together,

I started some test after reading things in EmbedPlugin, EmbedQTPlugin, GenericMediaInliner. I started playing around with the %INCLUDE functionality. Creating a topic with %STARTINCLUDING% %STOPINCLUDING% section, I have createe those lines to activate e.g. the Quicktime media player. With MichaelDaum's IfDefinedPlugin and the possibility to add more Params to %INCLUDE I have created a page which embeds an attached movie with this one %INCLUDE line. Isn't this the same call as if it would a special plugin ?

%INCLUDE{"Sandbox.QuickTimeApplet" DOCPATH="%PUBURL%/%TWIKIWEB%/QuickTimePlugin/tang.mov" WIDTH="300" HEIGHT="250"}%

The code of my "Sandbox.QuickTimeApplet" Topic is

%STARTINCLUDE%
<object classid="clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B" codebase="http://www.apple.com/qtactivex/qtplugin.cab"  width="%IFDEFINED{"%WIDTH%" then="%WIDTH%" else="100%"}%" height="%IFDEFINED{"%HEIGHT%" then="%HEIGHT%" else="100%"}%"> 

<param name="src" value="%IFDEFINED{"%DOCPATH%" then="%DOCPATH%"}%" />
<param name="controller" value="true" />

<object type="video/quicktime" data="%IFDEFINED{"%DOCPATH%" then="%DOCPATH%"}%" width="%IFDEFINED{"%WIDTH%" then="%WIDTH%" else="100%"}%" height="%IFDEFINED{"%HEIGHT%" then="%HEIGHT%" else="100%"}%" class="mov">

<param name="controller" value="true" />
  Your movie could not be played!
</object>
</object>
%STOPINCLUDE%

Like this you could create very easy for each Applet or Object an so on a topic with the specific code to activate them. Now my question: For what you will need an extra plugin then ?

I will create a zip with my content and attach this to twiki.org. How should this be deployed ? As an Plugin or an Addon or Application ? Thanx for your comments

Tom

-- ThomasFreudenberg - 15 Sep 2006

Yes, this is a good example of ParameterizedIncludes. It is a TWikiApplication component. Eventually we will have a dedicated web for TWiki applications and its components. For now, please feel free to package it as a AddOnPackage.

-- PeterThoeny - 15 Sep 2006

Hi Peter, thanx for answer, so I will create an AddOnPackage for this. I guess I will decide also a separate twiki web like e.g. _EmbedAddon were all the funny includes are find their place. By the way, should I also create the same in public area to place additional attachments like the applets jar's and so on ? Maybe its easier to pack a zip and place it here, so you can have a look on it.

The things in ParameterizedIncludes won't work for now, this are only a conceptional diskussion or did I miss something ? I would prefer the function of %STARTINCLUDE{ foor="value" ... }. Its mor declarative, and you could see the possible param on entry. For now I will use the IfDefinedPlugin if it is ok for you. The standard %IF does not work, I think the additional parameters are not available at the time when the expression ist tested, %IF{ defined %INCLUDEPARAM% then="%INCLUDEPARAM%" else="default value"} returns always then value "default value".

Is this right, or did I make something wrong ? Thanx for your help.

-- ThomasFreudenberg - 15 Sep 2006

Since we are just taking of one or a few topics I would package them in the TWiki web.

On parameterized includes, hmm an %IF should work. However, I tried to do that but failed to test for existence of a parameter, see IncludeTestParamIncl.

-- PeterThoeny - 19 Sep 2006

Hi Peter, yes packing them in TWiki web is ok. Thanx for your test, it shows exactly what my problem is, I couldn't check existing of paramter. That's why I used %IFDEFINED{}% Plugin from MichaelDaum. I would prefer to use %IF{}%, but I do not know yet where to fix ist. Could you fix this or can you give me a hint were to find (is it located in TWiki.pm $ifFactory) ? otherwise we can use %IFDEFINED.

-- ThomasFreudenberg - 19 Sep 2006

I filed Bugs:Item2880 in regards to IF with parametrized INCLUDE issue. The IF processing is done in TWiki::If, e.g. lib/TWiki/If.pm.

-- PeterThoeny - 19 Sep 2006

Hi Peter, please have a look at my comment at Bugs:Item2880. I am not sure if it is/was already solved.

-- ThomasFreudenberg - 19 Sep 2006

Hi Peter, please have a look at my additional comment at Bugs:Item2880. I am not sure if you have already noticed it.

-- ThomasFreudenberg - 20 Sep 2006

This plugin should either be renamed or removed.

See Bugs:Item1195

-- CrawfordCurrie - 12 Feb 2007

No, it is better marked as obsolete, regardless if recreated with new name or not.

-- PeterThoeny - 14 Feb 2007

On inspection, I agree that it is misnamed. If I recall, I named it this way as I didn't see the point in having 12 different EmbedXPlugins - rather better to have one plugin that could have 12 different types of embed.

-- MartinCleaver - 12 Apr 2007

On TWiki 4.2, I get the following error message:

Can't use string ("EMPTYPLUGIN_EXAMPLE") as a HASH ref while "strict refs" in use at /var/www/html/lib/TWiki/Prefs.pm line 246.

-- JosMaccabiani - 10 May 2007

Remove this from twiki/lib/TWiki/Plugins/EmbedPlugin.pm:

    # Get plugin preferences, the variable defined by:          * Set EXAMPLE = ...
    $exampleCfgVar = &TWiki::Prefs::getPreferencesValue( "EMPTYPLUGIN_EXAMPLE" ) || "default";

and you should be OK. Someone need sto repacke this plugin.

-- PeterThoeny - 16 May 2007

Thanks, I'm now using ObjectPlugin, which seems to work just fine as well.

-- JosMaccabiani - 16 May 2007

After talking to Piers, I've updated ObjectPlugin to support the EMBED tag so it can be a drop in replacement for EmbedPlugin, changed the output to avoid the WikiWord problem as noted above by Jason, added youtube support, and moved the html into template files to make adding more file types not require code changes.

-- SvenDowideit - 21 Oct 2008

-- SvenDowideit - 21 Oct 2008