Feedback on PerforcePlugin

-- StephaneLenclud - 14 Feb 2008

Plan of action

• It would be nice to have a variable giving you the change list that needs to be integrated (or reverse integrated) from a branch specification (and the from path). To do that we would need: DONE
  • Run p4 integrate -n -b myBranchName and parse the output
  • For each output line run a p4 changes command, concatenate the results and get ride of duplicates
  • Format and return the output as with =P4CHANGES=

Discussions

Thanks Stephane for contribution this (early) plugin. I added the form, could add the form field details? You can tag the plugin topic too so that it can be accessed.

-- PeterThoeny - 14 Feb 2008

I'm having funny problems with the AJAX functionality on a 4.1.2. whereas it was working just fine on 4.2 (Windows installation).

I double checked that my REST stuff was working on 4.1.2 and it does work. So I'm baffled, as the REST URL specified in the JQuery load is correct and I just can't explain why FF and IE hangs for a while when I push the fetch button. I thought it could be some JQuery issue but JQuery does work fine, even with the exact same code replacing the REST URL with a static page JQuery works. So no AJAX on my production server for the time being as I have absolutly no clue how to debug JS.

-- StephaneLenclud - 20 Feb 2008

The code looks like:

<input type="button" value="Fetch perforce changes" onclick="$('#loaddiv').load('/bin/rest/PerforcePlugin/p4changes?topic=%WEB%.%TOPIC%&_DEFAULT=-m 10&format=| $changelist | $date | $description | $user | $status | $n', {}, function(){$('#loaddiv').toggle('slow');})"/>

<div style="display: none" id="loaddiv"> empty </div>

Si if I replace the load URL with a static page AJAX works just fine. If I point my browser to the REST URL above I get the expected result!?!

-- StephaneLenclud - 21 Feb 2008

I fixed the issue above by making JQuery load use POST

-- StephaneLenclud - 22 Feb 2008

Feedback on documentation:

• Don't link to oneself, e.g. write ---+!! Perforce Plugin (see Jakob Nielsen's Alertbox)
• Possibly move description to above the TOC (and remove "Description" header)
• Use term "TWiki plugin variables" instead of " TWiki %TAG%". The word "tag" is an overloaded term.
• It would be useful to have the PluginBenchmarks documented.

-- PeterThoeny - 02 Mar 2008

Thanks for the review and the interesting link Peter. I won't bother doing de benchmark for now as I'm not familiar with PluginBenchmarks it would take me significant amount of time to get it done. Besides performance of that plug-in directly depends of the performance of the Perforce server it's talking to, its content and the type of Perforce request sent.

-- StephaneLenclud - 02 Mar 2008

Version 0.8 should be published soon. It fixes some issues with pending integration functionality where lines from the p4 integrate command would not be parsed. We also add the -d option to the p4 integrate command enabling integration around deleted files. Those extra options to the p4 integrate command could be made optionals. For now it remains hard coded.

-- StephaneLenclud - 16 Apr 2008