Feedback on X509UserPlugin

-- TimotheLitt - 23 Oct 2008

Thank you Timothe for sharing this plugin with the TWikiCommunity! X509 auth is very much in line with the TWikiMission.

Some feedback:

• Some configure setting are {Plugins}{X509}{...}, some are {Plugins}{X509UserPlugin}{...}. Not sure if this is intentional; may be use the latter form consistently?
• Add a SHORTDESCRIPTION (at Plugin Info section); the reports in the Plugins web depend on it.
• Are there really no dependencies?
• Minor fix in Plugin Info table: Un-escape HTML comments
• How about measuring and documenting the PluginBenchmarks?

-- PeterThoeny - 24 Oct 2008

Thanks for the feedback.

The {X509} discrepancy is a documentation bug. Sorry. I started thinking this would integrate with the core & used {X509}, but moved to a plugin model. They all are {Plugins}{X509UserPlugin} I didn't catch all the references in the topic text (I did in the code!). Uploaded corrected zip & topic.

SHORTDESCRIPTION - fixed.

Dependencies: Unless you count the standard perl library, there are none that I'm aware of besides TWIki 4.2.3. I double-checked; there are no use statements for anything else.

I think the comments were munged by the wysiwy(Almost)g editor. Fixed.

Benchmarks - don't see any point. This plugin only processes a single tag, which is only used on the registration topic. If there's a performance impact, it's either in the common framework (I just register a tag handler), or it only implacts that one - infrequently used topic.

Enjoy.

-- TimotheLitt - 27 Oct 2008

Timothe, does this plugin work on TWiki-5.0 and TWiki-5.1? If so could you updated the TestedOnTWiki field?

-- PeterThoeny - 2012-10-01

My production wiki doesn't run 5.x, so I haven't tested it there. No special concern, but if someone has an issue, I'll investigate.

-- TimotheLitt - 2012-10-02