Question
Crawford, perhaps you can address what I am seeing.
1> When an action is closed we are seeing the following being put into the "closer" option:
closer="Main.on"
2> When performing an ACTIONSEARCH with a format field of
$closed, any item returned by ACTIONSEARCH that has a state of
open causes the following to be printed:
BAD DATE FORMAT see ActionTrackerPlugin?
My expectation would be that the data returned would simply be a blank cell. The actual ACTIONSEARCH command is:
%ACTIONSEARCH{ topic="%TOPIC%ReviewActions" format="|$who|$text|$state|$closed|$closer|" header="|Who:|What:|Current
State:|When Closed:|Closed By:" orient="rows" }%
$closer is producing the expected result - a blank cell when the status is
open.
I've searched SUPPORT and have not seen this question asked. Version of the plugin is 2/6/2004.
thanks
--
SteveRJones - 12 Apr 2004
Environment
--
SteveRJones - 12 Apr 2004
Answer
I can't reproduce your first problem, but it sounds like an incompatibility between the edit template and the code. Check that no-one has modified edit.action.tmpl, and that you correctly upgraded it.
The second issue is expected behaviour; if you haven't closed the action, the closed date is a bad date.
--
CrawfordCurrie - 27 Apr 2004
Thanks Crawford, I'll check the template.
Question: Why would the expected behavior for item two display an error message? I would expect, at most, the cell to simply be blank.
Thanks
--
SteveRJones - 27 Apr 2004
Well, I have looked at "edit.action.tmpl" and it appears to be the right one, is the same as the one included in the 2/6/2004 update, and looks like this:
%TMPL:INCLUDE{"twiki"}%
%TMPL:P{"htmldoctype"}%
<head>
<title> %WIKITOOLNAME% . %WEB% . %TOPIC% %TMPL:P{"titleaction"}%</title>
<meta http-equiv="Content-Type" content="text/html; charset=%CHARSET%" />
<meta name="robots" content="noindex" /> %HTTP_EQUIV_ON_EDIT%
<META HTTP-EQUIV=Expires CONTENT="Sun, 22 Mar 1998 16:18:35 GMT" />
<base href="%SCRIPTURL%/view%SCRIPTSUFFIX%/%WEB%/%TOPIC%" />
<script language="JavaScript">
<!--HIDE
function launchWindow( theWeb, theTopic ) {
win = open( "%SCRIPTURLPATH%/view%SCRIPTSUFFIX%/" + theWeb + "/" + theTopic + "?skin=plain",
theTopic, "titlebar=0,width=500,height=480,resizable,scrollbars");
if( win ) {
win.focus();
}
return false;
}
//STOP HIDING-->
</script>
</head>
<body bgcolor="#ffffff"">
#PageTop
%TMPL:DEF{"titleaction"}%(edit)%TMPL:END%
%TMPL:DEF{"titlehelp"}% %TMPL:END%
%TMPL:DEF{"webaction"}%Edit action from %WEB%.%TOPIC% %TMPL:END%
%TMPL:P{"simpleheader"}%
%TEXT%
#PageBottom
</body>
</html>
I'll try this in the sandbox and see if it comes out differently.
--
SteveRJones - 27 Apr 2004
I thought perhaps there might be something strange with the particular skin being used - but no. But instead of getting that wierd "Main.on" I now simply see
closer="". I tried this under Firebird as well as IE. Where does
ActionTracker pick up the twiki user name?
--
SteveRJones - 27 Apr 2004
Steve, a blank date
is a bad date. Since the date type is handled evenly throughout the code, if we were to reinterpret a blank date as a null string, then we wouldn't get the bad date warning on the "due" field. I'm not prepared to put in special handling just for the "closed" field.
The twiki user name is otained from the TWiki core code.
The completion of the closed and closer fields is handled by Action::populateMissingFields. If you read that bit of code you should be able to follow the logic easily enough.
BTW you can get a quicker response from me if you use IRC (see
TWikiIRC)
--
CrawfordCurrie - 08 May 2004
Closed answered because the answer has not been followed up by the reporter.
--
CrawfordCurrie - 02 Jun 2004