Question:

META formfield Display appears Broken, Is this a valid fix?

After upgrading from 4.1.2 to 4.2, pages that Included META tags for form fields came up blank and didn't work

%META{ "formfield" name="ProjTitle"}%

Looking in the Twiki.pm for 4.2 shows that the function that renders the formfield has changed from 4.1

I was able to restore functionality using the following change:

--- lib/TWiki.pm 2008-04-23 13:06:50.000000000 +1000
+++ lib/Twiki.pm.orig   2008-04-23 13:37:42.000000000 +1000
@@ -3795,7 +3795,7 @@
         return $meta->renderFormForDisplay( $this->templates );
     } elsif ( $option eq 'formfield' ) {
         # a formfield from within topic text
-        return $meta->renderFormFieldForDisplay( $params->{'name'}, '$value' );
+        return $meta->renderFormFieldForDisplay( $params );
     } elsif( $option eq 'attachments' ) {
         # renders attachment tables
         return $this->attach->renderMetaData( $web, $topic, $meta, $params );

So I have some questions:

• Is this a Bug?
• Is this fix complete?
• Should the fix be on the renderFormFieldForDisplay function in Meta.pm and not the Twiki.pm?
  • The renderFormFieldForDisplay function appears to be called correctly from /ActionTrackerPlugin/Action.pm and the Search.pm.

Thanks, -- SimonHarrison - 23 Apr 2008

Environment

-- SimonHarrison - 23 Apr 2008

Answer

If you answer a question - or someone answered one of your questions - please remember to edit the page and set the status to answered. The status selector is below the edit box.

Please file a bug report so that developers can look at it.

-- PeterThoeny - 03 Jun 2008