Tags:
create new tag
view all tags

Question

Multiple edits within one hour suddenly makes new revisions.

After upgrading from Cairo to Dakar 4.0.1 ALL edits render new revisions. No matter what ReplaceIfEditedAgainWithin variable says.

If switching to RcsLite in LocalSite.cfg it works as expected.

Any clues?

The configure script reports that everything is fine. However testenv (from CVS) fails heavily. $OS is never defined, which must be a script bug, and then the rest of the output is just nonsense. Does the testenv script ever read LocalSite.cfg?

/Johan

N.B On this support site it seems to work smile

Environment

TWiki version: TWikiRelease04x00x00
TWiki plugins: Dakar Defaults
Server OS: Debian/Sarge Linux
Web server: Apache2
Perl version: 5.8.4
Client OS: Any
Web Browser: Any
Categories: Version control

-- TWikiGuest - 14 Feb 2006

Answer

ALERT! If you answer a question - or someone answered one of your questions - please remember to edit the page and set the status to answered. The status selector is below the edit box.

testenv is a red herring (as is the CVS repository; we use Subversion). Use configure.

I just checked this on a 4.0.1 install, and it works as expected (rev not incremented if edited again by the same user within an hour).

Exactly what is {ReplaceIfEditedAgainWithin} set to in LocalSite.cfg? What login manager and password manager are you using?

-- CrawfordCurrie

Hi!

I have the same problem here:

  • TWiki 4.0.1 on RHEL 4
  • Apache 1.3
  • Perl 5.8.7

LocalsSite.cfg does not contain the value ReplaceIfEditedAgainWithin, Login-Manager is ApacheLogin and Password Manager ist set to none since we are using LDAP for Authentification

-- SteveWeinreich - 15 Feb 2006

  • TWiki.conf: $cfg{ReplaceIfEditedAgainWithin} = 3600;
  • LocalSite.cfg: $TWiki::cfg{ReplaceIfEditedAgainWithin} = 3600;

Using ApacheLogin, HtPasswdUser, AuthType Basic

-- TWikiGuest - 16 Feb 2006 (Johan)

You are using LDAP? How is the user ID (login name and wikiname) determined? TWiki uses this to determine if the same user is saving again. If the user doesn't match for some reason in two successive saves, you might see this behaviour.

-- CrawfordCurrie - 17 Feb 2006

I upgraded to 4.0.2 and reverted from RcsLite to RcsWrap, and now it works as expected!

-- JohanRisberg - 12 Apr 2006

I also saw this behavior on TWiki 4.0.2 if I had mod_perl enabled for all the scripts in the twiki/bin directory. If I disable mod_perl then the revisions didn't increase. I left mod_perl active but only on the view type scripts and this seemed to work as well.

-- RickMach - 19 Jun 2006

Hi, I get this behaviour with 4.0.4, standard apache login, and RCSWrap. When I change the value of ReplaceIfEditedAgainWithin from the configure script, the values do get correctly updated in the LocalSite.cfg, but we still get a new revision every time an edit is made. I don't want to switch to RCSLite. Any ideas ?

-- SteveJonesST - 05 Sep 2006

Bumping this, as it's still bugging us here. I confirm that RcsLite has the correct behviour, but RcsWrap does not. I notice that my LocalSite.cfg has two values :

$cfg{ReplaceIfEditedAgainWithin} = "900"; # 3600
$TWiki::cfg{ReplaceIfEditedAgainWithin} = 1800;
Why is this ? Is one from my old cairo ? We specialise in typing errors here, and our revision numbers are going through the roof, so please help if you can. As we get different behaviour using RcsLite, RcsWrap, this must be a bug I guess.

-- SteveJonesST - 07 Sep 2006

Same issue reported in EachSaveCreatesNewRevision

-- PeterThoeny - 25 Sep 2006

Steve, I would guess that you have either picked up a setting from elsewhere, or you edited the settings and forgot you did. configure never puts in comments, and always uses $TWiki::cfg and never $cfg.

The only difference between RcsWarp and RcsLite during this process is that RcsWrap invokes rlog to determine the author of the revision, whereas RcsWrap reads the file. If either the user saved in the file is different to the user currently saving, or the format of the output of the rlog command can't be parsed, then RcsWrap may think a different author is trying to save.

Could someone with this problem please run rlog on a file that is showing this problem, and paste the output here? The output must match the following regular epxression:

/^.*?date: ([^;]+);  author: ([^;]*);[^\n]*\n([^\n]*)\n/s
or the author won't get picked up and will default to the guest user.

-- CrawfordCurrie - 26 Sep 2006

Here is the output from rlog on a file which is showing the problem:

RCS file: NewRevTest.txt,v
Working file: NewRevTest.txt
head: 1.2
branch:
locks: strict
        twiki: 1.2
access list:
symbolic names:
keyword substitution: o
total revisions: 2;     selected revisions: 2
description:
none
----------------------------
revision 1.2    locked by: twiki;
date: 2006/09/26 14:55:45;  author: "AndrewJones";  state: Exp;  lines: +3 -1
"none"
----------------------------
revision 1.1
date: 2006/09/26 14:55:35;  author: "AndrewJones";  state: Exp;
"none"
=============================================================================

Hope this helps. I'm afraid I don't know much about regular expressions, so I wont try and suggest anything...

-- AndrewRJones - 26 Sep 2006

I notice that your topic has a lock by user twiki. TWiki 4 should have all topics unlocked. See TWikiInstallationGuide. Not sure if related, but unlock the topic and try after one hour to edit the topic repeatedly.

-- PeterThoeny - 27 Sep 2006

I could not find anything in the TWikiInstallationGuide or anywhere else which explains how to stop user twiki locking the files. However, I had decided to give up and use RcsLite instead, since everything seemed fine. Then today I looked in my Apache error log and found it was over 5 gb, which isnt too healthy... Seems RcsLite is flooding it with Deep recursion on subroutine... errors.

I am now again interested in fixing this RcsWrap problem and have reported my RcsLite problem as bug Item 2957.

Any help would be very much appreciated.

-- AndrewRJones - 03 Oct 2006

Sorry, that should have been TWikiUpgradeGuide, which documents how to unlock ,v files.

-- PeterThoeny - 28 Nov 2006

We unlocked all our files after the upgrade. This was a new topic, so it must be TWiki locking the files when the topic is created.

-- AndrewRJones - 28 Nov 2006

same but with no locked files: Set FORCENEWREVISIONCHECKBOX = $TWiki::cfg{ReplaceIfEditedAgainWithin} = 3600;

# rlog NetworkOverview.txt

RCS file: NetworkOverview.txt,v Working file: NetworkOverview.txt head: 1.94 branch: locks: strict access list: symbolic names: keyword substitution: kv total revisions: 94; selected revisions: 94 description: none


revision 1.94 date: 2012/11/30 15:57:06; author: PavelPotcheptsov; state: Exp; lines: +1 -4 none
revision 1.93 date: 2012/11/30 15:54:44; author: PavelPotcheptsov; state: Exp; lines: +2 -1 none
revision 1.92 date: 2012/11/30 15:54:20; author: PavelPotcheptsov; state: Exp; lines: +4 -3

-- PavelPatcheptsov - 2012-11-30

Edit | Attach | Watch | Print version | History: r21 < r20 < r19 < r18 < r17 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r21 - 2012-11-30 - PavelPatcheptsov
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.