Question

Warning: Deep Twiki hacking.

I found a bug in COMMENT: see CommentPluginDev today (11 Jul 2003). To fix it, I need to pass current contens of COMMENT to template oopslockedcomments.tmpl. Currently parameters are passed via URL, and text of comments could have spaces - and also could be too large for HTTP GET. Is there a way around it?

        my $url = &TWiki::getOopsUrl( $webName, $topic, "oopslockedcomment",
            $lockUser, $editLock, $lockTime );
        TWiki::redirect( $query, $url );

The only way I can see is not use templates at all, but generate another "view" page using say lockedcomment script and allow to resave later. Ugly hack.

BTW savecomment is (with savemulti and save-via-email (link?) ) yet another clone of save script. This is not fork, but close.

• TWiki version:
• Perl version:
• Web server & version:
• Server OS:
• Web browser & version:
• Client OS:

-- PeterMasiar - 11 Jul 2003

Answer

It sounds like it should be using POST not GET if it has large parameters. There is a limit (a small number of K) of how much you can pass via GET anyway and I suspect that limit will vary with what browser is used.

Of course, as you say, we'd like to avoid the proliferation talked about in PluginBinNameClashes. May I suggest that you produce a patch to the SavemultiCgiScript such that it takes a URI parameter to say addcomment and the body of the thing being added is passed through POST? I think there is a generic need for that functionality, quite separate to the MegaTWiki / CommonFrontEndCgiScript

-- MartinCleaver - 11 Jul 2003

I know - but it's TWiki.pm who generates GET instead of POST. My patches are not going to be applied to TWiki.pm - so looks like separate hack to avoid using standard library . What is official vision on this issue? Will savemulti replace save in the future?

Is ColasNahaboo listening? Maybe I will move changes made to save script into SavemultiCgiScript, if ColasNahaboo is opened to such a change. We definitely do not want Yet Another Save Script. Ideas, opinions?

-- PeterMasiar - 12 Jul 2003

In an email Colas told me he is on holiday until Jul 21st

-- MartinCleaver - 12 Jul 2003

According to PeterThoeny, SavemultiCgiScript could replace the current SaveCgiScript when it has been demontrated that it doesn't cause any problems with things like the less obvious functions repRev and delRev. So more people need to test it and report back.

Before he went on holidays Colas said he has a new job position which means he can now dedicate himself full time to twiki work. I expect he will spend some of that time strengthening savemulti.

-- MattWilkie - 14 Jul 2003