Question

Have been running older releases using Apache / Mod_Perl / Win32 without issue and decided to try and install the 01-Sept-2004 release. I've got things working in terms of a Edit / Save cycle but RCS isn't working any more.

If I look at a doc with a ver > 1.1 (eg from WebChanges) it shows up as version 1.1 in the top section of the document. If I edit and save the doc it reverts to V1.1. Other notable thing is that the ,v isn't created when a new doc is created.

I've checked and reset the owner of the ,v file. Permissions are fine, testenv shows everything as okay (eg no red text).

I've tried to switch RCS debugging on but nothing gets written to the debug.txt file.

So, anyone got things working with mod_perl and the latest release. Any ideas on what I might be doing wrong. Any ideas on getting debugging to work?

Environment

-- NathanReeves - 14 Oct 2004

Answer

I don't think this is it, but you have changed the rcs lock user right? Use the "relock" link from the output of testenv

-- MattWilkie - 14 Oct 2004

Just tried with no luck. The top line of the page always shows 1.1 as the version but the bottom section shows the different revisions but when I try to view the diff's between versions I get a page with no diff text in, only a page structure.

Anyone got any hints on getting RCS debugging to work in Windows. Like I said above, I've uncommented the lines in Store.pm but I'm not seeing any output in debug.txt.

Thanks

-- NathanReeves - 14 Oct 2004

Finding messages like this in my apache error log:

'c:/webs/techdocs/data//Main/RCS/PeterThoeny.txt,v',v: Invalid argument
rlog: 

Also should note that RCS works okay when I revert to a previous production release (eg 2003)

-- NathanReeves - 14 Oct 2004

Another update... Finally found the correct _traceExec section to uncomment (in RCSWrap.pm and not store.pm <-- Docs are wrong here) and managed to get some debug lines when RCS runs. Looks like rlog is having some issues. Got output from an older version of Twiki which looks like this:

14 Oct 2004 - 23:47 Rcs: c:/webs/unixsupportfiles/rlog -x,v -r1.13 c:/webs/techdocs/data/Main/WebPreferences.txt,v (): c:/webs/unixsupportfiles/rlog -x,v -r1.13 c:/webs/techdocs/data/Main/WebPreferences.txt,v 

14 Oct 2004 - 23:36 Rcs: c:/webs/UnixSupportFiles/rlog -x,v -r 'c:/webs/techdocs/data/Main/WebPreferences.txt,v' ( Error: 255): c:/webs/UnixSupportFiles/rlog -x,v -r 'c:/webs/techdocs/data/Main/WebPreferences.txt,v' 

Looks like the current revision of the doc isn't being passed to rlog.

Still hunting.

-- NathanReeves - 14 Oct 2004

It is not the version that is the problem, it is the presence of the surrounding ticks that causes the mess.
If you play around a bit from the prompt:

W:\usr\local\Php>\twikiUnixSupportFiles\rlog -x,v -r '\twiki\data\Main\WebHome.txt,v'
rlog: '\twiki\data\Main\RCS/WebHome.txt,v',v: No such file or directory

W:\usr\local\Php>\twikiUnixSupportFiles\rlog -x,v -r '\twiki\data\Main\WebHome.txt'
rlog: '\twiki\data\Main\RCS/WebHome.txt',v: No such file or directory

W:\usr\local\Php>\twikiUnixSupportFiles\rlog -x,v -r \twiki\data\Main\WebHome.txt

RCS file: \twiki\data\Main\WebHome.txt,v
Working file: \twiki\data\Main\WebHome.txt
head: 1.20
...

So what can be done about this ?
(My environment is W2k, UniServer3_2 which I updated to arrive at Apache/2.0.52 (Win32) PHP/5.0.0 mod_perl/1.99_18 Perl/v5.8.6 build 881 (ActiveState))

UPDATE:
As a dirty hack of a dirty TODO in RcsWrap.pm (first 2 lines are already there)

#TODO set from TWiki.cfg
#my $cmdQuote = "'";
my $cmdQuote = "\"";

Now if I could only fix one other remaining error ...

[Thu Dec 23 00:36:50 2004] [error] [client 127.0.0.1] [Thu Dec 23 00:36:49 2004] save: print() on closed filehandle FILE at ../lib/TWiki/Store.pm line 868., referer: xxx

FINAL UPDATE:
Bug already covered in RcsWrapDontUseProperQuote

-- BramPeeters - 22 Dec 2004