SID-00449: ActionTrackerPlugin search tables lack cell separator lines
| Status: |
Answered |
TWiki version: |
4.3.1 |
Perl version: |
5.10.0-73 |
| Category: |
ActionTrackerPlugin |
Server OS: |
Fedora 11 |
Last update: |
16 years ago |
ActionTrackerPlugin search tables generated with %ACTIONSEARCH{}% lack lines to delineate the rows and columns. I've tried to use the
separator attribute with no success. This issue arose after I upgraded from TWiki 4.0.5 to 4.3.1 and
ActionTrackerPlugin from 11698 to 16787. I'm using the installation's default skin.
Thanks.
Mike
--
TWikiGuest - 2009-07-31
Discussion and Answer
See section 2.3 of
my user page.
--
SeanCMorgan - 2009-08-01
Thanks, Sean. I modified my
twiki/pub/TWiki/ActionTrackerPlugin/styles.css to contain the text below. However, it didn't seem to affect anything after a page refresh. Am I missing something? Do I need to take into account the fact that the files in this directory appear to be under
RCS/CVS version control? I just modified
styles.css directly in
vi.
.atpDef, .atpChanges{border-collapse:collapse;border-spacing:0px;border:solid #ccc 1px;}.atpDef th,.atpChanges th{padding:2px 5px;border:solid #ccc 1px;background-color:#6b7f93;color:white;}.atpDef td,.atpChanges td{padding:2px 5px;}.atpWysiwyg{border:solid #ccc 1px;background-color:#F0DC88;}.atpSearch{border-collapse:collapse;border-spacing:0px;border:solid #ccc 1px;}.atpSearch th{background-color:#6b7f93;color:white;padding:2px 5px;}.atpSearch td{padding:2px 5px;border-right: 1px solid #AAA;border-bottom: 1px solid #AAA;vertical-align: top;}.atpClosed,
.atpOpen,
.atpError,
.atpWarn{display:block;margin:-2px -5px;padding:2px 5px 2px 20px;}.atpClosed{background-color:#40AA54;}.atpOpen{}.atpError{background-color:#F8EAF1;}.atpWarn{background-color:yellow;}.atpStateopen{background-color:orange;}.atpStateclosed{background-color:#D0D0D0;}.atpSignopen{}.atpSignclosed{background-color:#D0D0D0;}
Mike
--
TWikiGuest - 2009-08-03
I don't know what's wrong. I'm only updating this topic to change the status from "Unanswered" (which actually shows up as "Closed Unanswered", a bug IMHO), back to "Asked" (which is an open question).
--
SeanCMorgan - 2009-08-03
I found a temporary workaround with tolerable side effects. I found that adding the section below (which is almost identical to the one from
SeanCMorgan Section 2.3) to my
twiki/pub/TWiki/PatternSkin/style.css at least added subtle cell borders. The downside is that this change affects the display of
all TWiki tables (not just ACTIONSEARCH tables) since it applies to the whole skin. For me, this is tolerable to get more readable tables, but I'm positive that someone more knowledgeable about TWiki,
ActionTrackerPlugin, and CSS can find the "right" solution.
Mike
td {
padding:2px 5px;
border-right: 1px solid #DDD; /* CUSTOMIZED */
border-bottom: 1px solid #DDD; /* CUSTOMIZED */
vertical-align: top; /* CUSTOMIZED */
}
--
TWikiGuest - 2009-08-12
One observation to help debug: The HTML of one of my pages containing an ACTIONSEARCH table makes no reference to
twiki/pub/TWiki/ActionTrackerPlugin/styles.css.
Also, FWIW, this file is accessible in my browser directly, so it's not a permissions issue.
--
TWikiGuest - 2009-08-12
>
The HTML of one of my pages containing an ACTIONSEARCH table makes >
no reference to twiki/pub/TWiki/ActionTrackerPlugin/styles.css
That rang a bell: the doc I referred you to earlier is a bit stale. With a recent of update ActionTracker, the generated HTML simply references one standard class,
<table class="twikiFormTable">, instead of using its own classes. Forms that use that class include the attribute
border=1, but it was missed here. Without a border, the color setting doesn't work. Unfortunately this means that any style customization will affect all uses of the forms tables, including both the in-page display of form values, and the screens for editing form values:
- Location of Change:
</TWiki/lib/TWiki/Plugins/ActionTrackerPlugin/Format.pm> -> sub _generateHTMLTable
- Default Value:
my $text = CGI::start_table( {class => 'twikiFormTable' }, $a );
- New value:
my $text = CGI::start_table( {class => 'twikiFormTable', border => '1'}, $a );
--
SeanCMorgan - 2009-08-13
>
my $text = CGI::start_table( {class => 'twikiFormTable', border => '1'}, $a );
This workaround did the trick. Thanks a lot, Sean.
Mike
--
TWikiGuest - 2009-08-14
You're welcome. I'm setting the topic to 'Answered'.
--
SeanCMorgan - 2009-08-15
Now that this support request is in the "answered" state, should this issue become an
ActionTrackerPlugin bug/modification-request in some other list? What's the right procedure for that?
Thanks.
Mike
--
TWikiGuest - 2009-08-17
It is a known bug, so it should be dealt with in due course:
I also posted the work-around in
ActionTrackerPluginDev a couple of months ago (I knew it rang a bell!)
--
SeanCMorgan - 2009-08-17
If you answer a question - or someone answered one of your questions - please remember to edit the page and set the status to answered. The status selector is below the edit box.