Bug: TWiki::makeTopicSummary Truncates <nop> Tags

A string passed to makeTopicSummary that contains a <nop> tag straddling the cutoff point (162 characters in the TWiki 20010803 beta) will be returned with the <nop> tag truncated, resulting in a rendering error when viewed by the Amaya browser.

Test case

Suppose you have a string that looks like this:

    Name: Peter Thoeny, author of the TWIKIWEB.TWikiWeb (and therefore a TWIKIWEB.TWikiContributor) Work: Peter.Thoeny@WindRiver.com Home: Peter@Thoeny.com.

To prevent linking of internal and external links, makeTopicSummary will interpolate <nop> tags after the @ characters so that it looks like this:

    Name: Peter Thoeny, author of the TWIKIWEB.TWikiWeb (and therefore a TWIKIWEB.TWikiContributor) Work: Peter.Thoeny@<nop>WindRiver.com Home: Peter@<nop>Thoeny.com.

If a <nop> tag happens to straddle the 162 character cutoff, the function will return this:

    Name: Peter Thoeny, author of the TWIKIWEB.TWikiWeb (and therefore a TWIKIWEB.TWikiContributor) Work: Peter.Thoeny@<nop>WindRiver.com Home: Peter@<nop ...

Note how the <nop> has been truncated into a tag fragment. Netscape, Mozilla, and IE will ignore this, but Amaya complains.

(This example came out of the Main Index page in the release.)

As a workaround, I patched my TWiki.pm as follows:

   # limit to 162 chars
   $htext =~ s/(.{162})([a-zA-Z0-9]*)(.*?)$/$1$2/go;
   $htext =~ s[\</*(n|no|nop|nop)?/*$][]go;
   $htext .= ' ...'; 

This seems to work ok, but I'm sure there's a single regex that could do it.

Fix record

Simple solution was to move the truncation of string above the <nop> tag processing. In TWikiAlphaRelease.

Environment

-- MikeOwens - 23 Aug 2001