Feedback on ChecklistTablePlugin

-- DanielRohde - 28 Aug 2007

Ok, some features of the ChecklistTablePlugin are well known from the EditTablePlugin but a checklist table has some requirements which are not satisfied by EditTablePlugin. I've first tried to wrap EditTablePlugin but I failed. Some annoying problems of EditTablePlugin are not present in ChecklistTablePlugin, e.g. you can use TWikiVariables within format attribute or table cells without any <nop> tags...

I have planned to add some features:

• JavaScript based insert/edit
• integrated table sort that allows you to edit a sorted table
• own icons (to much colors yet)
• ... feature requests are welcome

-- DanielRohde - 28 Aug 2007

@all: you should use the latest version from SVN because the initial release has a major bug (if you use pre/verbatim tags a table change will throw away all pre/verbatim content/tags) ...

-- DanielRohde - 28 Aug 2007

Thank you Daniel for contributing yet another plugin!

Small feedback on plugin topic:

• When referring to dependent plugins it is better to write just the plugin name, not %TWIKIWEB%.CheckListPlugin. That way links work on twiki.org and when installed on a target system. I updated the plugin topic accordingly.
• Thanks for running and documenting the benchmarks!
• Please help tagging the plugin topic.

-- PeterThoeny - 28 Aug 2007

Guess this will work with EditRowPlugin too, right?

-- FranzJosefGigler - 29 Aug 2007

No, ChecklistTablePlugin works like EditRowPlugin. The table row editor is integrated in ChecklistTablePlugin.

-- DanielRohde - 29 Aug 2007

Hi Daniel.. I'm drooling & can't wait to install and test. I'll be back shortly with updates. Thanks!

-- KeithHelfrich - 30 Aug 2007

Works as described. I'm curious: wouldn't it make sense providing an EditTableContrib from which all the different table editors could benefit?

-- FranzJosefGigler - 30 Aug 2007

Sorry, guys. I haven't installed & played with the ChecklistTablePlugin yet. But I would agree with the sensibility of a single, common EditTableContrib.

Also Daniel, I'm wondering why this wasn't included in the original ChecklistPlugin ? Why add yet another plugin ?

-- KeithHelfrich - 30 Aug 2007

Small typo: In installation Instructions, change "TWiki:Main.ChecklistPlugin" to "TWiki:Plugins.ChecklistPlugin".

-- PeterThoeny - 31 Aug 2007

Hi Keith, the ChecklistTablePlugin implements a complete table (row) editor with about 750 lines of code and a new data type. This is the reason why I've added a new plugin.

Sure, a EditTableContrib could help to reduce code and bugs. Do anyone have enough time to implement a EditTableContrib?

-- DanielRohde - 03 Sep 2007

Hi Daniel. It appears we have hit a problem with ChecklistTablePlugin and its use of JSCalenderContrib. It is quite a serious problem as we have a vacation request/grant/denu system within our company and when this plugin is enabled, it essentially breaks all but the simplest use of JSCalendarContrib. The problem is one of infinite recursion where the JSCalendarContrib overwrites one of the std JS class functions, preserving a backup ptr to the fn which it calls from the new fn when necessary. However, when JSCalenderCOntrib is activated with %INCLUDE{"%SYSTEMWEB%.JSCalendarContribInline"}%, the backup ptr to the fn is overwritten with itself, resulting in infinite recursion.

When CheckListTablePlugin is enabled, it pulls in some but not all of the JSCalendarContrib, enough so that the above include is not required for the simplest of uses for JSCalnedarContrib. When the include is omitted, the JS does not break. But we need the include to pull in the whole lot.

The problem is simple enough to reproduce. Just duplicate the example contained in JSCalendarContrib, including the %INCLUDE% and enable your plugin. You will not be able to select a date with the %INCLUDE% in place and plugin enabled.

-- AlexSchuilenburg - 2011-03-14

Hi Alex. I have no idea to fix the problem (yet). The simplest solution: if you enable ChecklistTablePlugin you do not need to include JSCalendarContribInline.

-- DanielRohde - 2011-03-16

Daniel: We replaced the JSCalendarContrib with a new DatePickerPlugin, proposal at ReplaceJSCalendarContribWithDatePickerPlugin. With this, extensions that use the JSCalendarContrib need to be updated. This is mostly done already.

You maintain the ChecklistTablePlugin - the modification policy is set to "contact author first". Could you please update the plugin to use the DatePickerPlugin instead of the JSCalendarContrib? The how-to is documented at JSCalendarContrib. I can do the change for you if you wish, let me know. I also sent you an e-mail on 2012-12-16 in regards to this change request.

-- PeterThoeny - 2012-12-28