Tags:
create new tag
, view all tags

HistoryPluginDev Discussion: Page for developer collaboration, enhancement requests, patches and improved versions on HistoryPlugin contributed by the TWikiCommunity.
• Please let us know what you think of this extension.
• For support, check the existing questions, or ask a new support question in the Support web!
• Please report bugs below

Feedback on HistoryPlugin

-- JChristophFuchs - 17 Feb 2005

Christoph, thank you for contributing this Plugin! The Wikimedia like diff feature has been suggested in the past.

-- PeterThoeny - 20 Feb 2005

I'm trying to make a "WikiPedia killer" TWiki system with this plugin along with CompareRevisionsAddOn. Can interested parties please see more details at MediaWikiHistoryAndComparisonInTWiki and comment there?

-- MattEngland - 09 Apr 2005

Thanks for this. This is one of the features of MediaWiki that I really like. Makes it so much easier to track changes. It was nice and easy to replace diff with the plugin syntax in the view..tmpl and it seems at this stage to work well. Now all we need is the little function of MediaWiki that lets you, at the edit stage, add a quick summary of what you have changed (which then shows up as part of the webchanges summary page). Scope creep! Sorry. the plugin is great as it is. Thanks for making it available to the TWiki community.

-- SueLocke - 10 Apr 2005

checked .zip into CVS

-- WillNorris - 27 Jun 2005

Thanks for the plugin. It's very useful. I am all for replicating the best MediaWiki features. One thing that is missing in this plugin is a link to raw text of older versions of the topic. Users have difficulty figuring out how to revert to the previous versions of topics. I made the following change in the TWikis I use,

  • twiki/templates/oopshistory.tmpl page modified, added Raw Text link
<tr><th>Rev</th><th>Date</th><th>User</th><th>Raw Text</th></tr>
...
der-width:0px;\">[[$wikiusername][$wikiname]]</td>
<td>&nbsp;<a href=\"%SCRIPTURLPATH%/view%SCRIPTSUFFIX%/%WEB%/%TOPIC%?rev=1.$rev&raw=on\"><b>[Raw text v. 1.$rev]</b></a></td>
</tr>" rev1="%URLPARAM{"rev1"}%" rev2="%URLPARAM{"rev2"}%" nrev="...
Folks who use my TWikis find that this feature is quite useful. In accordance with CVSModificationPolicy: ContactAuthorFirst, I would like to get your permission to modify the above template in CVS.

-- AlexKane - 12 Nov 2005

Please ReadmeFirst, we switched from CVS to SVN.

-- PeterThoeny - 12 Nov 2005

Alex,
thanks for your proposal. However, I would like to ask you not to change HistoryPlugin in the moment, mainly for the following reasons:

  • HistoryPlugin can work together with RevCommentPlugin and CompareRevisionsAddOn, so the templates should be changed in these other two plugins as well
  • I am currently upgrading these three plugins for the Dakar release, and I will incorporate your proposal in some way (However, due to lack of time, this will probably not be finished before Christmas)
  • Depending on the type of users you are adressing with TWiki, a link to the raw text might be either helpful (as in your case) or confusing (as in my case. I made the experience, that most of our users do accept TWiki only if it is kept very simple and every more technical details are hidden. The few more experienced users know how to find them anyway), so am note sure if one should have these links as default.
    However, the templates are the perfect way to adapt the behaviour of the plugins to your special needs without changing the code. So I suggest to incorporate your changes in a way that they are disabled by default, but may easily be activated by an administrator.

-- JChristophFuchs - 21 Nov 2005

This is a great plugin and I am happy to use it. As of now, none of the radio buttons are selected by default. Is there a way to make the radio buttons for the last two revisions checked (selected) by default ? Say if the current revision of an article is 1.8, the plugin should select 1.8 and 1.7 by default. In fact, if I click 'Compare revisions', it compares the last two revisions but the radio buttons do not show it.

-- ChengappaCB - 24 Nov 2005

I agree with ChengappaCB that some kind of radio mechanism to support easier selects of versions would be very helpful. The way that wikipedia does this (dynamically removes/updates the list of selectable buttons) might be worth looking into? Demo: Antarctica topic history example at Wikipedia.

-- SteffenPoulsen - 09 Apr 2006

I am sorry to announce that I am no longer able to do any work on this plugin. For more information please read JChristophFuchsStopsWorkOnTWikiPlugins.

-- JChristophFuchs - 13 Apr 2006

Thanks for your effort, JC, appreciated.

Uploaded a new release from SVN, compatible with TWiki:Codev.TWikiRelease04x00x02. Latest PatternSkin (in SVN) supports this plugin directly, but is not released yet. Until next release of PatternSkin the updated template viewtopicactionbuttons.pattern.tmpl can be retrieved from this link: viewtopicactionbuttons.pattern.tmpl in SVN.

-- SteffenPoulsen - 13 Apr 2006

Hm, what's wrong with my TWiki installation if I get

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.

Argument "      " isn't numeric in division (/)
whenever I try to view my local HistoryPlugin topic on a fresh TWiki 4.0.3 with WarningsAreErrors" activated but the plugin works perfectly? I can view the topic if I deactivate WarningsAreErrors" in configure.

-- FranzJosefSilli - 02 Jul 2006

Line 191 looks like a Cairo compatibility thing, for TWiki4 you could just delete it.

-- SteffenPoulsen - 02 Jul 2006

Works, thanks.

-- FranzJosefSilli - 02 Jul 2006

Please consider adding the use strict; pragma to this plugin. Its use is important to ensuring the quality of TWiki plugins and avoiding unpleasant surprises. See UseStrict for more.

-- MeredithLesly - 02 Jul 2006

Please consider adding a button/option to have possibility to compare "raw" revisions also. This is extremely useful for pages containing "sorted" tables. And in all other cases where overview of page source code gives better information about changes/differences.

-- DaliborSvoboda - 22 Sep 2006

Using 4.0.5, I have used the following to display the history of the current topic:

%HISTORY{reverse="on" format="| $rev | $date | $wikiusername |"}%

Unfortunately, the first line of the resulting table is not formatted correctly. It just has the 'pipe' characters instead of the table formatting.

Anybody have any ideas why this is happening?

-- DuncanKinnear - 12 Dec 2006

Follow-up: I have managed to 'fix' the problem by commenting out the calls to subroutine handleHeadFoot in the main handleHistory routine. At the moment I'm not using headers or footers.

I'm going to try and add debug messages to help me figure out what's going wrong in that subroutine.

-- DuncanKinnear - 13 Dec 2006

FIX: I have figured out a fairly simple fix for the behaviour I reported above.

I changed line 138 of HistoryPlugin.pm from:

$header = "\$next{'...'}%BR%" unless defined($header);

to:

$header = "\$next{'...'}%BR%\n" unless defined($header);

I noticed that a newline was being appended to the $revinfo further down the script, so the newline was a logical addition to the end of the header.

Obviously, though, there is another approach that can be used. After the call to subroutine handleHeadFoot for the header, the following line could be added to make sure that whatever was in the header did not cause this problem:

$out .= "\n";

But that could hinder a user's attempt to have the header 'merge' in with the first line of the history list (not sure why anyone would want to do that, but hey).

Anyway, perhaps the appropriate person could make this change to the Plugin, or give me some intructions on how to change the actual release.

Cheers,

-- DuncanKinnear - 13 Dec 2006

Our internal TWiki needed a history display, so I took the opportunity, to re-work the code to use registerTagHandler(), instead of the Cairo commonTagsHandler(). If people are interested I can post the new module.

-- CraigMeyer - 22 Mar 2007

This plugin has a PleaseFeelFreeToModify policy; more than 12 month passed after the TWiki 4 release. Therefore I think you could simply upload your new version (and fix the package form to state the proper version supported.)

-- PeterThoeny - 24 Mar 2007

one small issue that you might like to fix in the plugin:

RdiffRenderStyleInterweaveNotWorking

I don't recal rdiff ever having an 'interweave' render setting - if its the same as 'sequential'...

on the other hand, if you'd like to help us make rdiff better, we'd be thrilled to have your help smile

-- SvenDowideit - 29 Apr 2007

Just a note on the new option CopyPreviousRevisionTopicContentIntoNewRevision in 4.2. Hopefully someone with coding skills will be able to integrate this option with the HistoryPlugin!

-- JosMaccabiani - 20 May 2007

It's possible to add MAKETEXT on earlier and last word ? I want to translate them in french and it's not possible ;-( thank

-- YannickPavard - 22 May 2007

The example screenshot looks jaggy since it is scaled by the browser; better to scale down with proper dithering, or to take a screenshot using a small font.

-- PeterThoeny - 20 Nov 2007

I have uploaded a rev 1.3 of the plugin. It now integrates well with both RevCommentPlugin and CompareRevisionsAddOn again. This was lost in the 1.1/1.2 version.

I have tested this new version both in TWiki 4.1.2 and TWiki 4.2.0 SVN code.

I had to reimplement the styles from what was done in the 1.1 version of the plugin because the 1.1/1.2 version used a feature in the templates that TWiki 4.1 does not have so the HistoryPlugin did not work well.

I tested the new styles in both IE6 and 7 (1.1 did not look good in IE by the way) and FF.

I changed the layout back to a simpler version but took some of the good stuff like the coloured select columns and made a combination that I think looks very nice and is not too far from what users know from running in TWiki 4.1.X.

-- KennethLavrsen - 10 Dec 2007

Excellent, thanks Kenneth!

-- PeterThoeny - 10 Dec 2007

Edit | Attach | Watch | Print version | History: r31 < r30 < r29 < r28 < r27 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r31 - 2007-12-10 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.