Feedback on EditChapterPlugin

-- MichaelDaum - 03 Jan 2008

It seems that EditChapterPlugin conflicts with SlideShowPlugin. Enabling EditChapterPlugin via the configure script makes the slide shows no longer work. See example slide show. Setting PluginsOrder? via configure to SlideShowPlugin first worked-around this issue.

-- DemetriMouratis - 15 Apr 2008

Thanks Michael for contributing this new plugin! If I may, some small feedback:

• Avoid linking to oneself (See Jakob Nielsen's Alertbox)
• Think about measuring and documenting the PluginBenchmarks
• I added the PluginPackage form, please fill in the details
• It would be nice to have a visual clue (besides hovering) that sections can be edited. Possibly with a non-intrusive small icon, on hover changing to ? Possibly configurable?

Going forward, let's work hard to keep the plugin and template interface more stable over time, so that developers do not need to duplicate and fix code, and so that users are less confused on which plugin to install.

-- PeterThoeny - 04 Jan 2008

A couple things I noticed

• if you have a page with some uncreated pages (WikiName? waiting to be used) and edit a different section on the page, those words will now have (LabStuff?) will be populated.
• Second if you have WikiWord in a section, the section edit seems to clear out the ! and so if you do not notice and repopulate it will be back to a WikiWord

Still a good plugin

-- ScottHinchley - 12 Jan 2008

Scott, I am not sure if I can create a test case from your descriptions to reproduce your findings. Can you make one up please? Thanks.

-- MichaelDaum - 12 Jan 2008

Yes I should be able to. Do you want them in the Bug Database? And will create two bug reports.

-- ScottHinchley - 15 Jan 2008

That's a good idea.

-- MichaelDaum - 15 Jan 2008

Done. Let me know if you need more details. Bug Item5250 for the ! bug. Bug Item5251 for the ? bug.

-- ScottHinchley - 15 Jan 2008

Just upgraded our Twiki to 4.2.0 and installed this plugin to replace an old chapter-editing plugin. I found two problems:

(1) We often use chapter headings of the form ---++[[company]] - while the resulting link still highlights, clicking on it is caught by the editChapter functionality - in other words the default formatting of the chapter edit code breaks any links that may be in the section heading. I did fix that by changing the format of the link code, but just linking the icon seems to make more sense to me.

(2)There seem to be some interaction with forms - with this plugin enabled, the little 'add form' button disappears from pages opened for editing. Existing forms still show and can be changed.

-- ThorstenSchnier - 30 Jan 2008

"add form" is disabled when in chapter edit mode. It should be visible in normal editing however.

-- MichaelDaum - 04 Feb 2008

Thanks for this plugin for 4.2 but is there a reason why it is not implemented so that it is possible to save an isolated subsection back into the topic, rather than saving the complete topic, despite the fact that only part of it is editable? This allows the scenario where Mr.X opens a section for editing and whilst he is doing this Mrs.Y opens, edits and closes another section but this all gets lost when Mr.X saves his edits (along with the old section that's just been edited by Mrs.Y) over Mrs.Y's version... oder?

-- DavidPatterson - 05 Feb 2008

I've noticed that the TINYMCE editor appears below the raw text editor field when you follow a chapter edit link. I'm surprised that no one has noticed this, so I wonder if there is something unique in my setup? Added Bug Item5355

-- BryanEllsaesser - 12 Feb 2008

Bryan, at least I'm not the only one who got caught by this. It's actually described in the plugin topic: EditChapterPlugin#Limitations

-- MartinKaufmann - 12 Feb 2008

I've just installed this (on TWiki 4.1.2) using the installer script &, well it just did't do anything. I've used debugenableplugins to see if there was a clash, but it still doesn't work. It's showing as enabled in Installed Plugins. I check the generated html & the calls are there, but the icon doesn't appear. If I remove the ecpedit class, then it appears & the plugin works. I've tried this with Firefox & IE. Is there something wrong with the CSS?

-- ChrisHogan - 14 Feb 2008

Did you install the JQueryPlugin? The edit icon will only show up if you hover with you mouse pointer over the headings. This event will switch on the ecpEdit class.

-- MichaelDaum - 14 Feb 2008

The installer did it for me, but now I check the user I was logged in as didn't have permission to update the pub directories properly! I've copied them in place manually & it's all working.

Thanks for the quick response Michael

-- ChrisHogan - 14 Feb 2008

I've installed the plugin, however it's not working correctly. The edit buttons appear but when I click on one edit button the whole text of the page is opened in the editor.

Is there a way for me to debug the plugin to find out where the error is? We are running TWiki 4.1.2. Thanks!

-- AlexRaabe - 27 Mar 2008

I need to use this plugin with QuickMenuSkin, but it is not working. When I try to edit a sub-section, it open no only the content of the sub-section, but all the whole content of the page. I am testing it in TWiki 4.2. Thanks!

-- MarceloAInuzuka - 14 Apr 2008

I tested the plugin now also with TWiki 4.2.0 which still didn’t work.
Is it possible that it has something to do with the version of pattern skin that we use (which has been altered in many ways from the original version)?

-- AlexRaabe - 15 Apr 2008

Alex, which authentication method are you using?

-- MichaelDaum - 29 Apr 2008

This plugin seems to hide the "Add Forms" button in Twiki 4.2. See also NoAddFormButton The Plugin was disabled in Main.TWikiPreferences by * Set EDITCHAPTERPLUGIN_ENABLED = off

-- JensHofmann - 30 Apr 2008

Hey Micha,

got the same problem as Alex and Marcelo. The "whole text of the page is opened in the editor"

TWiki 4.0.4. with latest NatSkin and JQuery installed

-- CarloSchulz - 05 May 2008

I have a different problem (big problem). It only opens the chapter you want but on saving, the entire document disappears. Anybody have the same problem? Obviously we turned it off quickly. We're using TWiki 4.2.0

-- JoeMarandola - 13 May 2008

Found out it was related to Bug Item5355. Wrote Bug Item5635.

-- JoeMarandola - 15 May 2008

I have a completly different problem: installation okay As soon as I update a section, the whole text gets deleted. No errors... Any suggestions?

-- EddieCoissy - 20 May 2008

i had the following problem: if a web sets ALLOWWEBVIEW this plugin is no longer functional (empty textbox when editing). i located the problem in EditChapterPlugin/Core.pm : if ALLOWWEBVIEW is defined,

TWiki::Func::checkAccessPermission('view', $this->{wikiName}, $text, $thisTopic, $thisWeb, $meta);

will always return 0 (no idea why ...)

i simply changed 'view' to 'edit':

TWiki::Func::checkAccessPermission('edit', $this->{wikiName}, $text, $thisTopic, $thisWeb, $meta);

and everything worked just fine again ...

-- WolfgangAstleitner - 30 May 2008

I've been forced to disable this plugin. Even before my upgrade to 4.2 I could not get the Add Form button to appear if iit was active. I would like to use it, even with the overide of links in the header (I use Firefox, so as long as I remember to middle-click not click on a header I can edit in either way that I wish to, but...

If Add Form is not available, I'm afraid it's a no go.

-- ChrisHogan - 09 Jun 2008