Feedback on EditInTablePlugin

Could you give us an overview of the differences with EditTablePlugin? -- ArthurClemens - 14 Feb 2004

And a demo would be nice

-- MartinCleaver - 15 Feb 2004

I've installed it and going into edittable mode works. I can see how this could be very useful. However when ever I try and 'Save Table' I get thrown to the front page of the web, with no error message, and the changes aren't saved.

Also I can see where some might want to control which tables are editable. Edit this table rather than all tables.

-- MattWilkie - 19 Feb 2004

Well the idea is to edit tables in place without the requirement of adding a tag to the page to indicate the table is editable.

The tables would only be editable after clicking a Edit Tables button much like switching to edit mode.

It wouldn't take much to indicate which tables should be read only? Although seems a bit strange considering you don't mark tables as read only in the wiki text format.

I was thinking of the meta-data tables (attachments, twiki-forms, etc.). It may be enough to have EditInTablePlugin only apply to %TEXT% (or be able to apply to %TEXT% and metadata separately). I'd wait until somebody actually asks for this feature before spending lots of time on it though. :)

As for the "Save Table" going to the front page of the web, this could be from a form tag that wasn't closed (such as a search form or a web form), if possible it would be great to have a link or the html output and wiki text for this bug.

Currently the plugin doesn't handle column span, perhaps when I get time or if one of my users complains that they absolutely need it 8).

-- RudiBierach - 22 Feb 2004, -- MattWilkie - 23 Feb 2004

I'm thinking of two major enhancements.

• Change text field sizes to match the longest item per col
• Realign the table bars so the twiki text has all the cells aligned

-- RudiBierach - 27 Feb 2004

I love this idea, Can't wait to try it. I'm asking a lot here, but what about having form-like drop-downs inside an editable table? I have some BIG tables, and making sure a PIPE is there is none-too user friendly in the text edit box. Maybe I should look at some database interface.

-- BobHartmann - 05 Mar 2004

Thanks for the compliment 8). I know the EditTablePlugin allows drop down, but you have to define the list of possible choices in advance. Perhaps some heuristics could be applied to work out if a column is a good candidate for a drop down list, or perhaps a different mode or a tag (yuck) to implicate which columns are to be drop downs.

-- RudiBierach - 06 Mar 2004

The EditInTablePlugin does not require a login.
This breaches the security mechanisms.
Can this be changed?

Linux Kernel 2.4.22, apache 2.0.47, Perl 5.8.1, client OS Win2000, client browser IE.

-- DetlefMarxsen - 11 May 2004

First of all, we would like to point out that we really love using the Edit table plugin in our team. The edit table allows us to communicate across different sites with ease. However, there is one problem that we run into rather frequently. If someone edits the table (by clicking on the edit button at the bottom) and tries to save their changes, the plugin doesnot save the changes as desired. In fact, it simply returns to the default value for all the drop down menus.

Keep in mind that we actually use the plugin in tables with just over 100 rows (I am aware of the slow behavior with rows > 50).

Has anyone run into this issue before? If so, can anyone help me get around this issue?

-- NimishBhatia - 13 Oct 2004

.zip checked into CVSplugins:EditInTablePlugin

-- WillNorris - 23 Nov 2004

EditInTablePlugin uses latin1 encoding to render cell contents. If the site locale is different, the text becomes unreadable.

The following patch fixed the problem for us (TWiki 02 Sep 2004, perl5.8.5):

--- EditInTablePlugin.pm.orig   Sun Feb 15 04:34:24 2004
+++ EditInTablePlugin.pm   Wed Feb 16 14:39:31 2005
@@ -19,6 +19,8 @@
 #
 package TWiki::Plugins::EditInTablePlugin;    # change the package name and $pluginName!!!
 
+use Encode;
+
 # =========================
 use vars qw(
         $web $topic $user $installWeb $VERSION $pluginName
@@ -174,7 +176,7 @@
 
    my $a;
 
-   foreach $a (split(//, $in)) 
+   foreach $a (split(//, decode($TWiki::siteCharset, $in))) 
    {
       my $code = ord($a);
       $ret .= "&#$code;";

-- AlexanderSmishlajev - 16 Feb 2005

Hi, I have tried this with UTF-8 Big5 text. The EditInTablePlugin cannot interpret the Big5 text correctly. Please help.

-- BenChoi - 12 Nov 2005

There is a little bug when moving rows. If you have a cell containing the row number, it is not updated after saving the table. You have to edit/save it again to correct the row numbers.

-- TWikiGuest - 13 Aug 2008

I changed the ModificationPolicy of this extension from ContactAuthorFirst to PleaseFeelFreeToModify due to inactivity. Anyone please feel free to work on this extension.

-- PeterThoeny - 2012-12-03