Question
I am having an issue with the
ActionTrackerPlugin's edit link - it opens fine in a new window or in the same window depending on my preference, but I get a mostly empty page only showing the top left logo and the bottom menu bar + copyright info. Everything else about the plugin seems to work.
The URL the edit link sends me to ends like this:
...ActionTest?skin=action%2cpattern;atp_action=000001;nowysiwyg=1;t=1213722376
I was puzzled about the
action%2cpattern;
part, but have seen it listed elsewhere in related topics, and
%2c
turns into a comma. So it appears to be a valid URL, that on my install just doesn't work right.
If I take off the ",pattern" just leaving it at "skin=action;" then I get a working action edit page (although it has no formatting whatsoever - I'm not sure that's right?).
If I take out the "action" part, I end up in standard edit mode for the whole page - which makes sense, since the pattern skin doesn't know anything about how to use the extra parameters and such. I read about some users getting that sort of issue in the past, but that seems old.
If I try to combine them (I wasn't sure if somehow the action skin was supposed to inherit some formatting from the pattern skin) with a different character (+, |, etc), I get a totally wonky page. That was more or less just for fun, since the URL with the comma does seem to be valid (as it is listed elsewhere).
I've read around on the support web and in the action tracker related topics, but haven't found a lot of details on how the action skin works, or if I can take off the ",pattern" and just live with the undecorated skin (I could always play with the css settings and all that, see if it makes a difference).
Right after the initial install I additionally encountered a system error in the edit window, rather than a mostly empty window. I had already made sure the dependencies were met before the initial install. I'm not sure why that error went away after a few tries. Here's the log in case it may help yield some information:
| 17 Jun 2008 - 10:47 | Can't call method "formatForEdit" on an undefined value at /var/www/html/twiki/lib/TWiki/Plugins/ActionTrackerPlugin.pm line 234.
at /var/www/html/twiki/lib/TWiki/Plugins/ActionTrackerPlugin.pm line 234
TWiki::Plugins::ActionTrackerPlugin::_beforeActionEdit('---+!! Action Tracker Plugin\x{a}<!--\x{a}\x{a} PLEASE DO NOT EDIT THIS...', 'ActionTrackerPlugin', 'TWiki', 'TWiki::Meta=HASH(0x9d102c8)') called at /var/www/html/twiki/lib/TWiki/Plugins/ActionTrackerPlugin.pm line 129
TWiki::Plugins::ActionTrackerPlugin::beforeEditHandler('---+!! Action Tracker Plugin\x{a}<!--\x{a}\x{a} PLEASE DO NOT EDIT THIS...', 'ActionTrackerPlugin', 'TWiki', 'TWiki::Meta=HASH(0x9d102c8)') called at /var/www/html/twiki/lib/TWiki/Plugin.pm line 245
TWiki::Plugin::invoke('TWiki::Plugin=HASH(0x9a4fc8c)', 'beforeEditHandler', '---+!! Action Tracker Plugin\x{a}<!--\x{a}\x{a} PLEASE DO NOT EDIT THIS...', 'ActionTrackerPlugin', 'TWiki', 'TWiki::Meta=HASH(0x9d102c8)') called at /var/www/html/twiki/lib/TWiki/Plugins.pm line 333
TWiki::Plugins::_dispatch('TWiki::Plugins=HASH(0x9874f20)', 'beforeEditHandler', '---+!! Action Tracker Plugin\x{a}<!--\x{a}\x{a} PLEASE DO NOT EDIT THIS...', 'ActionTrackerPlugin', 'TWiki', 'TWiki::Meta=HASH(0x9d102c8)') called at /var/www/html/twiki/lib/TWiki/Plugins.pm line 621
TWiki::Plugins::beforeEditHandler('TWiki::Plugins=HASH(0x9874f20)', '---+!! Action Tracker Plugin\x{a}<!--\x{a}\x{a} PLEASE DO NOT EDIT THIS...', 'ActionTrackerPlugin', 'TWiki', 'TWiki::Meta=HASH(0x9d102c8)') called at /var/www/html/twiki/lib/TWiki/UI/Edit.pm line 307
TWiki::UI::Edit::init_edit('TWiki=HASH(0x9126770)', 'edit') called at /var/www/html/twiki/lib/TWiki/UI/Edit.pm line 72
TWiki::UI::Edit::edit('TWiki=HASH(0x9126770)') called at /var/www/html/twiki/lib/TWiki/UI.pm line 159
TWiki::UI::__ANON__() called at /var/www/html/twiki/lib/CPAN/lib//Error.pm line 379
eval {...} called at /var/www/html/twiki/lib/CPAN/lib//Error.pm line 371
Error::subs::try('CODE(0x910fde8)', 'HASH(0x9d0f448)') called at /var/www/html/twiki/lib/TWiki/UI.pm line 199
TWiki::UI::run('CODE(0x92c49d4)', 'edit', 1) called
I can add a screenshot, more plugin info, etc, if needed. Here's for hoping it is something straight forward related to skins.
Environment
--
RasmusPraestholm - 17 Jun 2008
Answer
If you answer a question - or someone answered one of your questions - please remember to edit the page and set the status to answered. The status selector is below the edit box.
>
Right after the initial install I additionally encountered a system error
Can you check if the plugin is installed correctly? Go to your TWiki/InstalledPlugins topic, and scroll down to the "Plugin Diagnostics" section.
--
SeanCMorgan - 17 Jun 2008
Looks okay on the status page:
ActionTrackerPlugin none
Various handlers also list the ActionTrackerPlugin added. I can add actions, search, etc just fine, it only seems to be the edit functionality using the action skin that is causing issues. And even that works if I manually change the URL to use that skin alone.
--
RasmusPraestholm - 17 Jun 2008
The form of your generated URL is correct.
There might be a problem with the current plugin version 16778 (07 May 2008), because the edit template looks just as you described, a logo and a copyright and nothing else:
%TMPL:INCLUDE{"twiki"}%
%TMPL:DEF{"copyright"}%%TMPL:END%
%TMPL:DEF{"main"}%
%UNENCODED_TEXT%
%TMPL:END%
I have a slightly older version, 14969 (20 Sep 2007), with a much busier edit.action.tmpl:
<head>
<title> %WIKITOOLNAME%.%WEB%.%TOPIC%</title>
<meta http-equiv="Content-Type" content="text/html; charset=%CHARSET%" />
<meta name="robots" content="noindex" />
%HTTP_EQUIV_ON_EDIT%
<meta http-equiv="Expires" content="0" />
<meta http-equiv="Pragma" content="no-cache" />
<meta http-equiv="Cache-Control" content="no-cache" />
<style type="text/css" media="all">
@import url('%PUBURL%/%SYSTEMWEB%/TWikiTemplates/base.css');
@import url('%PUBURL%/%SYSTEMWEB%/TWikiTemplates/default.css');
</style>
</script>
</head>
<body>
%UNENCODED_TEXT%
</body>
</html>
You might report a bug at
TWikibug:ActionTrackerPlugin, or try the earlier version. To see earlier version downloads off the plugin's home page, go to Attach, then select "manage".
--
SeanCMorgan - 18 Jun 2008
Thanks! That looks pretty distinct. I'll follow-up on it and report my findings back here soon.
--
RasmusPraestholm - 18 Jun 2008
I too had the same issue after upgrading it from an olderversion. So I had to rollback to the older one. It looks like a bug in the new built. Waiting for a newer version.
--
PrajishS - 19 Jun 2008
Thanks for the confimation Prajish. I have logged this for you both as
TWikibug:Item5720.
--
SeanCMorgan - 22 Jun 2008
I've been tinkering with a workaround (just applying a single file from an old zip), and have one TWiki v4.2 working with a manual fix. I'm going to apply the fix to a second TWiki v4.2 to make sure of the exact steps, then post them here. Hoping to get a chance over the next couple days.
--
RasmusPraestholm - 23 Jun 2008
What is the workaround?
--
TWikiGuest - 20 Jul 2008
AFAICT there's no problem in the latest build of the action tracker on TWiki.org. I just installed it in 4.2.0 and the edit is working fine. More details required.
--
CrawfordCurrie - 03 Aug 2008
I can also confirm this problem. Crawford, what detail would be helpful for you to diagnose the problem? I am running TWiki 4.2.2 and
ActionTrackerPlugin version May 7, 2008.
--
DeanSpicer - 09 Sep 2008
Perhaps this bug is related to
Bug5938 ?
--
DeanSpicer - 09 Sep 2008
I've just installed this plugin as well and had similar problems. Before creating any other
ACTIONs
I clicked on the edit link in the ActionTrackerPlugin topic and only got the above error in the launched window. The error message is refering to the $action parameter in the
_beforeActionEdit
procedure in ActionTrackerPlugin.pm. $action should have been defined following the call to
splitOnAction
at line 191 (the procedure is in ActionTrackerPlugin/ActionSet.pm). In
splitOnAction
, however, $found is never defined so an undef is returned to $action. I determined that the
$action->{uid} eq $uid
check at line 328 was always failing so I took it out, went back to the plugin topic, clicked on the edit and got the first
ACTION
in the page (the one about GordonBrown) to load in the edit window. I edited it and saved changes. Then I reinstated the check back in line 328, restored the topic back to its original version (using the TWiki restore function) and, hey presto, it all works. Perhaps it's because the first edit created the UIDregister file in the working area and that's all that was needed. <shrug>?</shrug>
--
DavidPatterson - 10 Sep 2008
I get this issue too, and implemented
DeanSpicer work around. Change line 328 in
ActionSet.pm:
From:
} elsif (ref($action) && $action->{uid} eq $uid) {
To:
} elsif (ref($action) {
While I am here, where can you down old plugin versions when issues like this come up?
--
AlastairMunro - 15 Sep 2008
I realiase what I did wrong: when installing/upgrading the plugin, use the install script!! Second issue is the edit.action.tmpl is indeed different, so just restore one from an older version. Todo: put the correct edit.action.tmpl in the next release so the edit template is the same as in earlier versions.
--
AlastairMunro - 15 Sep 2008
Closing after more than 30 days. Please reopen with more details if needed...
--
PeterThoeny - 06 Nov 2008
After manually installing the current plugin. Edit didn't work (same issue as described abov). Downgrade of the edit.action.tmpl to a previous version corrected the problem.
--
TWikiGuest - 2009-04-16
Thanks for sharing!
Please do not register with a bogus name, the TWiki community prefers to use real first names and last names. Thanks for your understanding.
--
PeterThoeny - 2009-04-16