- Discussion of significant enhancements moved to EditTablePluginEnhancement (it was confusing when bug reports against the enhanced version were mixed with reports against the standard version)
Wishlist
Please leave this at the top
- It would also be nice if we could get a column on the left with a checkbox, that could be used for deleting all rows checked. -- JohnCavanaugh - 31 Jan 2003
- Along these lines, I'd like 4 additional columns -- BradVance - Oct 5 2004
- Delete Row checkBox
- Row Number to indicate current row number
- Move Row To pull-down menu, where the menu options are numbers, one for each row in this table, so that you could move it anywhere in the table
- Insert Before button to add a row before the current row
- See EditTablePluginEnhancement, EditTableMergePlugin, for a test implementation of all this stuff. -- GaryOberbrunner - 15 Feb 2005
- It would be useful if there was a way to restrict a column to accept only numeric values... -- MartinWatt - 24 Nov 2002
- Following on from the previous item: another cell type that has a numerical label and +/- controls (one or both) to increment/decrement it within predefined range. -- SH
- Has anybody done any work on supporting justification of cells with the edit plugin? -- JohnRouillard - 25 Jun 2003
- How can I prevent that
%ATTACHURL% is expanded when I edit the table? -- ArthurClemens - 12 Feb 2004
- I would like to hide the edit button when the user has no edit rights. Should I do this with ConditionalPlugin? -- ArthurClemens - 12 Feb 2004
- Could there be a new attribute (footerrows) or some such that tells the Add row button to add the row before the footer. -- GaryBeckmann - 02 Apr 2004
- And since I'm here, could I request a way to have the add rows put the new row in at the beginning of the table (after the header?). -- GaryBeckmann - 02 Apr 2004
- I second Gary's request to be able to specify that new rows are added at the beginning of the table. I would also like a "delete first row" button. Currently you can only use the table as a stack. With those features you could use it as a list where items were inserted/deleted at either end. -- SamHasler - 08 Apr 2004
- It would also be nice if there were tools to reorder the table, and delete any row. -- SH
- Option to have edit controls appear above the table. -- SH -- A coworket just asked for this today -- Main.VickiBrown - 26 Feb 2008?
- Prevent variables used in select lists within edit cells from expanding when editing table. -- SteveRosenthal - 23 Apr 2004
- But make it defineable for initial values. I've just used format=| select, 1, %SEARCH{...}%| ..." and I want that to evaluate. I've also used %SERVERTIME{}%, but if I was to use %!Y% I wouldn't want it to expand. Prehaps $per should be supported ie "$perY%". -- SH
- Right. In my particular case, I'm using the form |%EDITCELL{select, 1, %LISTOFSTUFF%}%| and I want %LISTOFSTUFF% to behave the same as if it were in a normal select cell. (Apologies if I'm being redundant.) -- SR
- Name tables using a
name="MyTable" parameter so that you can link to the anchor of a named table and be sure it will always link to the same table ie #edittableMyTable -- SH
- Agree. In fact, if the tables were named by default (using page-name as base), instead of just numbered, it would probably fix a bug where if you include an EditTablePlugin from another page after an EditTablePlugin on the current page, editing the 1st table over-writes both -- BradVance - Oct 5 2004
- Disable topic
Edit link so that changes to the table can't be accidentally lost, or find a way to make table edits carry over straight into topic edit without a save. (Should this really be a bug?) -- SH
- Modify so that either a) %INCLUDINGTOPIC% works, or b) %TOPIC% behaves like INCLUDINGTOPIC when you use the %EDITTABLE{include="SomeTopic"}% syntax. -- KM
- use javascript sorttable for default sorting mechanisim and only fall back to server-side sorting if jscript is not available in the client. -- mhw
- Show hierarchy using a special column. For example, there is a table of tasks, subtasks and sub-subtasks. Some mechanism to connect parent with children. (For e.g. the way mozilla shows threading in news article). A special column specifies the child's level, and this info is used to create graphics the way TreePlugin does. -- Main.VinodKulkarni - 24 Sept 2004
- I'd like additional edit-types - specifically the following: -- BradVance - 0ct 5 2004
- twikitext - where it gets the actual text of the table (ie - what you see in normal edit mode) thus enabling using twiki variables etc.
- renderarea - similar to above, but wrap it in <render> tags (hiding/removing the render tags in edit mode and translating newlines/html-breaks) so that the user can just type in normal twiki text, and have it formatted correctly inside the cell
- I'd like to be able to set colors in choice fields, e.g. done,broken,etc. right now, this breaks the selection when editting the table. -- SteveWampler - 05 Apr 2005
- I use the following workaround:
%EDITTABLE{format="| text,15 | radio, 1, PENDING, ACTIVE, <span style='background-color: green'>GREEN</span>, <span style='background-color: yellow'>YELLOW</span>, <span style='background-color: red'>RED</span> |"} -- DanDascalescu - 11 Jan 2008
- How about an Add Column button? -- SeanTSmith - 01 Aug 2005
- It would be useful (to me at least) to have the option to generate anchors with the task id field, maybe with an anchorprefix="blah" and have anchor #blah1 generated in row 1 (example). This would make it possible to provide jump links at the top of a large topic. -- BrianZablocky - 31 Aug 2005
- Append-only-mode -- I would like a parameter that caused only the "Add Row" button to be possible and did not allow editing of existing table rows. For one thing, a readonly table (for existing data) could be useful and, for another thing, performance goes downhill fast when converting a largish table into an "all fields are editable" form. -- VickiBrown - 30 Jun 2006
- For this you can use the CommentPlugin, it can be setup so that on submitting a form, content is appended to a TWiki table. -- PeterThoeny - 30 Jun 2006
- For performance reasons you might want to look into EditTablerowPlugin, which allows editing of a single row only -- ThomasWeigert - 11 Oct 2006
- It would be nice if the Edit button could be positioned on the bottom-right side of the table -- JosMaccabiani - 29 Aug 2006
- Some tables are quite large and it is often desirable to have an edit button at both the top and bottom of the table. Thus a parameter to specify vposition="top, bottom, or both" would be very helpful. -- KeithHelfrich - 22 Jan 2007
- When editing long tables with many columns, the user can lose track of what header corresponds to each column. I propose to keep the header fixed and have the table in a scrollable
div right beneath it. -- DanDascalescu - 11 Jan 2008
- I have a simple expenses system written using TWiki, it balances bank accounts, cash-in-hand & lets the user enter individual claims. I would like to be able to add rows to the table, but:
- It has formulae in label fields, which I don't seem to be able to clone into a new row, even using an initial value with escaped characters in the format. This could be a limitation of the plugin, or my error.
- I have a trailing total row, followed by an "invisible row" (cells with CALC formulae inside html comments) so I'd really like to be able to specify a footer row (or rows) so that a new row is added before them to be included in their calculations -- ChrisHogan - 01 Feb 2007
- Hi Chris, maybe you could add your code as an alternative to the AccountLedgerApp, or take from what has already been done there -- KH
- Didn't know about AccountLedgerApp - I'll look at it, because our company accounts have been in an Excel based system for about 15 years (I was laid up with a broken leg & didn't have anything better to do...). It is capable of generating the accounts for a small company (max employees we've had: 10, max turnover £900,000, so it's not a toy), but recently we've been considering moving the lot onto the Internet. My expenses system is a first cut at that. Chris
- Chris is right, the ability to specify *footer row(s) would be really useful -- KH
- Why should it take 3 button clicks to add a new row ('edit table', 'add row', 'save table') ? I'm thinking of how nice it would be to have an empty row at the bottom of the table, waiting with a submit button, and reduce the number of steps for adding a new row from 3 clicks to 1. -- KH
- I would like to be able to INCLUDE select items from another page (or, say, from another table). I can do this now, with a regex and all of the select items on one line, but I'd like to be able to format the select items so I can edit them nicely and then have EditTable? slurp them in.
- add (or delete) an arbitrary row, anywhere in the table - this would be a killer UI feature for users who really shouldn't be in TML mode. * EditTable? should observe and respect multi-column table cells (colspan)
Updates
The first version is available. At work we have a test result tracking database where this table editor is part of it.
--
PeterThoeny - 06 Apr 2002
A small update aka bug fix was done. Unlike on Windows, Netscape on Unix allows you to paste multiple rows into an edit field. That was going on-to-one into the table cell, breaking the table apart.
Related to this plugin,
Codev.SimpleTableEntryUsingForms has the same purpose but is implemented differently.
--
PeterThoeny - 18 Apr 2002
Updated plugin:
- Added fixed label with format option
label. (Option off was suggested by Andrea)
- Added new
changerows="add" parameter. (addonly was suggested by Andrea)
- Support for variables in included EDITTABLE parameters. (Suggested by Colas)
- Minor changes; fixed problem with HTML in cells
--
PeterThoeny - 26 Jun 2002
Updated plugin with new
helptopic parameter.
--
PeterThoeny - 27 Jun 2002
Updated Plugin version 08 Nov 2002 is posted. This version allows you to place variables in label text (but not yet in other types of fields). This can be used for example to do some spreadsheet calculations or to show a
GaugePlugin gauge.
--
PeterThoeny - 09 Nov 2002
Thanks Franz Josef, I added JSCALENDARDATEFORMAT and did some Plugin code cleanup.
In addition, I added CHANGEROWS, JSCALENDARLANGUAGE, JSCALENDAROPTIONS settings.
The CHANGEROWS is now configurable, making the Plugin again backward compatible.
I preinstalled the Mishoo DHTML calendar in the Plugin. Can anyone confirm that it is OK to bundle a LGPL utility with GPLed code?
This topic is getting long, needs to be
EditTablePluginDevArchived
--
PeterThoeny - 14 Dec 2003
Posted new version that fixes a bug where the date picker did not work after adding a row.
Also, I got an e-mail reply from Mihai Bazon
mishoo@infoiasiPLEASENOSPAM.ro that "I presume it's possible. LGPL basically allows one to even include it in commercial software, so I see no reason why you couldn't use it in TWiki."
--
PeterThoeny - 20 Dec 2003
New Plugin version is posted:
- Added per cell definition of edit field types with
%EDITCELL{}% variable
- Added
headerislabel and editbutton parameters
Enjoy.
--
PeterThoeny - 17 Feb 2004
New version released and installed on TWiki.org:
- Added QUIETSAVE setting and quietsave parameter
- Added image for Edit button
- Added missing gif images reported by Hans
--
PeterThoeny - 28 Feb 2004
New version released on Plugins topic and installed at TWiki.org:
- Fixed bug where two tables got updated when you edit and save a table included into a topic containing other edit tables
Martin, I reverted your change and added a link to a sandbox topic. This has two reasons: To make it easy for the admin to test the installation and to have all on one place.
--
PeterThoeny - 08 Apr 2004
New version posted in
EditTablePlugin topic and installed on TWiki.org. Contains fix where edittable did not work if at the end of a topic. Thanks to
CrawfordCurrie for debug help.
--
PeterThoeny - 02 Aug 2004
New Plugin posted, with enhancements needed at my workplace:
- Added radio buttons and checkbox controls
- Escaped "|" pipe symbol found in input fields to preserve tables
--
PeterThoeny - 16 Sep 2004
Discussions
It looks like variables in a select menu within an EDITCELL statement are being fully expanded and nop'ing them doesn't work. I don't know if this is a bug, design limitation, or feature request, but it would be great if they followed the same behavior as variables in a traditional select menu. It would keep things cleaner in topic edit mode.
--
SteveRosenthal - 23 Mar 2004
Added a lot of wishlist items including one that might be considered a bug.
Steve: "In my particular case, I'm using the form |%EDITCELL{select, 1, %LISTOFSTUFF%}%|"
EditTablePlugin#Limitations_and_Known_Issues says you can include vars in selects by using <nop>. Have you tried that?
- That was the first thing I tried. It keeps the variable from expanding -- completely. In other words, when you go to edit the table and make a selection from the list, you only see the (unexpanded) variable name. -- SR
Is the variable %LISTOFSTUFF% defined with a static list or a %SEARCH{}%? Because I had problems getting a search stored in a variable to work but when I put the search directly in the format definition it worked. Also, if you are using a topic variable it will keep its saved value when previewing. This caught me out once or twice yesterday.
- It's a static list (a Web preferences variable). -- SR
--
SamHasler - 28 Apr 2004
Well, I've run into a pickle. In an effort to speed up twiki we implemented
SpeedyCGI? . The speed improvement is
amazing. Now I have run into an interesting problem with
EditTablePlugin that I am not sure is related to
SpeedyCGI? -
more tomorrow. But here is what I see:
If I edit a small table, all is fine. If, however, I edit a large table (24 rows)
EditTablePlugin goes into a "wait
forever" mode. Putting the plugin into debug mode renders the following messages:
11 May 2004 - 16:48 - TWiki::Plugins::EditTablePlugin::initPlugin( CUE.ActionPlanAnnualSystemScans2004Q2Tx30 ) is OK
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.DocumentOwner )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.DocumentOwner )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.DocumentOwner )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.FindingsExceptions2004 )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.ActionPlanAnnualSystemScans2004Q2Tx30 )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.ActionPlanAnnualSystemScans2004Q2Tx30 )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE.ActionPlanAnnualSystemScans2004Q2Tx30 )
11 May 2004 - 16:48 - EditTablePlugin::doEnableEdit( CUE, ActionPlanAnnualSystemScans2004Q2Tx30 )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
11 May 2004 - 16:48 - EditTablePlugin::commonTagsHandler( CUE. )
(20 more removed)
Everything appears to be fine until the call to
commonTagsHandler after the
doEnableEdit. An edit on a small
table (4 rows) results in the following debug output: (commented out)
I'm not sure what is going on but we are going to try turning off
SpeedyCGI? - which wil lbe a real bummer as it speeds
up Twiki substantially.
Anyone have any insight into what is happening based upon the above debug output?
Thanks
--
SteveRJones - 11 May 2004
Ok, I've gone back an re-thought this.
SpeedyCGI? has two mods of OP: Apache_mod or as a #! replacement for Perl. We were using the Apache module and it looked like some buffer size issue which was not modifiable under _mod. So, instead we now "accelerated" each individual cgi script and have yet to have the above re-occur. Bottom-line:
SpeedyCGI? drastically speeds up TWiki. Highly recommended.
--
SteveRJones - 02 Jun 2004
Is it true that
EditTablePlugin won't edit a cell if its formatted as a
*header* ? It appears that's the case.
%EDITTABLE{ header="| *Server* | *Term Srv Port* | *Interface* | *IP Address* | *Netmask* | *IPMP Group* | *IPMP Flags* |" changerows="on" }%
| *Server* |*Term Srv Port*|*Interface*|*IP Address*| *Netmask* |*IPMP Group*|*IPMP Flags*|
| Coarse A | 30 Jan 2004 | .2 | 1.24.75.45 | /25 | | |
| Coarse B | 06 Apr 2004 | .5 | 1.24.79.46 | /25 | | |
| | | | 1.24.75.148 | /25 | | |
| <b>Total Hours:</b> | | 0.3 | 1.24.75.90 | /25 | | |
When I click "Edit", the "adm1" and "Term Srv" cells in the Server column can not be edited. As a feature, it would be nice if the plugin allowed header type cells to be modified.
- Spec: Any header cell is automatically a label and can't be edited -- PeterThoeny - 16 Sep 2004
--
SeanONeill - 12 May 2004
Sean, refer to
EditTablePlugin and I believe you will find the answer to your question is already there as
headerislabel="on/off".
--
SteveRJones - 13 May 2004
I just came across the following bug: If you create a select list with 0 as an option, it appears as a blank space in the list pulldown when editing the table.
--
SteveRosenthal - 27 May 2004
Maybe someone can help me get the following functionality: We would like to use the
EditTablePlugin to:
- Track ToDo tasks for all our projects
- Each project has a topic, and the ToDo items for each topic should be kept/edited there
- Have a main ToDoTable topic that shows all ToDo items
Currently I have put an
EditTable? on each project, that looks like this
and repeat for each
TestTopic2? ,
TestTopic3? . Since each topic should have the same
EditTable? , I am using the
include ="ToDoTableTemplate" argument for the
EditTable? variable.
Then, on the ToDoTable, I try to group all these together with a SEARCH{...} statement.
I have run into the following limitation:
- The Topic (left-most column) should be a non-editable label based off of INCLUDINGTOPIC. This does not work.
- I tried to get around this by making it a drop-down list of all possible items using SEARCH{...}, but each time a user edits the table, all rows get their first column reset to the first item returned by the SEARCH{...} query.
Any suggestions how to do this? Should I be using an
ActionTracker? instead?
--
KenMankoff - 14 Jun 2004
Main.XavierREDON points out that this behavior is fixed in EditTablePluginEnhancement.
Ken, see
http://owiki.org/FQP/ for an idea of what can be done using the
FormQueryPlugin when combined with the
EditTablePlugin.
--
CrawfordCurrie - 18 Jun 2004
http://www.kryogenix.org/code/browser/sorttable/ - A short javascript which allows a table to be sorted by clicking on the column headings
without another trip to the server. Very nice. Just add a fallback mechanism for no-js browsers and we can have our cake and eat it too.
--
MattWilkie - 20 Jun 2004
I am interested in a simple feature that will help "select" options list to be read from a topic, exactly like what
TWikiForms? does. (No, not the usual
include syntax, but an include within select such as
select, 3, include(ListOfOptions? ).). Though this could be done by using SEARCH, I am looking for a clean approach.
In related note, I am also looking for a capability for more than one options to be selected and added to table, probably separated by ';', with any rendering such as BR.
Are there any alternatives?
--
VinodKulkarni - 06 Jul 2004
What happened to bin/viewauth? Edit table uses this, but it is no longer in the twiki distribution. Or should I upgrade EditTablePlugin?
-
viewauth is shipped with the distrubution. It is not in SVN to avoid out of sync files. -- PeterThoeny - 16 Sep 2004
--
ArthurClemens - 08 Jul 2004
I think I have managed to get $percnt syntax to work such that the Select option variables are dynamically evaluated. This code was very much there, but for a nasty bug. Here is the patch:
***************
*** 546,553 ****
$size = 1 if $size < 1;
$text = "<select$style name=\"$theName\" size=\"$size\">";
$i = 2;
! while( $i < @bits ) {
! $val = $bits[$i] || "";
$valExpanded = $bitsExpanded[$i] || "";
if( $valExpanded eq $expandedValue ) {
$text .= " <option selected=\"selected\">$val</option>";
--- 548,555 ----
$size = 1 if $size < 1;
$text = "<select$style name=\"$theName\" size=\"$size\">";
$i = 2;
! while( $i < @bitsExpanded ) {
! $val = $bitsExpanded[$i] || "";
$valExpanded = $bitsExpanded[$i] || "";
if( $valExpanded eq $expandedValue ) {
$text .= " <option selected=\"selected\">$val</option>";
I used syntax:
%EDITTABLE{format="|text, 20|select, 1, $percntINCLUDE{TestTopic2}$percnt, localoption1, localoption2|"}%
Could someone verify if it breaks anything else?
--
VinodKulkarni - 22 Jul 2004
I haven't been able to find anything documented about this - but say I set up a 'textarea' to accept random text which may eventually recieve a pipe somewhere in it
(e.g. "|")
, it will destroy the table. Any workarounds for this?
--
AaronSebastian - 27 Jul 2004
Pipe symbol: Plugin should escaped it. Looks like a bug.
No time yet to incorporate other changes...
--
PeterThoeny - 02 Aug 2004
Since
EditTablePlugin seems to slow down as you add more rows, I have found that adding a "Add multiple rows" button was well appreciated by my cow-orkers. I restrict to at most 10 rows to avoid pain. I am posting the diff here though the line numbers might be off since I have already hacked it otherwise.
diff new old
189,190c189,190
< } elsif( $query->param( 'etaddonerow' ) ) {
< # [Add one row] button pressed
---
> } elsif( $query->param( 'etaddrow' ) ) {
> # [Add row] button pressed
194,204d193
< } elsif( $query->param( 'etaddrows' ) ) {
< # [Add num rows] button pressed
< my $numRows = $query->param ( 'etnumrows' );
< if ( ($numRows =~ /[0-9]+/) && ($numRows < 11)) {
< # add atmost 10 for sanity check
< $cgiRows += int $numRows if( $cgiRows >= 0 );
< } else { #default add one
< $cgiRows++ if( $cgiRows >= 0 );
< }
< $doEdit = doEnableEdit( $theWeb, $theTopic, 0 );
< return unless( $doEdit );
468,470c443
< $text .= "$preSp< input type=\"submit\" name=\"etaddonerow\" value=\"Add one row\" />
\n";
< $text .= "$preSp< input type=\"text\" name=\"etnumrows\" value=\"1\" />\n";
< $text .= "$preSp< input type=\"submit\" name=\"etaddrows\" value=\"Add rows\" />\n";
---
> $text .= "$preSp< input type=\"submit\" name=\"etaddrow\" value=\"Add row\" />\n";
--
KiranBondalapati - 03 Aug 2004
I seem to be unable to add a second row. Not experienced with debugging twiki, but with some pointers I might be able to help. When I click "add row" a request is sent but the server (apache/FC1) never responds. Try here:
http://www.dplinux.org/twiki/bin/viewauth/TWiki/TestPlan#edittable2
Thanks
PS: it actually returns an error: premature termination of script headers
--
AntonioPiccolboni - 13 Aug 2004
Just a little enhancement which is nice and usefull for a Todo list (for example) edit table.
I have added two possibilities : move or protect from edit a row.
- Protect a row :
- Set option keywordlock to match cell content of rows to protect from editing.
- Move rows :
- Set option keywordmove to match cell content of rows to move and set moverows option to tell the way you want rows to be moved :
- move matching rows to the end of the table,
- move matching rows to a (non-editable) table below current one,
- move matching rows to the end of Topic (in this case, you can also have a table header).
See
EditTablePluginMoveRows, to get a better understanding. In this example, I have activated options :
- keywordlock=LOCKED
- keywordmove=CANCELLED|FINISHED
- moverows=topicend
Any cell filled with text
CANCELLED or
FINISHED will cause corresponding row to be moved according to the selected move action (no move is done if action is not correct).
Any cell filled with text
LOCKED will not be editable via editable.
I have uploaded the patch against 07 Apr 2004, it's small, only a few lines added or changed. Hope You all appreciate it
--
PatrickNomblot - 18 Aug 2004
There is a bug in the current
EditTablePlugin, see
EditTablePluginAnomolies.
--
MattWilkie - 07 Oct 2004
BUG Spreadsheet functions get expanded. The following example worked in the Beijing TWiki release, but does not in the Cairo (current) release:
%TABLE{cellpadding="3"}%
%EDITTABLE{ changerows="on" header="on" }%
| *Label1* | *Label2* | *Label3* |
| data | data | data |
| data | data | data |
| *Subsection* | | |
| data | data1 | data |
| data | data | data |
Editing this table via the Edit button will whack the %CALC% function.
--
MartyBacke - 01 Nov 2004
Is it possible to %INCLUDE% a http link in a table? The contents of the http link are displayed, but the embedded �select� function for a different column appears broken, when editing. This is an example of what I�m trying to do:
%EDITTABLE{ format="text, 15, nul | text, 15, nul | text, 15, nul | select, 1, start, not| text, 15, nul |text, 16, nul |" | changerows="add" | headerislabel="on" }%
| *Machine* | *Test* | *Build* | *Tests* | *Comment* | *URL* |
| cherry | Test | 1119 | start | out | %INCLUDE{"http://X.X.X.X/test/wiki/cherry"}% |
--
ScottCarroll - 21 Nov 2004
With any luck, the changes in
EditTablePluginEnhancement address my problem -- please see the note above concerning %INCLUDE% of an http page not rendering correctly. As I said above, %INCLUDE% appears either broken, its function is not well understood, or this is a limitation.
--
ScottCarroll - 24 Nov 2004
The schema specification for
EditTablePlugin appears to duplicate the functionality of the
TWikiForm? ; it occurs to me that merging the two would bring about greater consistency.
--
MartinCleaver - 02 Jan 2005
Peter, I just saw now (shame on me) that you set the default date to a non-standard one
(YYYY/MM/DD). I would rather advocate
MovingToIsoDate format, which is a standard, unmistakable format (and sortable). Opinions?
--
ColasNahaboo - 06 Jan 2005
I packaged
ColasNahaboo's use of JSCalendar with minor modifications to leverage
JSCalendarContrib in
JSCalendarAddOn. The
update to EditTablePlugin below leverages
JSCalendarAddOn rather than duplicating the JSCalendar needlessly.
--
ThomasWeigert - 07 Feb 2005
ChangeProposalFormDefect was caused by peculiarities in the way this plugin expands variables.I was able to fix it by changing the variable definitions but it would make this plugin infinitely more useful.
When going into edit mode I want it to expand variables so that I can put EDITCELL definitions in variables, but when it saves the table again I would like it to save the variable name again, not it's evaluated content.
I also want to be able to use variables within variables. That is I want to be able to do the following:
* Set CATEGORIES = one, two, three
* Set MYEDITCELL = %EDITCELL{checkbox, 4, %CATEGORIES%}%
| *Categories* | %MYEDITCELL% |
(This is so that I can use
%CATEGORIES% in a html form for initially populating the table on topic creation. That way the list is defined in one place.)
Currently it expands
%MYEDITCELL% to get the editcell definition, but it doesn't expand
%CATEGORIES% and treats it as a single checkbox. When the page gets rendered you end up with a single checkbox for "one, two, three".
--
SamHasler - 14 Feb 2005
I'm seeing the same as
MartyBacke? is mentioning, is this resolved or circumventable by some of these EDITCELL modifications going?
--
OleCMeldahl - 07 Mar 2005
FYI: I was going to post a bug refering to
EditTablePlugin the current stable release of twiki. However, this bug did not show up here on twiki.org, so i removed my posting.
However my simple example modified another example on the this page, when hiting edit and save on my table example. See r1.178-r1.177 for details.
Here is the example I used which created the issue mentioned. I didn't check again to avoind other changes on this page though.
--
WolfgangAlper - 14 Mar 2005
is there a way to have the calender displayed all the time, not just when editing?
--
MattWilkie - 10 May 2005
Does anyone know if its possible to
hide the table while still allowing the EDIT button to appear? I often use the
ChartPlugin and would love to be able to combine a displayed chart with a hidden EDITTABLE. Then, clicking on the EDIT button would pop up the EditTable window, allowing me to quickly change the values displayed in the chart.
--
SteveWampler - 22 Jun 2005
Interesting idea, I guess it should be possible to do this by some CSS wizardry, but I'm pretty sure neither
TablePlugin nor
EditTablePlugin have proper support for this yet.
Steve's proposal sounds like yet another useful application of the lately proposed twisty mechanism.
--
FranzJosefSilli - 22 Jun 2005
--
FranzJosefSilli - 29 Aug 2005
Well, I didn't think so, but one can always hope. I can hide the
TablePlugin (or
EditTablePlugin) easily enough by embedding it in an HTML comment, but would have liked to show the EDIT button. Thanks for the response.
--
SteveWampler - 22 Jun 2005
EditTablePlugin versions are out of synch.
CVS reports latest version as 07-Apr-2004,
Plugins.EditTablePlugin is 16-Sep-2004, and
Develop is 1.024 and appears to have branched from
EditTablePlugin one rev back from current.
Q: Does the develop version incorporate the change from the Plugins web and just not note it?
Q: Where is the develop version hosted?
A:
Ah, it is now in the DEVELOP branch in svn
--
MattWilkie - 06 Jul 2005
Can anyone help out with this? I've got a topic in which I want to have the user to be able to generate a table by providing the table name, then pressing a 'create' button. I've created a template in the User Templates topic that has:
%TMPL:DEF{PROMPT:Stable}%<br />
| *Name* | <textarea cols="80" rows="1" name="Stable_name"></textarea> |
| <input type="submit" value="Create new table" /> ||
%TMPL:END%
%TMPL:DEF{OUTPUT:Stable}%
%POS:BOTTOM%
%BR%%BR%
---++ %URLPARAM{"Stable_name"}%
%BR%
%TABLE{ cellpadding="1" headeralign="left" tableborder="0" columnwidths="400,700" databg="#F3F0F0,#EAEAEA" headerbg="#cccccc" }%
%EDITTABLE{ changerows="off" editbutton="Update table" format="|label|text, 80|" }%
|*TITLE*|%EDITCELL{ "label" }%|
|Data |test data|
%TMPL:END%
I then use COMMENT in the topic itself to allow the user to create multiple tables of the same type on demand:
%COMMENT{ type="Stable" }%
When I run this, the table is created ok, but the EDITTABLE command seems to get parsed into:
<a name="edittable1"></a>
<form name="edittable1" action="http://x.x.x.x/twiki/bin/viewauth/Sandbox/TestTopic2#edittable1" method="post">
<input type="hidden" name="ettablenr" value="1" />
<input type="hidden" name="etedit" value="on" />
Whenever the user presses any of the Edit buttons associated with a generated table, it jumps to the first table in the topic and edits that. Any ideas how to stop this behaviour so the user edits the correct table?
Many thanks in advance.
--
HelenJohnstone - 12 Sep 2005
When I add a row, the table is re-rendered with the new empty row but the top of the table appears on the screen. Hence I have to scroll down to the empty row each time. That's a bit tedious when there are a few hundred rows.
Does anyone know how to have the bottom of the table displayed when a new row is added?
--
DavidBaker - 28 Nov 2005
How do maintain formatting in the rows themselves? I'd like to have some of my columns centered, not just right aligned?
--
BrianBeaudet - 10 Feb 2006
Use a
%TABLE{}% directive, located above the
%EDITTABLE{}%. See
TablePlugin.
--
PeterThoeny - 10 Feb 2006
I have made a small patch which allows you to set some of the edittable design in a css stylesheet, mainly the defintion of background colors in even and odd rows... the color was hardcoded before:
< if ($theRowNr % 2) {
< $style = "Even";
< }
< else {
< $style = "Odd";
< }
---
> $style = " style='background:#e8e8e8'" if ($theRowNr % 2);
424c419
< $text = "<select class=\"editTable$style\" name=\"$theName\" size=\"$size\">";
---
> $text = "<select$style name=\"$theName\" size=\"$size\">";
466c461
< $text .= "<input type=\"hidden\" name=\"$theName\" value=\"$theValue\" />";
---
> $text .= "<input$style type=\"hidden\" name=\"$theName\" value=\"$theValue\" />";
475c470
< $text .= "<textarea class=\"editTableTextarea$style\" rows=\"$rows\" cols=\"$cols\" name=\"$theName\">$theValue</textarea>";
---
> $text .= "<textarea$style class=\"editTableTextarea\" rows=\"$rows\" cols=\"$cols\" name=\"$theName\">$theValue</textarea>";
508c503
< $text = "<input class=\"editTableInput$style\" type=\"text\" name=\"$theName\" size=\"$size\" value=\"$theValue\"/>";
---
> $text = "<input$style class=\"editTableInput\" type=\"text\" name=\"$theName\" size=\"$size\" value=\"$theValue\"/>";
All you need to do after applying the patch is defining
editTableInputOdd,
editTableInputEven,
editTableTextareaEven etc. in your css file with your custom background color.
--
PeterLohmann - 13 Feb 2006
I'm having an odd problem with the edit table plugin where it replaces the row headers with names of a previously edited table. I posted a support question at
EditTableReplacesHeaders .
--
JoelOnofrio - 22 Feb 2006
Anyway to have a summary row (or two) that always stays on the bottom and won't be moved when the rest of the table is sorted? I'm trying to create a dynamic table that has such a thing and use the summary data for charting. So this table would be using
EditTablePlugin,
SpreadsheetPlugin? and
ChartPlugin. My main concern it just the non-sortable rows.
--
BrianBeaudet - 30 Mar 2006
You can "stick" header and footer rows with the
TablePlugin, it has
headerrows and
footerrows parameters.
--
PeterThoeny - 30 Mar 2006
I've added a feature for moving rows around quickly and conveniently. Select a row by clicking on it's row label, then click the "Move row" button, and select a target position. The row is instantly moved. The change happens entirely on the client side, so nothing is sent to the server until and unless you submit the table using the normal controls.
In order for this to work, your rows do need row labels. So for example, format one of your table columns as "label, 0, %EDITCELL{row, 0}%", or something similar. That column can then be used to click-select rows for moving or deleting (tested in IE 6 and Firefox 1.5).
If interested, please try my patched version of the plugin:
TWiki-4.0.2-EditTablePlugin-MoveRowDynamically.tgz Please note, this patch
requires TWiki 4.0.2.
Just unpack it in the top-level TWiki directory, and please let me know of any compatibility issues you discover. It Changes only two files and adds a third. You can back out the change by restoring the original files.
--
ByronDarrah - 24 May 2006
Interesting feature. What happens if
JavaScript? is disabled? Does it degrade nicely?
--
PeterThoeny - 25 May 2006
Nope. It will degrade pretty horrbibly :-). In getting this to work I ended up having to convert the delete row function to a script hook as well, so without script support, both move and delete features go away. It should not cause any tables to corrupt or anything like that, you just won't be able to move or delete rows.
Do you think something like this could have a chance to be accepted into the main
EditTablePlugin development? (Perhaps if we make it a little more graceful for scriptless clients?) If not, then I'll be happy to rename this modified version of
EditTablePlugin so that it can be deployed without concern over getting creamed by a future
EditTablePlugin update. (Maybe that's the way to go anyway -- I could just call it "DynamicTablePlugin" or some such, and assert that Javascript support is required, so anyone needing to support scriptless clients should not use it? Hmm.) Interested to hear what you and others think.
--
ByronDarrah - 02 Jun 2006
I'd say if it is done so that it degrades nicely without JavaScript it is better to take it into this Plugin codebase. Make sure to work with the latest version from the TWiki 4 SVN branch,
http://svn.twiki.org:8181/svn/twiki/branches/TWikiRelease04x00/twikiplugins/EditTablePlugin/
ReadmeFirst has more on how to get involved in using SVN for Plugin development.
--
PeterThoeny - 03 Jun 2006
Okay, thanks for the advice. I'll work on the graceful degradation and investigate SVN development.
--
ByronDarrah - 06 Jun 2006
I suggest a little (in code changes) but very usefull enhancement to editable (with patch here against DAKAR 4.0.3) . We use it in our TWiki (>500 users) since 2002 without any problem, sure that many people would appreciate it :
We added two possibilities :
- protect a row from editing if it contains a given keyword
- move (at the end of topic or of table) a row containing given keyword
- Protect a row :
- define option keywordlock to match cell content of rows to protect from editing.
- Move rows :
- define option keywordmove to match cell content of rows to move and set moverows option to tell the way you want rows to be moved :
- move matching rows to the end of the table,
- move matching rows to a (non-editable) table below current one,
- move matching rows to the end of Topic (in this case, you can also have a table header).
See
EditTablePluginMoveRows, to get a better understanding. In this example, I have activated options :
- keywordlock=LOCKED
- keywordmove=CANCELLED|FINISHED
- moverows=topicend
Any cell filled with text
CANCELLED or
FINISHED will cause corresponding row to be moved according to the selected move action (no move is done if action is not correct).
Any cell filled with text
LOCKED will not be editable via editable.
I have uploaded the patch against TWiki DAKAR 4.0.3, it's small, only a few lines added. I Hope You all appreciate it and accept to add this feature in standard
EditTablePlugin
Patch for EditTablePlugin/Core.pm
--
PatrickNomblot - 28 Jun 2006
Thanks Patrick for the patch, this looks like a useful enhancement. I did not understand how it works until I looked at the raw text of
EditTablePluginMoveRows. Could you provide documentation that we can take into the
EditTablePlugin?
--
PeterThoeny - 28 Jun 2006
Byran: are you still working on your enhancement? I think it's great, and I'm sure may others agree. I'd love to see your feature become an integral part of the plugin.
--
StephanMaasen - 15 Sep 2006
I have updated
EditTablePluginMoveRows minimal doc, My english is not very good, you may fix it if you like.
Note that mechanims could be base on
- keywordmoveafter
- keywordmoveend
- keywordmovetopicend
rather than keywordmove + moverows parameters.
It could allow 3 move possibilitees for one edittable.... as you prefer.
--
PatrickNomblot - 04 Oct 2006
I created a new column-type "color" that provides a dhtml color picker (fills in the hex value of the color). It uses
ColorPickerContrib together with this patch:
--- lib/TWiki/Plugins/EditTablePlugin/Core.pm 2006-07-29 11:38:43.000000000 +0200
+++ ../wiki/lib/TWiki/Plugins/EditTablePlugin/Core.pm 2006-10-27 20:55:19.000000000 +0200
@@ -279,6 +279,10 @@
unless( $@ ) {
TWiki::Contrib::JSCalendarContrib::addHEAD( 'twiki' );
}
+ require TWiki::Contrib::ColorPickerContrib;
+ unless( $@ ) {
+ TWiki::Contrib::ColorPickerContrib::addHEAD();
+ }
}
$text .= "$preSp<noautolink>\n" if $doEdit;
$text .= "$preSp<a name=\"edittable$theTableNr\"></a>\n";
@@ -525,6 +529,28 @@
$text .= "<textarea$style class=\"editTableTextarea\" rows=\"$rows\" cols=\"$cols\" name=\"$theName\">$theValue</textarea>";
$text .= saveEditCellFormat( $cellFormat, $theName );
+ } elsif( $type eq 'color' ) {
+ $size = 7 if( !$size || $size < 1 );
+ $theValue = TWiki::Plugins::EditTablePlugin::encodeValue( $theValue ) unless( $theValue eq '' );
+ $text .= CGI::textfield(
+ { name => $theName,
+ id => 'id'.$theName,
+ size=> $size,
+ value => $theValue ,
+ style => "background:$theValue;"});
+ $text .= saveEditCellFormat( $cellFormat, $theName );
+ eval 'use TWiki::Contrib::ColorPickerContrib';
+ unless ( $@ ) {
+ $text .= CGI::image_button(
+ -name => 'cpicker',
+ -onclick =>
+ "return cp_show('id$theName');",
+ -src=> TWiki::Func::getPubUrlPath() . '/' .
+ TWiki::Func::getTwikiWebname() .
+ '/ColorPicker/colorpicker.png',
+ -alt => 'ColorPicker',
+ -align => 'MIDDLE' );
+ }
} elsif( $type eq 'date' ) {
my $ifFormat = '';
$ifFormat = $bits[3] if( @bits > 3 );
Use like this:
%EDITTABLE{format="|color, 10|"}%
--
FlavioCurti - 27 Oct 2006
We can take this into the package, but I suggest to make this enhancement: Load the Perl module conditionally, only if needed (use a global flag that tracks if tried to load before). Graceful fallback: Reading the code, it looks like there is already a fallback to a simple text box if the module is not loaded, so that is good.
--
PeterThoeny - 27 Oct 2006
Exactly, if the module is unable to load, you just get a input box.
The module loading code is shamelessly stolen from the JSCalender add-on. So I'm not exactly sure how you want me to test. Do you want to have a flag set when it couldn't load the module, so it doesn't try to load it several times?
Rg. the color picker itself, atm it only works using DHTML so it needs a recent Browser. I haven't tested it on any other browsers except Firefox.
Thank you for your positive feedback!
--
FlavioCurti - 28 Oct 2006
The color picker is much less likely to be used than the date picker, hence the color picker Perl module and javascript should only be loaded if there is an edit cell of type color, and only once. Hence the suggestion for the global flag.
--
PeterThoeny - 28 Oct 2006
I'm not sure if this is the right place to ask, but We'd like to be able to have an open edit table and then have the ability to enter text at either the table or a comment field at the bottom of the page. By saving either one, modifications to both should be saved... any ideas? We'd be willing to support someone doing this depending on cost.
--
ArtMorales - 21 Nov 2006
You can combine the
EditTablePlugin and
CommentPlugin so that you can easily add a table row at the end. See example at
Sandbox.EditActionItems. Does that what you need?
--
PeterThoeny - 21 Nov 2006
Sorta. Ideally, the comment would be at the end of the page and not part of the table. We have many tables on one page with slightly different columns (so there are multiple places to edit). The user should be able to enter a comment at the same time they are editing the table and have both fields save by a save/addcomment action. This may be already close to what I need (the comment gets added even if the table is being edited, but I'm not sure how it would behave with mutliple tables. I'll take a look at the code and see how it is done... Alternatively, the simpler solution would be to modify the order/actions so that the "add comment" button closes and saves the page thus saving the edited table at the same time as the comment is added.
--
ArtMorales - 21 Nov 2006
Actually, It does not do what I need... the problem is that I need the user to put data in both the specific table and the comments at the end of the page... when one of the buttons is pressed to save either one, both entries should be saved at once...
--
ArtMorales - 25 Nov 2006
And so I continue my monologue... I guess one solution is to have two browser windows open, one editing the table and the other one in view mode. I should then be able to type on both and have the changes "merged" (easy, since they are not on the same section...). Thoughts?
--
ArtMorales - 27 Nov 2006
Okay, I know it's been a few months, but better late than never:
Peter wrote: Byran: are you still working on your enhancement?
Yes, I've finally circled back to that. I have a nicer version than my original
EditTablePlugin mod for letting users dynamically manipulate
table rows, plus it has no impact on non-javascript users. There is less impact to the Core.pm code than before too, so I'm optimistic that existing functionality is fully preserved.
I've requested access to the SVN to check in the changes.
--
ByronDarrah - 01 Mar 2007
For now, here's a link to the modified version. It should be a drop-in replacement for
EditTablePlugin on probably any 4.x version of TWiki.
EditTablePlugin-Dynamic.tgz
--
ByronDarrah - 01 Mar 2007
Byron, thanks for working on this! Please make sure there is a graceful fallback for those agents where javascript is turned off.
--
PeterThoeny - 05 Mar 2007
Yes, there is. If javascript is turned off or not supported, the experience should be exactly as if my changes never happened. Tested in IE 6 and Firefox 1.5. (I think Sven is on vacation or something though, so I'm sitting tight until he's available to help me with checkin access.)
--
ByronDarrah - 08 Mar 2007
Okay, dynamic table manipulation checked in to SVN. I'll be especially interested to hear of any incompatibilities with browers I haven't tested (Opera, Konqueror, Safari...).
--
ByronDarrah - 14 Mar 2007
Bug Reports
The plugin runs too late. If you put
TWikiVariables in a table cell, say
%MAINWEB%.ThomasWeigert, this will be expanded on the next edit into
Main.ThomasWeigert, and the expanded version is saved into the topic, which is not what the user entered. I believe the plugin should be run from
beforeCommonTagsHandler, not
commonTagsHandler, to avoid these problems.
--
ThomasWeigert - 07 May 2005
The definitions for the input controls should match those in
TWikiForms. It is confusing and unnecessary to have a different schema here. Note that
EditTablerowPlugin uses the scheme in
TWikiForms.
--
ThomasWeigert - 08 May 2005
I don't know if this is listed somewhere, but would it be possible to remove the dependence on spaces around "," in the select definition? Currently, if there is a space between the value and the next comma, the value is not recognized properly. Example :
select, 1, 0, .2 , .5 , 1, 2 In this case, if the table had values of .2 or .5 in that field, edittable would set the value back to the default when editing the table thus losing the previous state. Basically, the trailing spaces are being considered part of the value in the select definition.
I think this could be fixed by doing a
split(/\s*,/s*/,$format) instead of
split(/,\s*/,$format)
--
AndrewBarber - 01 Dec 2005
While using textarea,if table has more than 10 record, it will hang
--
RexXie - 27 Dec 2005
Within the latest Core.pm a comment is added to the output inside handleTableEnd() (it reads "<!-- /editTable -->") and as far as I can tell this is not used as some kind of bread crumb for later processing.
Doing this causes problems when using %INCLUDE{}% if one wishes to include a topic for calculation functionality only, i.e., an %INCLUDE{}% inside comments. This results in nested comments which causes problems with some browsers.
--
MikeMuir - 14 Mar 2006
Will, the version you posted no longer has the settings for JSCALENDARDATEFORMAT, JSCALENDARLANGUAGE and JSCALENDAROPTIONS. Is this functionality lost or just not documented? See
doc diff.
--
PeterThoeny - 07 Apr 2006
Thomas wrote "The plugin runs too late. If you put
TWikiVariables? in a table cell, say
ThomasWeigert, this will be expanded on the next edit into
ThomasWeigert, and the expanded version is saved into the topic, which is not what the user entered. I believe the plugin should be run from beforeCommonTagsHandler, not commonTagsHandler, to avoid these problems."
This comments was never followed up. The fact that you cannot use TWiki variables in
EditTablePlugin really limits its use. Will Thomas' proposal have any negative effects?
--
KennethLavrsen - 07 Jun 2006
It would be nicer if variables would not get expanded. For compatibility, possibly with a switch to expand / not expand variables.
--
PeterThoeny - 07 Jun 2006
This Plugin does not support TWiki formatting like bold and colors; if a cell is bold or colored, the cell is not editable
--
FerdinandGassauer - 08 Jun 2006
This is actually a
feature. Enclosing a whole cell in asterisks turns the cell into a heading. Headings are not editable. If you want bold cells you can write
| <nop> some text | or
| <b>some text</b> |
--
PeterThoeny - 08 Jun 2006
JS date picker does not work for me with
FireFox? 1.5.0.4 (first table at
EditTablePluginTesting for example).
JSCalendarContrib demo works ok.
No such problem with IE
--
NikolayUgarov - 08 Jun 2006
Are you using the latest version of
JSCalendarContrib, Nikolay? (See
Bugs:Item2054).
--
SteffenPoulsen - 08 Jun 2006
Thanks Steffen. I used the tip in that bug report -- remove line beginning with "z-index:1;" from pattern layout.css -- to fix this problem (browser Camino 1.0.2) . --
PaulHenryDavis - 13 Jul 2006
I am having a problem getting authentication working with the
EditTablePlugin against LDAP. Everything else in my TWiki installation is working as expected; it is just
EditTable? that is giving me troubles. Here are my details:
TWiki Version: 4.0.1
EditTablePlugin Version: Tried with what came with TWiki 4.0.1. Also tried upgrading to the 4/7/2006 release.
Authentication Details:
{LoginManager} = none
{PasswordManager} = TWiki::Users::HtPasswd::User
{Htpasswd}{FileName} = /var/lib/twiki/data/.htpasswd
{Htpasswd}{Encoding} = crypt
.htaccess
AuthLDAPAuthoritative on
AuthLDAPURL ldap://host.server.com:389/cn=Users,dc=domain,dc=com?sAMAccountName?sub?(objectClass=*)
AuthLDAPBindDN cn=Administrator,cn=Users,dc=domain,dc=com
AuthLDAPBindPassword mypassword
AuthName "Please log in with your Windows login"
AuthType Basic
<FilesMatch "[^/]*\.html$">
SetHandler blabla
allow from all
</FilesMatch>
<FilesMatch "configure.*">
#require user "{Administrators}"
require user Administrator
</FilesMatch>
<FilesMatch "(attach|edit|manage|rename|save|upload|mail|logon|.*auth).*">
require valid-user
</FilesMatch>
<FilesMatch ".*">
allow from all
</FilesMatch>
--
AdamEllis - 20 Jun 2006
Do you have a
viewauth in your bin directory? It is identical to the
view scribt, it can be a symbolic link.
--
PeterThoeny - 27 Jun 2006
How can I force a new revision of the Wiki document with every "save" of an edited table?
--
FerdinandGassauer - 06 Jul 2006
I do not see an easy way to do that. The save script has a
forcenewrevision,
TWikiScripts#save. However, the
EditTablePlugin does the read-modify-save topic action during
viewauth.
--
PeterThoeny - 06 Jul 2006
Peter - I do have a viewauth in my bin directory. It is not a symbolic link, but is the same size and timestamp as the view script. As a side question, is it possible to edit the
EditTablePlugin somewhere to disable authentication entirely? My users must authenticate to see the webs anyway.
--
AdamEllis - 10 Jul 2006
From the .htaccess you posted above it looks like view is not authenticated. Since you are saying that users must authenticate to see the webs, is it possible that the ldap auth is done at a higher level in the Apache config file? In any case, you could change all occurences of
viewauth to
view in the EditTablePlugin code. Hower, it is better to check your config for proper auth of the viewauth script.
--
PeterThoeny - 10 Jul 2006
If your table is similar to
%EDITTABLE{format="|text|text|"}%
| *Name* | *Ammount* |
| sopan | 1044 |
| Sarika | 224 |
| Total | %CALC{$SUM( $ABOVE() )}% |
When you press "Edit" button of table,
%CALC{$SUM( $ABOVE() ) }%
gets expanded to addition of numbers. So if you make changes numbers in the above rows next time, formula does not work.
Small changes in
SpreadSheetPlugin can solve this problem.
In
SpreadSheetPlugin's Calc.pm code, just add following lines in doCalc subroutine (Line number: 135):
$query = TWiki::Func::getCgiQuery();
my $frtable = $query->param('etedit');
if ($frtable eq "on" ) { return "%CALC{".$text."}%"; }
Also you need to add $query in
use vars qw(.....);
--
SopanShewale - 11 Jul 2006
Thanks Sopan. I posted a cross-reference in
SpreadSheetPluginDev since it needs to be fixed there.
--
PeterThoeny - 11 Jul 2006
We see a problem when we click on the field name to sort a column. The error message ?template=oopsleaseconflict;def=active;param1=Mai...
Conflict
Attention
Try again to see if PeterJones has finished editing yet.
Edit anyway to edit the topic anyway.
We are able to add/delete rows without this conflict message.
Could this be a bug?
--
PeterJones - 12 Jul 2006
Sounds like. Please file a bug report in
Bugs:EditTablePlugin, describing the details.
--
PeterThoeny - 14 Jul 2006
I am unable to file the bug report on develop.twiki.org. I can not register as the confirmation email is never sent.
--
PeterJones - 18 Jul 2006
You cannot register on develop.twiki.org, please login with your twiki.org account.
--
PeterThoeny - 18 Jul 2006
If I enter the twiki.org username/password nothing happens. I am again presented with the login page.
--
PeterJones - 24 Jul 2006
SvenDowideit, could you please check?
PeterJones has a TWiki.org account since Jan 2005.
--
PeterThoeny - 24 Jul 2006
You always could use
TWikiGuest/guest to file a new issue item on
Bugs till
Sven has checked/replicated
.htpasswd on
develop.twiki.org.
--
FranzJosefSilli - 24 Jul 2006
Any ideas on why I'm having trouble
InstallingEditTablePlugin on
CairoRelease would be greatly appreciated. Thanks.
--
KeithHelfrich - 25 Jul 2006
There have been many complaints that the plugin translate the
TWikiVariables? when you save the table.
You cannot at all use
TWikiVariables? without having them "destroyed" when you save.
I cannot imagine when anyone would want to enter a
TWikiVar? and then have it translated to static text when clicking save. Makes no sense at all.
I tried to alter
EditTablePlugin.pm. Very simple change. Change
sub commonTagsHandler { to
sub beforeCommonTagsHandler{
And then it works exactly like I want it. I have not found any examples that anything breaks from this. I propose that we implement this change. I can do it and upload a new version unless there are objections. Will wait some days for feedback.
--
KennethLavrsen - 25 Jul 2006
Thanks for bringing this up, Kenneth, I agree the behaviour should be altered to not expanding the variables.
Reported the locking issue from above as
Bugs:Item2684.
--
SteffenPoulsen - 25 Jul 2006
Kevin, thanks for your advice re: installation. Though, I think there may be a
problem with contents of the .tgz file. After I switched over to the
.zip, everything, began to work correctly.
PS -- thanks for the advice re: the translations of variables, noticed that problem within the first 30 seconds and it's great to have a fix !
--
KeithHelfrich - 25 Jul 2006
The zip file seems to be an old version. And the tgz file is the version updated for TWiki4.
So you have found TWO severe problems.
- Why doesn't the TWiki4 version run on Cairo?
- Why did Will upload an old zip? Is there a bug in the build script?
If the new
EditTablePlugin is no longer compatible with Cairo, we should make sure there is still a Cairo version available for download.
I have checked and the zip file is the same
EditTablePlugin version that I had running in Cairo.
And the tgz is the current TWiki4
EditTablePlugin
What I will do now is to upload an
EditTablePlugin_cairo.zip and upload a TWiki4 version of the zip so at least things are correct.
I will not try and test and fix the TWiki4 version on Cairo because it has been totally rewritten and split in more files.
--
KennethLavrsen - 26 Jul 2006
This is an essential Plugin. It needs to be fixed so that it runs on Cairo
and Dakar.
--
PeterThoeny - 26 Jul 2006
Agreed, it would be best to make do with just one version of this plugin. I will try to get back to the issue at some point later.
Bugs:Item2684 fixed, new version uploaded.
--
SteffenPoulsen - 29 Jul 2006
I looked at the the TWiki4 version installed in Cairo.
It it not going to be easy to make a single version of this plugin.
For anyone wanting to upgrade the plugin on Cairo they will have to install a new version of
JSCalendarContrib. There is also a new dependency of the Assert.pm file in lib/TWiki.
I tried to comment out anything related to Assert and JSCalendar. Then the plugin runs but when you edit a table it inserts "." after each character at each save. So something more basic would need to be updated. And this where I personally say STOP AND THINK.
Let us look at the
business case to do this.
Why would a Cairo admin download and install
EditTablePlugin?
- Answer: In reality he has no reason to. The EditTablePlugin was distributed with Cairo. In Cairo it was a default plugin part of the TWiki download. Just like it still is in TWiki4. The only reason why he downloads an update is because he gets the wrong impression that he gains something from it. In reality he gets compatibility trouble with JSCalendar and not a single enhancement or bugfix. Even the last bugfix that Steffen did is related to TWiki4.
In my oppinion we are not doing anyone a favour by trying to make a Cairo+TWiki4 version of
this plugin.
Try and put imaginary values on this business case. Let us use the currency
cyber-bananas.
The business case of making a Cairo/TWiki4 compatible version of
EditTablePlugin
| Pro/Con | Value Gained | Value Lost | Comment |
| Admin has ONE download file to choose from | 1000 | 0 | Value could be less we better keep a clearly marked Cairo version available and a clear note which version number is the last Cairo version |
| Admin's effort to do the upgrade | 0 | 1000 | Needs to also update JSCalendarContrib |
| Features that Cairo users gain from common Plugin version | 0 | 5000 | No new features. Need to fix topics after JSCalendar files have physically moved to different location in pub tree |
| Features that TWiki4 users gain from common Plugin version | 0 | 3000 | The requirement of Cairo compatibility has in practical shown that developers avoid the plugins with this requirement. There are very few enhancements released on old essential plugins. |
| Developers only maintain one version | 0 | 5000 | There is in reality no development for Cairo Developing for Cairo requires that you have a Cairo installation running and lots of test topics that use the plugin |
| Quality of plugin | 0 | 2000 | For TWiki4 the quality now depends on code that meant for Cairo only. For Cairo the new versions of the plugin are very poorly tested on Cairo. Risk of new escaping bugs into Cairo is huge. |
| Speed of plugin | 0 | 1000 | More code to compile in Dakar and in Cairo. Both looses speed. Maybe be a marginal loss but many marginal losses add up to a big loss. That is how TWiki got slow |
Another plugin with much less effort to maintain compatibility and where added features or more important bugfixes could benefit Cairo users could create a business case that favours a compatible single version.
But for this plugin it makes very little sense.
This issue we had recently was that a core developer has overwritten the Cairo version with a Dakar version without leaving behind a working Cairo version for download and this is totally unacceptable. As a minimum the last stable Cairo version must be clearly and well marked available for download. And also marked so a Cairo admin that visits the plugin topic can clearly identify that indeed he does have the latest Cairo version.
--
KennethLavrsen 20 Jul 2006
Hi Kenneth. I totally agree. I am running
CairoRelease and did not understand that the plugin was provided by default. I only installed it because I wanted to add the functionality. (Though, since I arrived at Cairo by upgrading from
BeijingRelease -- was the plugin s