Feedback on FormsAddOn

-- ThomasWeigert - 15 Feb 2005

Thomas, thank you for sharing this add-on with the community!

Small feedback:

• Write Add-On to prevent unwanted link
• Create screenshots in GIF or PNG and show them at 100% size. The current screenshots are hard too read (depending on the browser) since they are scaled down by the browser.

-- PeterThoeny - 20 Feb 2005

Could we also add a small tidbit on how to use the FormsAddOn.patch file? Regular patch < FormsAddOn.patch doesn't work so well.

-- StevenHajducko - 02 June 2005

Yes, I can't seem to get the patch to work myself. I'm getting the following errors:

tcsh> patch < FormsAddOn.patch
can't find file to patch at input line 9
Perhaps you should have used the -p or --strip option?
The text leading up to this was:

--------------------------
|Index: lib/TWiki.pm
|===================================================================
|RCS file: /e/www/CVS/twiki-cairo/lib/TWiki.pm,v
|retrieving revision 1.2
|retrieving revision 1.2.4.1
|diff -c -r1.2 -r1.2.4.1
|*** lib/TWiki.pm       26 Dec 2004 12:38:28 -0000      1.2
|--- lib/TWiki.pm       27 Dec 2004 16:54:58 -0000      1.2.4.1
--------------------------
File to patch: 

-- JessBowers - 10 Jun 2005

OK -- thanks to StevenHajducko, here's the fix:

patch -p0 -i FormsAddOn.patch

much better!!

-- JessBowers - 13 Jun 2005

checked .zip into CVS

-- WillNorris - 27 Jun 2005

Once I installed this plugin I found I was getting uninitialized variable warnings in my apache error_log.

edit.pl: Use of uninitialized value in string eq at /data/twiki/lib/TWiki/Form.pm line 554., referer: http://intranet/twiki/bin/view.pl/Admin/PurchaseRequest

Once I added the line below to initialise the $handleMandatory variable, it seemed to fix it.

*** lib/TWiki/Form.pm~  Wed Oct  5 13:10:53 2005
--- lib/TWiki/Form.pm   Wed Oct  5 16:36:53 2005
*************** sub fieldVars2Meta
*** 551,556 ****
--- 551,557 ----
                
         # Have title and name stored so that topic can be viewed without reading in form definition
         $value = "" if( ! defined( $value ) && ! $justOverride );
+        $handleMandatory = 0 if( ! defined( $handleMandatory ) );
         if ( ($value eq "") && $handleMandatory && $mandatory ) {
         # Create own oops, find topic instead of "" requires passing it in from caller as $query->param('topic') has been changed.
         my $url = &TWiki::Func::getOopsUrl( $webName, $topic, "oopsfielderr", $title);

This is an additional patch to apply after the patch in the installation itself.

If this is the right solution I'll update the ZIP.

-- SteveHobbs - 05 Oct 2005

There was a second error in my Apache log too:

view.pl: Use of uninitialized value in substitution iterator at /data/twiki/lib/TWiki.pm line 3194

I think the code didn't initialise a variable in the sub renderFormData properly.

I've put the text of an additional patch into an attachment, and added the info from Oct 5th patch as well.

Again this must be applied after the patch in the installation itself.

Peter, thanks for your feedback on TWiki:Plugins/BatchUploadPluginDev, is this more correct?

-- SteveHobbs - 07 Oct 2005

Guys, I'm a little confused on the "Other" feature. I'm trying to get a form to have couple horizontal fields (field next to each other). Is this possible? Also, is it possible to get an example of: "the field definitions are not linked." I was hoping to look at an example embedded in the main topic page but it is just an image.

-- CraigTobias - 27 Oct 2005

Also, has anyone got this to work using straight HTML tables. "Manual control over the appearance of the form " section state you can use HTML tables or Wiki tables. I can get the Wiki tables to work but not the HTML.

-- CraigTobias - 27 Oct 2005

Will this plugin work with TWiki 4? I suspect not since it is patching the code. Plans to port it to TWiki 4?

-- RickMach - 23 Jun 2006

Much of this plugin is built into twiki4 core. I will go through and analyze what in this plugin is not covered in twiki4.

-- ThomasWeigert - 23 Jun 2006

I added a SHORTDESCRIPTION to the "Add-On Info" section so that this add-on is represented properly in the AddOnPackage topic and query topics. Please feel free to take this into the next release (if any).

-- PeterThoeny - 07 Oct 2006

Can we mark it as obsolete now?

-- MartinCleaver - 04 Sep 2008