Feedback on RevCommentPlugin

-- JChristophFuchs - 10 May 2005

I have released a new version from SVN, but it turns out that the attachment handler is buggy in 4.0.2 (uploading attachments while this plugin is enabled will destroy topic content) - hopefully this will be fixed in 4.0.3 (reported as Bugs:Item2097).

• Bug fixed, download updated lib/TWiki/Store.pm from SVN and replace existing file in 4.0.2 release.

-- SteffenPoulsen - 14 Apr 2006

Hi Steffen, thank you so much for updating the plugin! I have two questions:

• do I need to remove the lines with a - before them? Because I can't see the difference with the file I already have (4.0.2)
  • The bug was fixed today (thanks CDot!) - the updated file can be downloaded directly: lib/TWiki/Store.pm from SVN -- SteffenPoulsen - 14 Apr 2006
• Although in the History view all works well, in WebChangesWC any WikiWords in the comments are not linked, but show up as though the pages do not exist yet. I this just in my installation?
  • This is due to the rendering pipeline, all links will be rendered locally in TWiki (move the mousemarker over the ?, it will point to TWiki.topic). To my knowledge there is no way of getting this rendered correctly with the INCLUDE mechanism, so I uploaded a new version which does not try to render wikiwords pr. default (will probably avoid some other problems also). -- SteffenPoulsen - 14 Apr 2006

-- JosMaccabiani - 14 Apr 2006

Thanks, I reinstalled the latest version, indeed it doesn't link anymore.

I do see some references to the 'multiple edits within the lock time' from the pre-Dakar era, e.g. in the RevComment topic. I guess they should be removed in the Dakar version to prevent confusion?

Also, in RevComment the sentence: "Your comment will be marked as (minor) if you also select the box "Minor changes, don't notify"." could be expanded to "Your comment will be marked as (minor) if you also select the box "Minor changes, don't notify" or if you press the "Quiet save" button."

Thanks again for the update.

-- JosMaccabiani - 14 Apr 2006

If you are able to either attach a SVN patch or just post updated versions of the topics, that would be very helpful. You are right, I don't think there even is a minor checkbox anymore (only the quiet save button is left now) - so that should indeed be updated.

Any help appreciated!

-- SteffenPoulsen - 14 Apr 2006

I made a little change to WebRssBase.txt to print Summary of change instead of $summary. I just don't manage to handle multi-line :-/

-- DanielDehennin - 15 Apr 2006

Hi, I've updated two topics, mainly to remove the reference to the lock-times. However, i currently have no access to a Dakar install (apparently the server crashed Friday after 17:30 so I don't actually know if it is somehow possible to have multiple comments for one revision. Anyway, hope this helps, here are the files:

• RevComment.txt: Modified version without lock-time reference
• RevCommentPlugin.txt: Modified version without lock-time reference

-- JosMaccabiani - 16 Apr 2006

Thanks for the updating docs, Jos. I uploaded a new version with your changes (plus a little code update to always allow multiple comments inside the time-lock).

Took your new WebRssBaseWC in as well, Daniel, perhaps somebody will step in for a multiline patch - XML [CDATA[-markup enhancement nescessary perhaps?

-- SteffenPoulsen - 15 Apr 2006

While taking some other plugins for a ride today I noticed that order of this plugin in relation to HistoryPlugin and CompareRevisionsPlugin is important. So, if for some reason you install this plugin in $TWiki::cfg{PluginsOrder} (using configure), or you get rendering artifacts with incomplete revision comment historties etc, make sure this one is in the setting later than HistoryPlugin and CompareRevisionsPlugin.

-- SteffenPoulsen - 16 Apr 2006

So do you recommend putting these three plugins in the PluginsOrder setting, to prevent problems in the future, or can that have adverse effects?

(another reason to think about combining these plugins into one or into core functionality somewhere in someone's future, hopefully)

-- JosMaccabiani - 16 Apr 2006

I haven't checked it, but I guess default setting is more or less alphabetic order - so no need to be specific about the order until problems are encountered.

Still a lot of work to do in this, some ideas have been sketched in Bugs:Item2064.

-- SteffenPoulsen - 17 Apr 2006

I can't seem to get the revision history list showing up properly in my document. I use: %HISTORY{reverse="on" format="| $rev | $date | $wikiusername | %REVCOMMENT[rev=''$rev'', minor='''']% |"}%

The first line doesn't format properly at all, but the rest of them format fine. I just need a way to put the revision comments and history at a point I choose in a topic.. Can anyone help?

-- MarkBarazzuol - 26 Sep 2006

The plugin index seems to work correctly, however my oopsHistory.tmpl template was not expanded as the install isntructions suggest. I can se e the versions, the user but no comment. Is there any succesful way in which I can modify manually the template?

Thanks!

-- MiloValenzuela - 14 Nov 2006

Does anyone have a copy of oopshistory.tmpl that works succesfully with HistoryPlugin and CompareRevisionsAddOn?

-- MiloValenzuela - 15 Nov 2006

To MarkBarazzuol: The problem you are experiencing is a problem with the HistoryPlugin which I have reported on the HistoryPluginDev page.

I have temporarily got around it by commenting out the calls to the handleHeadFoot subroutine inside the main handleHistory routine, in the HistoryPlugin.pm file in lib/TWiki/Plugins.

By the way, thanks for your example. I was wondering how to include the Revision Comments with the HISTORY listing.

Cheers.

-- DuncanKinnear - 13 Dec 2006

To MarkBarazzuol: I have posted what seems like a proper fix on the HistoryPluginDev page for the problem we were experiencing. It is a fairly simple change if you want to try it yourself.

Cheers.

-- DuncanKinnear - 13 Dec 2006

To TWiki:Main.JChristophFuchs & TWiki:Main.SteffenPoulsen: Hi, I love this plugin. I was wondering how I could make it work with WysiwygPlugin. Can you have a look at my question at http://twiki.org/cgi-bin/view/Support/RevCommentPluginWithWysiwygPlugin and CrawfordCurrie's comments ?

-- ChengappaCB - 07 Dec 2007

RevCommentPlugin works well with the new TinyMCEPlugin in TWiki 4.2.0. Try out the next RC3 (released in hours from when I type this).

It is true that the Rev Comment line was not implemented in the Wywiwyg in 4.1.2.

-- KennethLavrsen - 10 Dec 2007

I tried this but TinyMCEPlugin had some problem with sectionedit and tables.

-- ChengappaCB - 23 Dec 2007

Chengappa, please ensure you raise bug reports on the problems you saw on Bugs:WebHome

-- KennethLavrsen - 23 Dec 2007

On TWiki-4.2.0-rc2. The new attached files will turn to zero byte after enabling this plugin. Is this a known issue?

-- LijiYu - 16 Jan 2008

No, as far as I know this hasn't been reported yet. Please raise a bug report in Bugs:WebHome. I can confirm this failure cause it appeared on my rc2 system too. As soon as I turned off RevCommentPlugin attachment upload started to work again. Thanks for spotting this Liji! Didn't report it earlier as I thought it had something to do with access rights and would have been gone with the new setup of 4.2 (as soon as it's released!)

-- FranzJosefGigler - 16 Jan 2008

Liji, this is a known bug, TWikibug:Item5307 - Plugins with beforeAttachmentSaveHandler break file attachments with TWiki 4.2.0.

-- PeterThoeny - 04 Feb 2008

I have a CommentPlugin template that is appending lines to a table in another topic. Every time a new line is appended, RevCommentPlugin shoves a %META:REVCOMMENT{ncomments="0"}% entry onto the end of the line, garbaging my table. How do I make this stop?

-- VickiBrown - 2009-08-12