While doing some work for the caching mechanism in the
XpTrackerPlugin, I found that I need to do some procesing after the topic was saved.
I patched the TWiki20031218beta version files
StoreDotPm and
PluginsDotPm to add an afterSaveHandler that can be used by plugins for after-save processing the topic.
--
RafaelAlvarez - 06 Feb 2004
Please see
MorePluginHooks. I suggested an afterSaveHandler plugin hook myself months ago, because I needed it for
ImmediateNotifyPlugin. My implementation of the handler against
BeijingRelease is available in the plugin topic. I think this handler will make it into the plugin API for
CairoRelease. I'll have to look at your version and see whether your implementation is compatible with mine. If not, we'll have to figure out one that satisfies the needs of both plugins (and any future plugins that might want to use this handler), preferably before the
CairoRelease plugin API is fixed.
--
WalterMundt - 06 Feb 2004
Thanksfully we both named the handler the same way and put it in the same place. The only difference seems to be that your version requires an additional parameter ($error).
I have made a patch against the
TWikiAlphaRelease tagged TWiki20040229alpha, I'll update the patch to the TWiki20040301alpha version and change this topic into a
PatchProposal as soon as I test it with your plugin.
--
RafaelAlvarez - 02 Mar 2004
The unified patch against the
TWikiAlphaRelease tagged TWiki20040301alpha is up. I think that the differences between my version and Walter implementation, but couldn't test the
ImmediateNotifyPlugin
I'm changing this into a
PatchProposal
--
RafaelAlvarez - 04 Mar 2004
Alright, great. As soon as I have time to test it out a bit and make whatever minor changes may be necessary I'll get this into the core.
--
WalterMundt - 05 Mar 2004
Committed to CVS. Note that I've added actually passing the error through to the plugin in Store and removed the comments with your name. (We do appreciate those comments being there, but since they generally are there to identify "unofficial" patches having been applied to a TWiki installation they don't often get committed to CVS.)
--
WalterMundt - 07 Mar 2004
I finished the incomplete implementation: Added the handler to
DefaultPlugin and
EmptyPlugin; added meta data to text of afterSaveHandler (othogonal to beforeSaveHandler). Change is in
TWikiAlphaRelease and at TWiki.org.
--
PeterThoeny - 21 Mar 2004
Thanks Peter, that is really useful.
--
MartinCleaver - 22 Mar 2004
Martin - you need to document the parameters and returns for these 2 functions. --
SvenDowideit - 19 Jul 2004