Tags:
create new tag
, view all tags

Bug: Fix Y2K problem in "initials"

Motivation

On the edit page, under the signature, is a line with the users's initials and some other stuff, including a date. The date is off by 1900 years.

Description

As it turns out, gmtime() returns the years since 1900. (This worked much better in the 20th century than the 21st.)

Implementation

One-line fix: it adds 1900 to the years after it set in Edit.pm by gmtime().

It is quite possible that there are other places where the year is off by 1900, but I haven't seen them yet.

Note: Patch is attached as http://twiki.org/p/pub/Codev/GmtimeYear2000Problem/y2k.diff. The patch is against the 20040507beta release.

-- DuckySherwood - 02 Jun 2004

Discussion

Thanks Ducky. I changed this patch porposal to a BugReport (with fix, thanks!)

There are some pending usability issues with the TerserSignature that should be resolved as well.

-- PeterThoeny - 02 Jun 2004

This fix is not needed anymore because the code for the short-form signature has been pulled from the CairoRelease, see TerserSignature.

-- PeterThoeny - 11 Jul 2004

Fix Record

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff y2k.diff r1 manage 0.4 K 2004-06-01 - 00:04 DuckySherwood one-line change to Edit.pm
Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2004-07-11 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.