create new tag
, view all tags
I needed to separate out the functionality of upload so it could be called from a script, but got into a world of pain when trying to determine the error return status. So, I decided to split up Upload.pm so that the CGI operations are strictly separate from the actual file manipulations. See attached patch and associated tests. Also fixes a missing parameter in the attach script.

Note that the is one major remaining code smell; the use of $query->tmpFileName, which is undocumented and seems sometimes not to work, at least when running the tests from my Windows machine. The documented 'upload' method should really be used instead.

There are three files attached: one for the tools directory one for bin, and another for lib. They are three halves of the same patch.

-- CrawfordCurrie - 13 Apr 2004

I've commited this into CVS

-- SvenDowideit - 14 Apr 2004

TopicClassification PatchAccepted
TopicSummary Code refactoring - does not impact end users. Move functionality out of bin scripts and into included modules.

AssignedTo CrawfordCurrie
AssignedToCore SvenDowideit
ScheduledFor CairoRelease

SpecProgress 100%
ImplProgress 100%
DocProgress 100%
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff bin.diff r1 manage 0.6 K 2004-04-13 - 19:14 CrawfordCurrie against latest anon CVS
Unknown file formatdiff lib.diff r1 manage 10.8 K 2004-04-13 - 19:14 CrawfordCurrie against latest anon CVS
Unknown file formatdiff tools.diff r1 manage 3.8 K 2004-04-13 - 19:15 CrawfordCurrie against latest anon CVS
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2004-08-20 - CrawfordCurrie
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2015 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.