Tags:
create new tag
, view all tags

Bug: Create new web fails if RCS files do not exist

If you don't want to change the lock name in the rcs files and delete them all (as suggested in the installation instructions), creating a new web will give complaints about the missing rcs files.

Test case

Delete rcs files in the data/_default directory and try to create a new web using _default as TemplateWeb.

Environment

TWiki version: TWikiRelease01Feb2003
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS: Debian GNU/Linux
Web server: Apache 2.0.46
Perl version: 5.8.0
Client OS: Debian GNU/Linux
Web Browser: Mozilla 1.4

Patch

*** TWiki20030201/bin/manage    Sun Sep 14 14:03:59 2003
--- twiki/bin/manage    Wed Sep 17 20:50:14 2003
***************
*** 231,242 ****
      # FIXME: Hack, no support for RCS subdirectory
      $from .= ",v";
      $to .= ",v";
!     unless( copy( $from, $to ) ) {
!         return( "Copy file ( $from, $to ) failed, error: $!" );
      }
-     umask( 002 );
-     chmod( 0644, $to );
- 
      # FIXME: Copy also attachments if present
  
      return "";
--- 231,243 ----
      # FIXME: Hack, no support for RCS subdirectory
      $from .= ",v";
      $to .= ",v";
!     if( -r $from ) {
!         unless( copy( $from, $to ) ) {
!             return( "Copy file ( $from, $to ) failed, error: $!" );
!         }
!         umask( 002 );
!         chmod( 0644, $to );
      }
      # FIXME: Copy also attachments if present
  
      return "";

-- ClausBrunzema - 17 Sep 2003

Follow up

Thanks for the report and the patch.

Fix record

This has already been fixed on 02 Apr 2003, CVS:bin/manage, revision 1.10

Category: TWikiPatches

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2004-05-09 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2015 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.