Bug: Create new web fails if RCS files do not exist

If you don't want to change the lock name in the rcs files and delete them all (as suggested in the installation instructions), creating a new web will give complaints about the missing rcs files.

Test case

Delete rcs files in the data/_default directory and try to create a new web using _default as TemplateWeb.

Environment

Patch

*** TWiki20030201/bin/manage    Sun Sep 14 14:03:59 2003
--- twiki/bin/manage    Wed Sep 17 20:50:14 2003
***************
*** 231,242 ****
      # FIXME: Hack, no support for RCS subdirectory
      $from .= ",v";
      $to .= ",v";
!     unless( copy( $from, $to ) ) {
!         return( "Copy file ( $from, $to ) failed, error: $!" );
      }
-     umask( 002 );
-     chmod( 0644, $to );
- 
      # FIXME: Copy also attachments if present
  
      return "";
--- 231,243 ----
      # FIXME: Hack, no support for RCS subdirectory
      $from .= ",v";
      $to .= ",v";
!     if( -r $from ) {
!         unless( copy( $from, $to ) ) {
!             return( "Copy file ( $from, $to ) failed, error: $!" );
!         }
!         umask( 002 );
!         chmod( 0644, $to );
      }
      # FIXME: Copy also attachments if present
  
      return "";

-- ClausBrunzema - 17 Sep 2003

Follow up

Thanks for the report and the patch.

Fix record

This has already been fixed on 02 Apr 2003, CVS:bin/manage, revision 1.10

Category: TWikiPatches