Tags:
create new tag
, view all tags
Small enhancement for the log entries: The save log entry has now a dontNotify flag in the extra field in case the user checked the minor changes flag.

Example log entry:

| 25 Oct 2003 - 18:40 | Main.PeterThoeny | save | Sandbox.TestTopic9 | dontNotify | 10.10.10.60 |

Change in Store.pm:

Index: Store.pm
===================================================================
RCS file: /cvsroot/twiki/twiki/lib/TWiki/Store.pm,v
retrieving revision 1.67
diff -c -r1.67 Store.pm
*** Store.pm    28 Sep 2003 22:35:48 -0000      1.67
--- Store.pm    26 Oct 2003 01:46:50 -0000
***************
*** 590,596 ****

              if( ( $TWiki::doLogTopicSave ) && ! ( $dontLogSave ) ) {
                  # write log entry
!                 writeLog( "save", "$TWiki::webName.$topic", "" );
              }
          }
      }
--- 590,598 ----

              if( ( $TWiki::doLogTopicSave ) && ! ( $dontLogSave ) ) {
                  # write log entry
!                 my $extra = "";
!                 $extra   .= "dontNotify" if( $dontNotify );
!                 writeLog( "save", "$TWiki::webName.$topic", $extra );
              }
          }
      }
***************
*** 616,623 ****

          if( ( $TWiki::doLogTopicSave ) && ! ( $dontLogSave ) ) {
              # write log entry
!             $tmp  = &TWiki::userToWikiName( $user );
!             writeLog( "save", "$TWiki::webName.$topic", "repRev $rev $tmp $date" );
          }
      }

--- 618,628 ----

          if( ( $TWiki::doLogTopicSave ) && ! ( $dontLogSave ) ) {
              # write log entry
!             my $extra = "repRev $rev ";
!             $extra   .= &TWiki::userToWikiName( $user );
!             $extra   .= " $date";
!             $extra   .= " dontNotify" if( $dontNotify );
!             writeLog( "save", "$TWiki::webName.$topic", $extra );
          }
      }

This has been suggested by OliverKrueger in StoreDotPm. Implementation is different from the patch provided.

Is in TWikiAlphaRelease for CairoRelease and at TWiki.org.

-- PeterThoeny - 26 Oct 2003

This topic is marked as FeatureDone but has 0% DocProgress. Should it be set to 100% even though there is no documentation required (beyond this topic) for the sake of the totals in the totals in CairoRelease? or should it be set to DocsToDo?

-- SamHasler - 21,23 Apr 2004

DocsToDo is legacy. A feature can get marked as done with 0% doc progress if the docs are pending.

I created a section for log file details at TWikiSiteTools#Log_File_Details, also documenting the dontNotify flag.

-- PeterThoeny - 25 Apr 2004

WebForm
TopicClassification FeatureDone
TopicSummary The log entry for a save now has a dontNotify flag in the extra field if the user checked the minor changes flag.
InterestedParties

AssignedTo

AssignedToCore PeterThoeny
ScheduledFor CairoRelease
RelatedTopics StoreDotPm
SpecProgress 100%
ImplProgress 100%
DocProgress 100%
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2004-08-20 - CrawfordCurrie
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2015 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.