r4 - 29 Apr 2006 - 13:07:52 - SamHaslerYou are here: TWiki >  Codev Web > TestenvChecksLocalSiteCfg
Tags:
, create new tag

Patch Proposal: Fixes testenv in Dakar/DEVELOP

Motivation

During my port of the NatSkin to Dakar I start to stumble over some buglets. Well, what else ...

Description

This patch actually fixes two issues:

First, it fixes to check for the file LocalSite.cfg befor reading TWiki.cfg. I think the LocalSite.cfg way-off-configuration was just recently added to DEVELOP and testenv needed to be addapted. Basicaly, it is more of a copy-past of the code-lines that handle TWiki.cfg including the error handling ... straight forward.

Second, the checkdir() subroutine was used for warn...txt, whereas this function was designed for checking directories. That didn't work. Also, the %DATE% tag wasn't substituted with a reasonable value.

-- MichaelDaum - 26 Mar 2005


Discussion:

OK, I applied the patch and fixed a few problems it highlighted. Thanks Michael! Waiting for SVN to recover before checking in.

-- CrawfordCurrie - 26 Mar 2005

That's much better. Thank you.

Could I raise two points that are purely cosmetic.

  1. It would be nice to have an "End of File". When I was first setting up DEVELOP I was unsure if testenv had completed or failed and spent a while flutzing around trying to look at the HTML source.
  2. There are some values in $cfg hash that are set to $TRUE and $FLASE. In each case they display as a blank. Could they be translated to soemthng visible please.

-- AntonAylward - 26 Mar 2005

I'm assuming from the above that this made it into Dakar so I'm upgrading it to ChangeProposalForm and marking it as such.

-- SamHasler - 29 Apr 2006

 
Topic attachments
I Attachment Action Size Date Who Comment
elsepatch testenv.patch manage 2.7 K 26 Mar 2005 - 10:09 MichaelDaum  
Edit | WYSIWYG | Attach | Printable | Raw View | Backlinks: Web, All Webs | History: r4 < r3 < r2 < r1 | More topic actions
 
Powered by TWiki
This site is powered by the TWiki collaboration platformCopyright © by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback SourceForge.net Logo