Tags:
archive_me1Add my vote for this tag create new tag
, view all tags

Bug: "sub putBackVerbatim" is broken

Subroutine putBackVerbatim does not correctly convert greater-than symbols; it is a cut-n-paste error from the previous line. Causes havok when doing BNF for other angle-intensive stuff.

Test case

Look at the generated html for this:

<sample> the > is not converted to &amp;gt;, but it left bare.

Environment

TWiki version: TWikiBetaRelease
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS: N/A
Web server: N/A
Perl version: N/A
Client OS: N/A
Web Browser: N/A

-- BryanEwbank - 09 Mar 2004

Follow up

Patch to fix attached (view raw to copy and paste correctly)
Index: TWiki.pm
===================================================================
RCS file: /cvsroot/twiki/twiki/lib/TWiki.pm,v
retrieving revision 1.325
diff -r1.325 TWiki.pm
2963c2963
<             $val =~ s/</&gt;/g;
---
>             $val =~ s/>/&gt;/g;

I guess we first need to be clearer about what verbatim is. So far it's been about not altering content, rather than making sure browswer render it as typed; so I have changed the to a FeatureEnhancementRequest. This change makes sense, but might need to be more general and we need to be sure there are no side effects.

-- JohnTalintyre - 23 Apr 2004

Fix record

Topic revision: r4 - 2008-08-28 - TWikiJanitor
 
Twitter Delicious Facebook Digg Google Bookmarks E-mail LinkedIn Reddit StumbleUpon    
  • Download TWiki
TWiki logo Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2012 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.