Tags:
create new tag
, view all tags

Who am I?

Byron Darrah

What do I want?

write access to SVN for the following branches: MAIN, or whatever is appropriate for contributing to the EditTablePlugin.

What can I do?

I've created a modified version of the EditTablePlugin that uses DHTML to let users quickly and easily delete and move rows around, with no trips to the server. Non Javascript-enabled/aware clients should experience no difference with these changes.

I'd like to check this in.

Why do I want to do it?

I use TWiki and have on several occasions wanted/needed to move rows around within a table, add a row somewhere other than the end of an edittable, and delete a row from somewhere other than the end of an edittable. Of course it can be done by edititing the "raw" TWiki code for the page, but a quicker and friendlier way would be very useful.

I think several comments from other users on the EditTablePluginDev indicate this modification would be generally useful.

Other Notes:

Topics I have contributed to.

Topic Last Modified Sorted descending Last Editor
Codev.WebStatistics 2017-09-24 - 07:01 Main.unknown
Plugins.EditTablePluginDev 2012-07-11 - 09:11 PeterThoeny
Codev.EditTablePluginDHTML 2007-03-16 - 23:37 ArthurClemens
Codev.ByronDarrahWouldLikeToCheckIn 2007-03-15 - 00:17 ByronDarrah

Questions and Comments:

That sounds like a very nice addition to that plugin! Thank you for sharing!

-- JosMaccabiani - 01 Mar 2007

I would love to see development happening on the EditTablePlugin.

And adding and moving rows is also on my wish list.

Some words of caution. EditTablePlugin is a default plugin so it is treated the same as the core code. This means that updates must be backwards compatible in the sense that existing topics must not break when you upgrade TWiki. I have not tried your patch yet - I will for sure - so this may be the case. Compatible does not mean "work the same". It means must not break the existing edit tables.

Another detail. You may know this and then sorry for sounding like an old school teacher wink But just in case let me brief you with an important detail.

TWiki is developed in two branches.

MAIN holds the main (surprise) branch that drives the development of TWIki and also contains all the plugins.

Patch04x01 is a stable branch which is used for patch releases in the 4.1 series. Default plugins are maintained in both branches. All other plugins only in MAIN - even though you find them in the Patch branch.

But since Patch04x01 must remain stable - anything but bug fixes must happen only in MAIN. And in this case we are talking a major enhancement which will need some testing for a good while before we merge it to Patch04x01. So provided that your application is accepted - and I support that - only use MAIN for the development. When the plugin is ready for release we may merge it to Patch04x01. Or we may wait for 4.2.0. I am the release manager for the Patch branch so I am responsible for keeping it stable. But I will personally put an effort into getting your update stable and altered if the feature is not supported by the community as it is first implemented - because I have a great personal interest in this kind of feature.

-- KennethLavrsen - 01 Mar 2007

Thank you, Kenneth. Indeed, lecture away. I want to make sure I'm complying with expected conventions. I've jumped around on the Codev pages trying to make sure I know them, but I didn't know about the Patch04x01 branch. I'll make sure to only check in to MAIN.

I think I've been careful to avoid any unwanted side effects of my changes, and have tested in two major browsers both with Javascript on and off while observing client and server logs. I'm usually pretty careful about that, yet I appreciate that I'm only one person and the next pair of eyes may notice something I've completely missed.

In code management, words of caution are always appropriate :-).

-- ByronDarrah - 02 Mar 2007

Thanks Byron for contributing your enhancement, the TWikiCommunity greatly appreciates this! Kenneth gave a very good intro, I have nothing to add, besides that I am looking forward to see your activity in svn's MAIN/twikiplugins branch. (Sven is usually inviting new folks to svn.)

-- PeterThoeny - 02 Mar 2007

Hello Byron, welcome to the twiki-plugins svn commiters list smile

I've enabled you early, because I've got very intermittent internet access for the next weeks.

-- SvenDowideit - 02 Mar 2007

-- ByronDarrah - 06 Mar 2007

Thank you, Sven! Hmm... how can I authenticate? Using my twiki.org username and password doesn't seem to work.

-- ByronDarrah - 06 Mar 2007

Is someone with access to develop.twiki.org picking up this question?

-- KennethLavrsen - 13 Mar 2007

Byron, you might find it easier to work with the (just added) EditRowPlugin when moving rows around etc. It has a data structure for representing the table, and a REST handler to support fast updates.

Just a thought.

-- CrawfordCurrie - 13 Mar 2007

yeah, I think logging on should be fixed now - there's an hourly sync of passwords going on now

-- SvenDowideit - 14 Mar 2007

Thanks, I was able to log on and check in the change.

Crawford: Thanks for the tip I'll investigate the EditRowPlugin.

-- ByronDarrah - 15 Mar 2007


Priority Proposal Status Proposed For Contributors
Number of topics: 0

Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2007-03-15 - ByronDarrah
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.