Tags:
create new tag
, view all tags
Some URLs are wrong in mailnotify. This is a fix I suggest


In script bin/mailnotify :

<        $wikiuser = &TWiki::userToWikiName( $userName );
160d158
<        $newText =~ s/%AUTHOR%/$wikiuser/go;
165a164,167
> 
>        $wikiuser = &TWiki::userToWikiName( $userName );
>       $wikiuser =~ s/Main\.//go;
>        $newText =~ s/%AUTHOR%/$wikiuser/go;


File templates/changes.tmpl :

31c31
<     <a href="%SCRIPTURLPATH%/view%SCRIPTSUFFIX%/%WEB%/%TOPICNAME%"><b>%TOPICNAME%</b></a>
---
>     <a href="%SCRIPTURL%/view%SCRIPTSUFFIX%/%WEB%/%TOPICNAME%"><b>%TOPICNAME%</b></a>
34c34
<     <a href="%SCRIPTURLPATH%/rdiff%SCRIPTSUFFIX%/%WEB%/%TOPICNAME%">%TIME%</a> - %REVISION%
---
>     <a href="%SCRIPTURL%/rdiff%SCRIPTSUFFIX%/%WEB%/%TOPICNAME%">%TIME%</a> - %REVISION%
36c36
<     %AUTHOR%
---
>     <A HREF="%SCRIPTURL%/view%SCRIPTSUFFIX%/%MAINWEB%/%AUTHOR%">%AUTHOR%</A>

-- PatrickNomblot - 12 Sep 2003

Thanks for the patch! The logic seems sensible, but it's a bit difficult to figure out where the first part goes, since the TWikiAlphaRelease has changed since the version you diff'ed - if you could do a context diff, as mentioned in PatchGuidelines, it would make it easier to apply this.

-- RichardDonkin - 12 Sep 2003

In the past we made several changes to the links in mailnotify to make it compatible with all kinds of e-mail clients. Your fix needs to be tested against many clients before we can take it into the release. What kind of problems did you have, with what kind of clients?

This topic should to be moved to the Codev web. (After Patrick has read this)

-- PeterThoeny - 13 Sep 2003

Category: TWikiPatches

As far as I can tell from the diff above, it's just a change in the URL inside <A HREF>. I don't see how this suggested change could cause any problems to mail clients.

According to TWikiVariables, the (old) %SCRIPTURLPATH% is merely the path of the script: /cgi-bin without the host, whereas the (new) %SCRIPTURL% is the entire URL: http://twiki.org/cgi-bin, and that sounds right.

-- TorbenGB - 17 Sep 2003

Moved this topic from the Support web to here.

-- PeterThoeny - 02 Jan 2004

Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2004-01-02 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.