Tags:
create new tag
, view all tags

Bug: The function "addUserToTWikiUsersTopic" incorrectly adds new users to the topic

Using Apache authentication and REMOTE_USER, newly registered users do not get added to the TWikiUsers topic correctly - typically new users are added to the "J" series of users. I have looked at TWiki::User::addUserToTWikiUsersTopic but am still a neophyte as to what might be going on.

Test case

Most recent example:

#  I - - - - -
# IanDale - R8AAHG - 18 Jan 2005
# IrenaLoutchkina - a18652 - 15 Feb 2005
# IsiahTisdale - ra8990 - 19 Aug 2003
# ItaiKatz - rm05202 - 30 Mar 2005
# IulianMihai - iumihai1 - 16 Feb 2005
# IvanHovey - ra2289 - 14 Feb 2005
# J - - - - -
# MaidinGrahic - R9AAJS - 03 Jun 2005
# RogerCastillo - rat911 - 03 Jun 2005
# RonLiechty - rat109 - 03 Jun 2005
# JakeSkolnik - cdsr14 - 07 Apr 2003

This mis-ordering occurred after I hand edited the topic and made sure all entries were in alphabetical order, as I thought perhaps the problem occurred due to entries already being out of order. Today this mis-entry occurred as above.

Environment

TWiki version: TWikiRelease02Sep2004
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS: Solaris 2.9
Web server: Apache/1.3.31 (Unix) PHP/4.3.8
Perl version: 5.6.1
Client OS: WindowsXPsp2
Web Browser: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

-- SteveRJones - 03 Jun 2005

Impact and Available Solutions

Follow up

Attempting to take the Dakar code change and back-apply to Cairo . . .

-- SteveRJones - 08 Jun 2005

Fix record

Discussion

i set ProposedFor to CairoRelease (i guess the now disappeared AppliesTo form field would have been more appropriate) because this code has been significantly reworked for DakarRelease (which i believe i fixed with SVN 4340). if this is broken in the CairoRelease, will there be someone who will provide a patch?

-- WillNorris - 05 Jun 2005

Why not do this:
- Add the users to the topic at the end but in a table format.
- Using a table with sorting capabilities would allow a twikiadmin to be able to look at the userbase one of three ways:

-- SteveRJones - 07 Jun 2005

Will, you say you fixed it -- the Dakar version? It does appear to be broken in Cairo - in fact, it was broken in the 01FEB2003 version and looks like it carried forward. I suppose it did because few use this feature, but it plays very nicely with corporate auth services.

I suppose I could noodle out what is going on, but I am not a Perl guru by any stretch.

-- SteveRJones - 07 Jun 2005

Will, other than some laundering of the contents of this topic (this will be laundered out, right) could you check out RegistrationEntriesWronglyPlacedInTWikiUsers? Can the patch that you made to Dakar be ported to Cairo? Is this something that I need to pursue? Thanks.

-- SteveRJones - 07 Jun 2005

I was a little bit glad to see this existed in Cairo as some had suggested that I might have caused this bug in my work on Dakar... To answer your question this part of the code is largely unchanged from Cairo to Dakar so I would imagine that you could easily retrofit the patch.

-- MartinCleaver - 08 Jun 2005

Ok, I'll give it a shot. Thanks!

-- SteveRJones - 08 Jun 2005

Wellll, I took a look at the code in Cairo and the code in Dakar -- and to my neophyte eyes the code has substantially changed from Cairo to Dakar, so doing a quick fix is (for me) out of the question. I suspect the problem has to do with not detecting the alphabetic anchors correctly and in Dakar it is detected via:

} elsif ( $line =~ /^\s+\*\s([A-Z]) - / ) {
+               #       * A - - - - -^M
+               $name = $1;
and then the new test
if( $name && ( $user->wikiName() le $name ) )

but regex is still largely foreign to me, the variables are quite different (as this is now OO code), and I would be hacking on a production instance. I still would like to see Dakar keep this data in a table format that makes it easier for Twikiadmins to manage.

-- SteveRJones - 10 Jun 2005

Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2005-06-10 - SteveRJones
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.