Refactoring Proposal: Skin files must be duped in their entirety

Motivation

Duplicating code that may change is a VeryBadIdea

Description

Standard skins need to be factored a lot

-- MeredithLesly - 14 Feb 2006

Impact and Available Solutions

Documentation

If necessary, developer documentation of new features and changed APIs introduced by this proposal.

Examples

topicactionbutton.pattern.tmpl, to be included in view.patternskin.tmpl. This simplifies changing just the topicactionbutton area.

Implementation

Any comments on how the refactoring is implemented or could be improved

Discussion

Any idea?

-- RafaelAlvarez - 14 Feb 2006

I'm not quite understanding this - I'v ejust made a skin based on PatternSkin? - my skin has only 2 files view.sven.tmpl and twiki.sven.tmpl, and these 2 files ony contain definitions for those UI elements I changed from PatternSkin? . seems to work fine... (SKIN=sven,pattern)

-- SvenDowideit - 15 Feb 2006

The idea is that if you want to change the toolbar only, and that code is in a smaller subtemplate, you will have less code to update when PatternSkin is updated.

-- ArthurClemens - 15 Feb 2006