Tags:
create new tag
, view all tags

Bug: Patch to fix some Perl warnings I see in my apache logs

There are various places in the TWiki Perl code where values are not checked for undef, etc. before being used. This causes warnings to be spewed into the web server log file, which can obscure REAL errors.

Test case

Environment

TWiki version: TWikiBetaRelease2004x10x30
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS: RedHat Linux 8.0, kernel 2.4.18-19.8.0
Web server: Apache 2.0.40-8
Perl version: 5.8.0
Client OS:  
Web Browser:  

-- PaulSmith - 15 Jun 2005

Impact and Available Solutions

Follow up

Fix record

Discussion

I'll attache a patch which is quite self-explanatory. After applying this patch (and a fix for the issue with Search.pm not quoting files correctly when invoking grep; see BadTwikiNamesCauseSearchToFail) most of the warnings in my error log are gone.

There may be a bit of fuzz here because I needed to make some changes to integrate TWiki with our internal authentication system.

-- PaulSmith - 15 Jun 2005

See also CleanApacheErrorLog

-- CrawfordCurrie - 16 Jun 2005

Added another fix. I'm not sure what the status of the CleanApacheErrorLog page is: there's a note saying future reports need to be added to the bugs web...?

-- PaulSmith - 28 Jun 2005

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatpatch twiki-x1.patch r1 manage 1.5 K 2005-06-28 - 16:05 PaulSmith Another fix, to the TablePlugin.pm
Unknown file formatpatch warnings.patch r1 manage 2.4 K 2005-06-15 - 22:09 PaulSmith Patch to fix warnings in Perl code
Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2005-06-28 - PaulSmith
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.