Bug: Patch to fix some Perl warnings I see in my apache logs

There are various places in the TWiki Perl code where values are not checked for undef, etc. before being used. This causes warnings to be spewed into the web server log file, which can obscure REAL errors.

Test case

Environment

-- PaulSmith - 15 Jun 2005

Impact and Available Solutions

Follow up

Fix record

Discussion

I'll attache a patch which is quite self-explanatory. After applying this patch (and a fix for the issue with Search.pm not quoting files correctly when invoking grep; see BadTwikiNamesCauseSearchToFail) most of the warnings in my error log are gone.

There may be a bit of fuzz here because I needed to make some changes to integrate TWiki with our internal authentication system.

-- PaulSmith - 15 Jun 2005

See also CleanApacheErrorLog

-- CrawfordCurrie - 16 Jun 2005

Added another fix. I'm not sure what the status of the CleanApacheErrorLog page is: there's a note saying future reports need to be added to the bugs web...?

-- PaulSmith - 28 Jun 2005