Tags:
archive_me1Add my vote for this tag create new tag
, view all tags

DateFieldPlugin As Default Plugin

WillNorris proposed on WhatIsIn04x01 that we include DateFieldPlugin in the default set of plugins we ship with TWiki - starting from version 4.1

This needs to be discussed here on Codev.

And we will for sure need a vote on a release meeting.

Please voice your oppinion.

-- Contributors: KennethLavrsen, WillNorris - 01 Oct 2006

Discussion

As I write this I have no oppinion yet, because I never tried the plugin. But it has to be very value adding to our main target group to be in the default distro IMHO. I will give it a try.

I have the impression that the features it adds are small, so it should also be considered if its function is better merged into core to avoid the plugin runtime overhead.

-- KennethLavrsen - 01 Oct 2006

I don't think this plugin should be shipped as the default. Instead, date fields should be supported in FormDotPm.

-- ThomasWeigert - 01 Oct 2006

I think a date form field type is a basic feature for TWikiForms, so I support adding this feature by default.

For performance reasons possibly better to take this into the core. If taken into the core we need to make sure the dependencies are OK, e.g. if it is OK to add additional libraries (if any.)

-- PeterThoeny - 01 Oct 2006

We need to ensure that this has a graceful fall back when JS is not enabled. This relies on JSCalendarContrib, which would mean that we would promote that Contrib to part of core?

-- ThomasWeigert - 01 Oct 2006

I agree. I can't see a problem with shipping JSCalendarContrib by default, though as Thomas says a graceful fallback is essential.

-- CrawfordCurrie - 02 Oct 2006

Are anyone willing to to drive the action of adding the code from DateFieldPlugin to the core? If so - the current consensus seems to be that this would be OK.

However if the plugin is to be added - as is - then it needs a community vote as inclusion of new default plugins is a very sensitive subject. And I sense it would not be voted in as a new plugin.

-- KennethLavrsen - 05 Oct 2006

It is making sure there is a graceful fallback that requires work. I am also wondering about whether we should make any JS part of the core... I know... I am contradicting myself... I am also concerned about Twisty...

-- ThomasWeigert - 06 Oct 2006

Noone have volunteered to implement this in core. This means that the original proposal goes up for vote at next release meeting.

  • I don't mind to do the perl integration. It is the "graceful fallback" that I need somebody else have some good ideas on. -- TW
    • How difficult would it be to graceful fallback date fields to ordinary textfields with a label that shows the accepted date formats?

-- KennethLavrsen - 12 Oct 2006

I am against shipping any plugins as default that require JS but do not have a graceful fall back in case JS is not active.

-- ThomasWeigert - 12 Oct 2006

Very good point, graceful fallback is required.

-- PeterThoeny - 12 Oct 2006

From EdinburghReleaseMeeting2006x10x16

  • Vote for including the plugin as it is today. 4 NO. 0 Yes.
  • The "adding to core" alternative needs to be defined before we can vote for this. Discussion continues in DateFieldPluginAsDefaultPlugin. The mood was for such a core feature provided it has graceful fallback and does not hurt performance.

-- KennethLavrsen - 16 Oct 2006

I will implement. But not this week...

-- ThomasWeigert - 17 Oct 2006

Thanks Thomas for commiting to it. smile

-- PeterThoeny - 17 Oct 2006

I have changed the status from parked to accepted on WhatIsIn04x01. The only conditions people had at the release meeting was the graceful fallback and not hurting performance. As long as these two requirements are met - and I am sure they will be with Thomas as driver since the concerns were raised by Thomas in the first place - I see no issue with declaring this accepted.

Thomas - when you pick up the task add a short description here about how you will implement it so especially Arthur can help reviewing it. And thanks for picking this one up Thomas.

-- KennethLavrsen - 17 Oct 2006

Checked in the code changes. Need to still update the doco.

If JS is disabled, one can enter in the input area. If somebody has any idea of avoiding printing the icon when JS is disabled, that would be great. I do not know how to check for this condition.

-- ThomasWeigert - 24 Oct 2006

One idea: Print the icon using javascript (write the "img" tag into the page). If JS is not present, it won't be rendered.

  • This can be done with Twisty in the same manner as the textarea buttons are displayed (arrows and monospace/proportional). -- ArthurClemens - 24 Oct 2006

-- RafaelAlvarez - 24 Oct 2006

Used the TwistyPlugin to show the button. Great idea, Arthur. Marking this as done...

-- ThomasWeigert - 26 Oct 2006

I am not sure what has been done here. The status in WhatIsIn04x01 is confusing.

-- ArthurClemens - 13 Feb 2007

The ability to have dates in form fields is now in core so this plugin is not needed any longer....

-- ThomasWeigert - 14 Feb 2007

Given the last comment, I'm marking this as "MergedToCore" for EdinburghRelease

-- TWikiJanitor - 17 Sep 2008

Edit | Attach | Watch | Print version | History: r24 < r23 < r22 < r21 < r20 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r24 - 2008-09-17 - TWikiJanitor
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.