Tags:
create new tag
, view all tags

TWiki Patches

These patches are not part of the official TWiki code base, until they go through the normal bug/feature process - this is just another way of finding them. See ReadmeFirst to find features and bugs based on the development process; some of these may not yet have any code attached.

Please read the PatchGuidelines to make sure your patch is easily reviewed and applied by the CoreTeam and other TWiki users.

See also: CategoryCategory for a list of other categories in this web.

Searched: ^Category: TWikiPatches

Results from Codev web retrieved at 19:12 (GMT)

This is a small patch that will show you the diffs of attachments. I wrote it with the idea that you could see the differences between various versions of an attached...
Problem The WEB.TOPIC moved from OLDTOPIC on date by user put it back message is too visible and distracts users. I thinks it belongs more to the `More...` screen...
There are two implementation strategies available for this request: PeterKlausner implemented a method that simply pulls out the beginning of the topic for use...
Use DBM Files for the User Database The site where I`ve just set up a restricted access wiki uses DBM files (AuthDBUserFile) instead of flat files to store user password...
WARNING : this topic applies only to TWiki releases prior to TWiki 4. Do not attempt to apply this patch to TWiki 4! I tweaked TWiki.pm so that it will automatically...
Summary Lots of people want the ability to click on a link to send a page to someone the reader specifies. Of course, cutting and pasting is always an option. Creating...
always creates links. This is not always preferable. Putting nop before does not work because the link is already there. In TWiki.pm (renderParent) the parent...
META should be rendered in other templates other than view Quite a few templates do not support META variables. This makes it difficult to have consistent interface...
Suggestion: get rid of RCS strict locking mode Problem I got also bitten by this problem at my company`s wiki: after an apache restart (apache on debian linux), apache...
Follow up from WhatAboutSearchEngines. Modification time: No, dynamically generated pages to not show a Last Modified time. Anybody knows if there is a trick to so...
# TWiki Formatted Search in Topics Abstract %SEARCH is extended to permit formatting and displaying of each location in a topic which meets the specified search...
Introduction I have been working on a way to create tables using the pre existing form capability. What I have done was expand the current TablePlugin routines to...
Bug: ISO Charset is computed wrong from locale TWiki computes content type charset from site locales, missing an hyphen for iso 8859 charsets. Test case In TWiki...
DeleteMe petition: please keep this page for historical reasons DanielKabs 14 Apr 2005 Features are implemented (SearchScopeForTopicAndText, KeywordSearchWithImplicitAnd...
How to show parent topics Original proposal This is a small UI detail I would like to solve for the new release. Currently the view template has the parent topics...
Bug: Diffs Function Does Not Authenticate Properly problem occurs with a web that has ALLOWWEBVIEW set to a specific group in TWikiRelease01Dec2001, view...
//TWikiDocGraphics/hand.gif see BatchUploadPlugin Might I request the ability to upload multiple attachments at once, through a .zip or .tar.gz archive? We`re rolling...
In VariableExpansionInWarningAndDebugFilename KevinBaker proposes: logFilename from Twiki.cfg has expanded into the current year/month. warningFilename and...
I began tackling myself the problem of enhancing email notification in TWiki. I will state here the goals to satisfy and hope to be able to implement them progressively...
Bug: Search fails if started with Dash Try performing a search that starts with a ` `. The starting the search string is interpreted by the grep commands as more...
This change lets TWiki support proper HTTP/1.1 URLs in % INCLUDE{. This allows you to % INCLUDE{ sites that are virtually hosted, for example, twiki.org itself, where...
Has anyone implemented a mechanism to automatically size the edit window according to the resolution of the screen being used? I imagine that this would require the...
Bug: On Win2k upload can incorreclty fail with zero size file message In bin/upload you can incorrectly get a file size of zero from the s or stat methods on...
See also RefreshEditPageDiscuss When I edit page in loop like Edit Preview Changes Save Changes Edit etc., I should press `Refresh` button of the browser...
Proposed for CairoRelease I am running my TWiki`s under WinNt and Windows95, and have noticed a subtle problem caused by the differences between Filesystems. On UNIX...
Bug: Failed To Create History File For Binary Attachments On Windows I get the following error: TWiki . Main . WebHome (oops) Attention Topic save error During...
Email Notification Enhancements (index page) I propose that we keep this page as a central gateway page for all the current efforts (and hopefully available patches...
Bug: Metacharacters can be passed through to the shell in File Attach I noticed using a single quote (`) character in the comment field in Attach File causes the RCS...
Bug: TOC generated HTML is not closed The HTML tags that are generated by TOC do not close properly. Test case Environment TWiki version: TWikiRelease01Feb...
Includes of remote pages using includes fail Using a proxy with TWiki fails. It doesn`t send a proxy HTTP request. It claims to send an HTTP 1.1 request...
Bug: Upload script does not generate image sizes of PNG image attachments Upload does retrieve the image sizes of GIF and JPEG images, but not of PNG images. Test...
Currently (15 Aug 2003) TWiki handles its preferences in a way that is hardly optimal: preferences are stored as two arrays (one is for keys and the other is for values...
Implemented: added CssClassNames to Diff output this is documented in CssClassNames. RDiff colours are hardwired into rdiff The background colours for the `deleted...
Unless I`ve missed it, there`s currently no way to handle the ROWSPAN attribute for WikiTableSyntax. Basically, how would you construct a table such as :...
See MetaDataRendering (when it appears). Various meta data can be stored in topics MetaDataDefinition This is rendered using the % META% variable. This is mostly...
Rendering the unified output of diff Category: TWikiPatches This is what I did to make the rdiff script handle unified diff output. Unified diff output is what you...
Implemented: display changes in TWikiFormsValues TWiki Diff settings To configure the default DiffRenderingStyle and Number of Context lines use the following variables...
Bug: Preview does no Quote hrefs and Catches hrefs Outside Anchors When previewing, all links should be disabled. However, if an HTML hyperlink does not surround its...
I have made a patch to show Someotherwebname when you write the internal link to another web Home page as: Someotherwebname.WebHome . Extremely useful when you...
Bug: includeUrl() screws up absolute urls The arguments to cleanupIncludedHTML are read in the wrong order, causing absolute URLs (those beginning with a `/` (slash...
Always see local server time, everywhere, never anything else Some people have this specific requirement, e.g. on company intranets that are not international. Some...
Bug: Create new web fails if RCS files do not exist If you don`t want to change the lock name in the rcs files and delete them all (as suggested in the installation...
Bug: GNU egrep Breaks with Escaped Curly Brace GNU egrep (as of version 2.4.2) breaks on \{\} which is used in METASEARCH. My version gives the log entry `egrep: Invalid...
Implemented: New $wikiname variable in format parameter of formatted search Summary: FormattedSearch understands now $username , $wikiname () and $wikiusername...
Bug: Double Quotes not Handled Correctly in TWiki Forms In a TWiki form the double quote ``` is replaced by #34 to avoid HTML confusion, it should be #34<nop...
Bug: Use % HOMETOPIC% not WebHome In the supplied TWiki docs, all references to WebHome should refer to % HOMETOPIC%, in order to be consistent with user...
We are playing with using TWiki to serve as our project development space for a small project here at my work. We have created a web/zone for the project. We then...
Bug: Small Typos in Plugins.pm While investigating an odd problem I was having with a plugin, I noticed a couple of small typos in Plugins.pm. The only one that really...
A patch, which delegates the WebForm table to the table renderer. Why? Generally, it is a good idea to blend table colour/shading style with the other web background...
Search engines like Google highlight the search terms in the summaries of the search results (example). It would be nice, if the TWiki search could provide a similar...
Instant e mail notification of changes Category: TWikiPatches This is what I added to MegaTWiki to have instant notification when somebody changes a web page. I guess...
Bug: Form Topics Fail Across Webs .TWikiForms do not work across webs. If I create a form following the directions, the sourced tables do not load. This question has...
Bug: testenv script failed when using SiePerl. The testenv script failed to run when running under SiePerl. Test case Installed SiePerl first. Then follow instructions...
Bug: regex `once` option fails for mod perl A lot of the regexs in TWiki use the `o` optimization flag to restrict regex compiles to one time only for speed purposes...
In the current (10 Sep 2002) beta release, one can put a plugin hook on saving topic. This is a useful feature, and as I needed it for the NavbarPlugin, I added this...
Some scripts in the Dec 2001 release omit to specify the skin used when loading templates. Namely: attach changes mailnotify oops register rename This should be...
Not sure if anyone`s already covered this, since I`m new around here, but it seems like a perfect thing to be able to render searches as RSS summaries for inclusion...
There`s a bug in the routine TWiki::getTWikiLib. It doesn`t normalize more than one relative parent directory (eg, a /../ in the path). For example, if TWiki.pm is...
Bug: Viewfile Script Uses Topic Name Instead of File Name There`s a bug with the TWiki/bin/viewfile script in the current distribution. This module will always change...
I stubled on a bug while designing a new skin. When searching multiple web, only one instance of % WEB% is expansed in the repeated pattern per web. fix: On file...
Bug: Net::SMTP code fails when it cannot connect to mail host The Net.pm module`s Net::SMTP code fails when it cannot connect to a mail host (e.g. because an Internet...
Bug: Change Password does not work on Win2K Thanks to your work, registering and password do now work on Win2K with Apache. But you can`t change or reset your password...
Environment July Beta Apache 1.3.20 Windows NT 4.0sp6 mod perl/1.25 01 dev ActiveState Perl Build 623 Doing a search on `Thoeny` returned 4 items plus 19 lines of...
They`re working on this over at JspWiki: http://www.ecyrd.com/JSPWiki/Wiki.jsp?page WikiRPCInterface And I`ve implemented this for TWiki over here: http...
Number of topics: 64

Searched: ^Category: TWikiPatches

Results from Support web retrieved at 19:12 (GMT)

Question I have a problem in a web where search does not work anymore. The web has too many topics in it for grep, it sais: bash: /bin/grep: Argument list too long...
Question Hi, I searched the twiki site, but could not find an answer to my preoccupation. In a single web, I want to build some hierarchy software, logic, verif...
Question logFilename from Twiki.cfg has expanded into the current year/month. warningFilename and debugFilename do not. I came across this as our admin...
Question I had a really wierd problem with my webserver setting the cwd for the scripts to the root directory of the webserver instead of the directory of the script...
Question I`m running TWiki under OS/390 and all the links to edit, search and upload are rewritten as escaped EBCDIC Chars so search at TWiki.Main.WebHome will be...
Question Hello, I would like to modify the way mailnotify script create links to modified topics, I think it would be more useful if the links pointed to differences...
Question TWiki version: Dec 2001 Web server: Apache/1.3.6 (Unix) mod perl/1.21 mod ssl/2.2.8 OpenSSL/0.9.2b Server OS: Cobalt Raq 3/Linux 2.2 Web browser...
Question Is it possible to add save button in addition to the Preview Changes button? Sometimes i don`t want to preview the changes. . TWiki version: Web...
Question . I think there`s an anomaly in anchor linking, particularly when the 32 character limit on an anchor ends with an underbar ` `. See the link to the heading...
Number of topics: 9

The aim is to make it easier for users to find patches that may help, though it may also be useful for TWiki maintainers. This should really be implemented as a WebForm field, if people find this useful.


Some other Wikis, e.g. UseModWiki and WikkiTikkiTavi, have pages that collect together patches, e.g. http://tavi.sourceforge.net/TaviPatches - they usually use a sub-pages feature, but that's not essential.

It would be useful if TWiki.org could have such a page, perhaps with a new FeaturePatch and/or BugPatch category, to make it easier to find this code. Particularly handy for smaller patches that can't be done as plugins or are simply fixing bugs in the core code.

What do you think?

-- RichardDonkin - 18 Feb 2002

Sounds good, or maybe an alternative is to add either a new TopicClassification like "PatchAvailable", or a new form field "PatchAvailable" with values "Yes" and "No". (Or, if necessary, values like "PatchIncludedInBeijing" which implies that the patch might be useful for versions before the Beijing release.)

-- RandyKramer - 18 Feb 2002

I think a new PatchAvailable field is a good option - that way it's easy to find all patches, even those for earlier releases. If the feature/bug is included in a specific release, that should be clear from the existing ImplementationDate field.

It would also be good to try to get people to do proper diff -c patches if possible (can even be done on Windows using CygWin).

-- RichardDonkin - 19 Feb 2002

I'll go to WebForm and take a shot at this -- never done it so I don't know what problems I'll run into, perhaps even an objection to adding it -- we'll see what happens. I guess I'll include three or four values -- yes, no, unknown (the default for topics until someone looks at it to see if there is a patch), and maybe n.a. (not applicable).

Oops, never mind -- I don't have access -- I guess a member of the administrator group has to make the change.

-- RandyKramer - 19 Feb 2002

Anybody in the administrator group interested in adding a PatchAvailable field to the default form for this web? (with values Yes, No, and Unknown)

-- RandyKramer - 24 Feb 2002

I've added an embedded search for the TWikiPatches keyword (i.e. using it as a Wiki:WikiBadge). I'd prefer to use a field, of course.

-- RichardDonkin - 25 Feb 2002

A new TWiki patch category sounds like a good idea. The current TWikiPatches does not include the TWiki version, so it might get confusing after the next release.

By functionality, how does TWikiPatches differ from the known issues page like KnownIssuesOfTWiki01Dec2001? May be we can merge the ideas of the known issues and patches?

-- PeterThoeny - 07 Mar 2002

It's intended just as a way of finding pages that have code to fix problems (or add features) - ideally it would be just another field on the main WebForm for Codev, plus some embedded searches on this page. The known-issues pages are good, but there are not always fixes. Also, quite a lot of bugs are reported, and fixed by patches, without making it onto the known-issues pages. The TWikiPatches page could almost be another view into the list of bugs (with fixes) - ideally support pages with patches would be moved into BugReports, but they will often appear in Support.

This is not intended to bypass the development process, but it is useful to be able to search based on 'is there code', for features as well as for bugs, to bypass topics that haven't yet got to that stage. The actual pages should specify to which release the patches apply, of course. I do find ImplementationDate a bit confusing, though - it could be read as the release to which this fix applies, or the release in which the feature/fix is scheduled to be released. I think it's the latter, but it's a bit unclear (although I've now noticed the tooltip!) - perhaps IncludeInRelease/ScheduledForRelease and AppliesToRelease would be useful? I know the latter is in the main page for bug reports, but it might be good if it was searchable.

This confusion is probably partly because I've been avoiding the pop-up help window in the Codev WebForm, because they trigger BackFromPreviewLosesText... However, the ImplementationDate page could be improved to say 'scheduled for' as well as 'implemented in' (or is it only set when the code is in CVS?).

-- RichardDonkin - 07 Mar 2002

It seems to me the difference between KnownIssuesOfTWiki and TWikiPatches, is that the former does not (yet) have a patch and the latter does. Someone creating a patch for a known issue should edit the known issues page to add a link to the patch imo.

-- DavidLeBlanc - 11 Mar 2002

How about the following new fields in the Codev WebForm?

  • PatchAvailable - equivalent of including 'Category: TWikiPatches' - set if there is some code available. If/when the patch is included in TWiki core, the ImplementationDate is set, making it clear which release it applied to - for patches that don't make it into the core, the text of the page should make it clear which version the bug/feature applies to in any case.
  • PriorityLevel - this is unrelated to patches, but would be useful for features and particularly bug reports. People would set this, and CoreTeam could reset this based on their task queue and the importance/urgency of the fix. Values would be High, Medium, Low.

-- RichardDonkin - 22 Mar 2002

See CodevFields for some discussion of how form fields could be used to support this page, and TWikiPatchMaster for a more formalised approach to patches.

-- RichardDonkin - 02 Sep 2002

In discussion with CrawfordCurrie, he expressed this very well. The problem is that TWiki is "old code technique". This is illustrated when he said:

        "At the moment each of these services is passed a 'useful' subset of the 
         state of the TWiki for them to process; for example, the commonTagsHandler 
         gets the text, the web and the topic, but none of the rest of the state. 
         This is a pain. Meta-data, the store object, a search cache, are all examples 
         of other state that would be useful to plugins but are presently inaccessible. 
         So, I see the TWiki processing pipeline as a series of state transformations, 
         each executed by a service. The services may in turn invoke other services, 
         passing in either the TWiki state object or a sub-state."

What he's describing, and what I'm working on, in discussion with others. is an Object Oriented model. Everything, storage, rendering, TWikiML, should be implemented by ojbects that permit over-rides of the methods to extend the functionality. When I have a critical core to present I'll put it here wink

Object technology is a state machine. The "Object" holds state information and the methods define the allowable transitions on that state.

Handing a "TopicObj" instead of a parameter list gets around the limitations described above. (It also has many, many other interesting implciation to storage, separation of data and metadata, different types of mark-up and so forth. Think of me as Hephaestus weilding an axe and OO Twiki as Athena ...) The complications are that any and all objects are currently "distrubuted" though the code-base. Any shift to OO using the current code base is going to break a lot of things and a lot of work is going to have to be done in "rationalization".

-- AntonAylward - 24 May 2003

Anton, from your other post and from this one I got a feeling you are strong perl guru. I applaud your intentions to make OO Twiki. There was already one attempt: MegaTWiki. Succesfull (running) but fork from rather old code.

I'll also like to see OO Twiki as CGI::Application based, with HTML::Templates (or other major templating system). I hope CoreTeam will support TWikiOO, but from reluctance to accept even simpler other enhancements I will expect your code to be a fork. Which is possibly not a bad idea - but then, better way might be to build on CgiWiki (CGI::Wiki) CPAN package. So instead of overhauling all Twiki, you'll pick it feature by feature and add it into OO core.

CgiWiki already supports multiple storage architectures and looks promising...

-- PeterMasiar - 24 May 2003

The strength of Twiki is in the plugins. CGI::Wiki has a long, long way to go. I don't think that throwing away the expereicne of TWiki and flipping over to CGI::Wiki is a good idea.

Peter, I hope that onece I get my design sketches for TWikiOO up you'll give some input based on your MegaTWiki experiences. I wouldn't call myself a guru-anything. I've just done a lot over a long time and have learnt some wrong things to avoid and right thigns to do.

PeterThoeny has done a great job. What makes TWiki different from the just-a-wiki is that you can build applications with it without being a Perl programmer, using the plugins that are there and some ingenuity. Just having OO to over-ride the storage methods and the rendering methods aala CGI:Wiki isn't there. Maybe it will be, but I think that using what we have and what we know is more focused than building a perfectly general purpose wiki assembly kit. After all, its tha applications that sell in the corporate arena.

Yes, the rate of innovation here has slowed. Perhaps OO will jump start it.

-- AntonAylward - 25 May 2003

I appreciate work of PeterThoeny, too. And I was looking around and decided to try Twiki (more than a year ago) because of plugins, too. Maybe what we need is two oficial distros, like debian has: stable (current twiki), and testing (with more adventurous features), updateable via .RPM or .DEB or something easy. I was trying to create a distro with BetterDefaults, but it looks way over my head a with my skills and time constraints.

-- PeterMasiar - 27 May 2003

Two level releases, or at least having a release thread that is marked 'experimental' and 'unstable', is a great idea. However it needs to go hand in hand with two other things.

  • "Release early, release often". As thigns stabilise migrate them into the stable thread.As it is, as as is discussed elsewhere, there are many patches and enhancements that have not made the main release.
  • An effective upgrade mechanism.
    The present update mechanism is problematic. part of teh problem is that it over-writes any patches that may have been aplied since the previous release. Having releases so far apart is is part of the problem.

What is over your head, Peter, and over mine to no matter my experience, is tracking all those patches. What we need is a topic that tracks and consolidates all the patches since the last release. One topic where you can download all the patches.

-- AntonAylward - 27 May 2003

Two things about that last point: one this topic attempted to do just that, and two, the FeatureHack classification system is a better mechanism than asking in a topic that is easily buried for people to write "Category: _anything"; people are just not going to see know that topic exists (BTW: can we get this topic in the top banner, someone also asked for CodevDocumentationProject to also be listed.)

From a general point, don't let my comments let anyone think that I don't appreciate the work that Peter has put in. I do. I just think that the project has grown to a size where we need more delegation (a la CoreTeamNominations), make more use of tools (a la ActionTrackerPlugin) and have better structure and processes (a la TWikiPatchMaster, TWikiPerformanceMaster). Without structure we will continue to be buried in complexity and without delegation we just can't move at the speed we did when TWiki was a smaller project.

People look up to Peter's leadership role to delegate responsibility even though (and here I am guessing) he is still responsible for a lot of the new coding. Other people can take responsibility but however partitioning of responsibility is achieved, clear areas of responsibility can only help reduce duplication, avoid gaps and get a (workable) schedule for CairoRelease.

-- MartinCleaver - 27 May 2003

See CodevFields for discussion of a better way of tracking patches and generally fixing the rather hard to use Codev forms setup. TWikiPatches' use of a Wiki:WikiBadge was meant to be a temporary fix only, but CodevFields did not end up generating a conclusion about better form fields, so we are stuck with it for now.

Having a better TWikiOrgNavigation structure would be very useful to guide people to the right areas - at the moment we are far too dependent on WebChanges, WebForms and whatever's linked directly from WebHome, particularly in Codev and Support. This is tied into CodevFields, in that suitable fields make it easy to automatically find people in the right part of a hierarchical TWikiOrgNavigation structure.

-- RichardDonkin - 27 May 2003

Edit | Attach | Watch | Print version | History: r20 < r19 < r18 < r17 < r16 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r20 - 2006-01-03 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2015 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.